glusterfs.git/libglusterfs, branch v3.7.4

posix: xattrop 'GF_XATTROP_GET_AND_SET' implementation

2015-08-27T13:45:50+00:00

This is a backport of http://review.gluster.org/#/c/11995

GF_XATTROP_GET_AND_SET stores the existing xattr
value in xdata and sets the new value

xattrop was reusing input xattr dict to set the results
instead of creating new dict.
This can be problem for server side xlators as the inout dict
will have the value changed.

> Change-Id: I43369082e1d0090d211381181e9f3b9075b8e771
> BUG: 1251454
> Signed-off-by: vmallika 

Change-Id: I7e0c27fd415131e9983a10d27067f63ed3a7701e
BUG: 1257441
Signed-off-by: vmallika 
Reviewed-on: http://review.gluster.org/12022
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System 
Reviewed-by: Raghavendra G

libgfapi: Gracefully exit when glfd is invalid

2015-08-26T16:17:19+00:00

This is a backport of: http://review.gluster.org/10759

When glfs_* methods operating on glfd are invoked after calling
glfs_close(), the program segfaults inside __GLFS_ENTRY_VALIDATE_FD
trying to deference glfd->fd->inode which is invalid.

Also, returning EBADF seemed more specific than EINVAL.

BUG: 1240920
Change-Id: I13a92dca52da9a300252b69e026581b3a9e931fd
Signed-off-by: Prashanth Pai 
Reviewed-on-master: http://review.gluster.org/10759
Tested-by: Gluster Build System 
Reviewed-by: Shyamsundar Ranganathan 
Reviewed-on: http://review.gluster.org/11571
Reviewed-by: Niels de Vos 
Reviewed-by: Humble Devassy Chirammal 
Reviewed-by: bipin kunal 
Tested-by: NetBSD Build System

libglusterfs: write error handling when filesystem have no space left

2015-08-25T06:09:20+00:00

When no space left on filesystem and user want to perform any operation
which result to change in /var/lib/glusterd/* files then glusterd is
failing to write on temporary file.

Fix is to handle error when write failed on temporary files due to no
space left on file system.

Change-Id: I79d595776b42580da35e1282b4a3cd7fe3d14afe
BUG: 1253148
Signed-off-by: Gaurav Kumar Garg 
Reviewed-on: http://review.gluster.org/11029
Reviewed-by: Niels de Vos 
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System 
Reviewed-by: Cedric Buissart
(cherry picked from commit e7f737e62a9ea9eac730b6ba3ef8739e497e1540)
Reviewed-on: http://review.gluster.org/11902
Reviewed-by: Atin Mukherjee

protocol/server: forget the inodes which got ENOENT in lookup

2015-08-21T11:48:48+00:00

                 Backport of http://review.gluster.org/11489

If a looked up object is removed from the backend, then upon getting a
revalidated lookup on that object ENOENT error is received. protocol/server
xlator handles it by removing dentry upon which ENOENT is received. But the
inode associated with it still remains in the inode table, and whoever does
nameless lookup on the gfid of that object will be able to do it successfully
despite the object being not present.

For handling this issue, upon getting ENOENT on a looked up entry in revalidate
lookups, protocol/server should forget the inode as well.

Though removing files directly from the backend is not allowed, in case of
objects corrupted due to bitrot and marked as bad by scrubber, objects are
removed directly from the backend in case of replicate volumes, so that the
object is healed from the good copy. For handling this, the inode of the bad
object removed from the backend should be forgotten. Otherwise, the inode which
knows the object it represents is bad, does not allow read/write operations
happening as part of self-heal.

Change-Id: I268eeaf37969458687425187be6622347a6cc1f1
BUG: 1255604
Signed-off-by: Raghavendra Bhat 
Reviewed-on: http://review.gluster.org/11973
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System 
Reviewed-by: Raghavendra G

logging: Stop using global xlator for log_buf allocations

2015-08-18T17:07:20+00:00

This reverts commit 765849ee00f6661c9059122ff2346b03b224745f.

With http://review.gluster.org/#/c/10417/, struct mem_accnt
is no longer embedded in a xlator_t object, but instead is
allocated separately. Hence this workaround provided to avoid
crashes in logging infrastructure is no longer needed

This is a backport of the below fix -
http://review.gluster.org/11811

BUG: 1254436
Change-Id: I4bbf7649bdc29424ff1bb878f79e99328efa0b3e
Signed-off-by: Soumya Koduri 
Reviewed-on: http://review.gluster.org/11811
Reviewed-by: N Balachandran 
Reviewed-by: Kaleb KEITHLEY 
Reviewed-on: http://review.gluster.org/11946
Tested-by: Gluster Build System 
Reviewed-by: Jeff Darcy 
Tested-by: NetBSD Build System

rpc: add owner xlator argument to rpc_clnt_new

2015-08-14T10:10:47+00:00

The @owner argument tells RPC layer the xlator that owns
the connection and to which xlator THIS needs be set during
network notifications like CONNECT and DISCONNECT.

Code paths that originate from the head of a (volume) graph and use
STACK_WIND ensure that the RPC local endpoint has the right xlator saved
in the frame of the call (callback pair). This guarantees that the
callback is executed in the right xlator context.

The client handshake process which includes fetching of brick ports from
glusterd, setting lk-version on the brick for the session, don't have
the correct xlator set in their frames. The problem lies with RPC
notifications. It doesn't have the provision to set THIS with the xlator
that is registered with the corresponding RPC programs. e.g,
RPC_CLNT_CONNECT event received by protocol/client doesn't have THIS set
to its xlator. This implies, call(-callbacks) originating from this
thread don't have the right xlator set too.

The fix would be to save the xlator registered with the RPC connection
during rpc_clnt_new. e.g, protocol/client's xlator would be saved with
the RPC connection that it 'owns'. RPC notifications such as CONNECT,
DISCONNECT, etc inherit THIS from the RPC connection's xlator.

Change-Id: I9dea2c35378c511d800ef58f7fa2ea5552f2c409
BUG: 1253212
Signed-off-by: Krishnan Parthasarathi 
Reviewed-on: http://review.gluster.org/11436
Tested-by: Gluster Build System 
Tested-by: NetBSD Build System 
Reviewed-by: Raghavendra G 
(cherry picked from commit f7668938cd7745d024f3d2884e04cd744d0a69ab)
Reviewed-on: http://review.gluster.org/11908
Reviewed-by: Pranith Kumar Karampuri

cluster/tier: fix 64 bit issue with sql query using times

2015-08-13T16:08:43+00:00

This is a backport of 11885.

> We overflowed when converting seconds to usecs in preperation for
> sql queries. The fix uses uint64_t throughout including subexpressions.

> Change-Id: I59bdb742197400dede97f54735b52030920b0d19
> BUG: 1231268
> Signed-off-by: Dan Lambright 

Change-Id: Iaef7083dac7a162080f4bc23e29dedfe700fa342
BUG: 1252903
Signed-off-by: Dan Lambright 
Reviewed-on: http://review.gluster.org/11913
Tested-by: NetBSD Build System 
Reviewed-by: Joseph Fernandes

libgfdb/ctr: Fixing rename or update of link

2015-08-12T13:46:53+00:00

Backport of http://review.gluster.org/11584 to 3.7.2

Fixing rename or updating of link in
1) libgfdb : handling return from updatelink
2) ctr xlator: correcting freeing of oldbase name in
               hardlink list in the update link

>Change-Id: I1789c492b81876123cd456051a9ae495e876ad46
>BUG: 1241054
>Signed-off-by: Joseph Fernandes 
>Reviewed-on: http://review.gluster.org/11584
>Tested-by: Joseph Fernandes
>Reviewed-by: Dan Lambright 
>Tested-by: Dan Lambright 
>Tested-by: Gluster Build System 
Signed-off-by: Joseph Fernandes 

Change-Id: I6da86c06e390f62fe8a44ade7b1efda5771e9ca8
BUG: 1242536
Signed-off-by: Joseph Fernandes 
Reviewed-on: http://review.gluster.org/11649
Tested-by: Gluster Build System 
Reviewed-by: Dan Lambright

cluster/ec: Minimize usage of EIO error

2015-08-08T15:36:57+00:00

>Change-Id: I82e245615419c2006a2d1b5e94ff0908d2f5e891
>BUG: 1245276
>Signed-off-by: Xavier Hernandez 
>Reviewed-on: http://review.gluster.org/11741
>Tested-by: Gluster Build System 
>Reviewed-by: Pranith Kumar Karampuri 
>Tested-by: NetBSD Build System 

Change-Id: Ifd3d63f88a686a2963c5ba2e62110249f84f338d
BUG: 1250864
Signed-off-by: Xavier Hernandez 
Reviewed-on: http://review.gluster.org/11852
Reviewed-by: Pranith Kumar Karampuri 
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System

SSL improvements: ECDH, DH, CRL, and accessible options

2015-08-05T11:52:04+00:00

- Introduce ssl.dh-param option to specify a file containinf DH parameters.
  If it is provided, EDH ciphers are available.

- Introduce ssl.ec-curve option to specify an elliptic curve name. If
  unspecified, ECDH ciphers are available using the prime256v1 curve.

- Introduce ssl.crl-path option to specify the directory where the
  CRL hash file can be found. Setting to NULL disable CRL checking,
  just like the default.

- Make all ssl.* options accessible through gluster volume set.

- In default cipher list, exclude weak ciphers instead of listing
  the strong ones.

- Enforce server cipher preference.

- introduce RPC_SET_OPT macro to factor repetitive code in glusterd-volgen.c

- Add ssl-ciphers.t test to check all the features touched by this change.

Backport of I7bfd433df6bbf176f4a58e770e06bcdbe22a101a

Change-Id: I2947eabe76ae0487ecad52a60befb7de473fc90c
BUG: 1247153
Signed-off-by: Emmanuel Dreyfus @
Reviewed-on: http://review.gluster.org/11763
Tested-by: NetBSD Build System 
Reviewed-by: Jeff Darcy