glusterfs.git/libglusterfs/src/syscall.c, branch v4.1.3

libglusterfs: Handle FS errors gracefully

2017-11-22T10:07:36+00:00

Problem:
FS sometimes doesn't give the expected return values. We need our common
functions to guard against this.
Example BUG: https://bugzilla.redhat.com/show_bug.cgi?id=864401

Fix:
When the return value is not as per specification, change the return value
to -1 and errno to EIO

BUG: 1469487
Change-Id: I14739ab2e5ae225b1a91438b87f8928af56f2934
Signed-off-by: Pranith Kumar K

storage/posix: Adding implementation for posix_do_futimes

2017-10-05T12:57:35+00:00

Adding the implementation for the posix_do_futimes function which is
not complete in the current implementation and giving the ENOSYS error.

Change-Id: I9cfc95a7ea293b0a2df8efd4ac80d0120b3120e4
BUG: 1350406
Signed-off-by: karthik-us

posix: fix incorrect xattr list handling on FreeBSD

2017-08-29T13:32:52+00:00

Change-Id: I5be157259f0b665640aaa1eda68063bb19fd7b3d
BUG: 1484246
Signed-off-by: Pellaeon Lin 
Signed-off-by: Jiffin Tony Thottan 
Reviewed-on: https://review.gluster.org/17917
Smoke: Gluster Build System 
Reviewed-by: Amar Tumballi 
Reviewed-by: Niels de Vos 
CentOS-regression: Gluster Build System

posix: use nanosecond accuracy when available

2017-03-07T17:10:02+00:00

Programs that set mtime, such as `rsync -a`, don't work correctly on
GlusterFS, because it sets the nanoseconds to 000. This creates
problems for incremental backups, where files get accidentally copied
again and again.

For example, consider `myfile` on an ext4 system, being copied to a
GlusterFS volume, with `rsync -a` and then `cp -u` in turn. You'd
expect that after the first `rsync -a`, `cp -u` agrees that the file
need not be copied.

BUG: 1422074
Change-Id: I89c7b6a73e2e06c02851ff76b7e5cdfaa271e985
Signed-off-by: Niklas Hambüchen 
Reviewed-on: https://review.gluster.org/16667
Smoke: Gluster Build System 
Reviewed-by: Niels de Vos 
Tested-by: Jeff Darcy 
NetBSD-regression: NetBSD Build System 
Reviewed-by: jiffin tony Thottan 
CentOS-regression: Gluster Build System 
Reviewed-by: Jeff Darcy

posix: Fix creation of files with S_ISVTX on FreeBSD

2017-02-18T17:22:29+00:00

On FreeBSD the S_ISVTX flag is completely ignored when creating a
regular file. Since gluster needs to create files with this flag set,
specialy for DHT link files, it's necessary to force the flag.

This fix does this by calling fchmod() after creating a file that
must have this flag set.

Change-Id: I51eecfe4642974df6106b9084a0b144835a4997a
BUG: 1411228
Signed-off-by: Xavier Hernandez 
Reviewed-on: https://review.gluster.org/16417
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Raghavendra Bhat 
Reviewed-by: Kaleb KEITHLEY

libglusterfs: fix statvfs in FreeBSD

2017-01-10T17:08:00+00:00

FreeBSD interprets statvfs' f_bsize field in a different way than Linux.

This fix modifies the value returned by statvfs() on FreeBSD to match
the expected value by Gluster.

Change-Id: I930dab6e895671157238146d333e95874ea28a08
BUG: 1356076
Signed-off-by: Xavier Hernandez 
Reviewed-on: http://review.gluster.org/16361
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
Reviewed-by: Kaleb KEITHLEY 
CentOS-regression: Gluster Build System 
Reviewed-by: Jeff Darcy

core: use readdir(3) with glibc, and associated cleanup

2016-07-18T11:59:42+00:00

Starting with glibc-2.23 (i.e. what's in Fedora 25), readdir_r(3)
is marked as deprecated. Specifically the function decl in 
has the deprecated attribute, and now warnings are thrown during the
compile on Fedora 25 builds.

The readdir(_r)(3) man page (on Fedora 25 at least) and World+Dog say
that glibc's readdir(3) is, and always has been, MT-SAFE as long as
only one thread is accessing the directory object returned by opendir().
World+Dog also says there is a potential buffer overflow in readdir_r().
World+Dog suggests that it is preferable to simply use readdir(). There's
an implication that eventually readdir_r(3) will be removed from glibc.
POSIX has, apparently deprecated it in the standard, or even removed it
entirely.

Over and above that, our source near the various uses of readdir(_r)(3)
has a few unsafe uses of strcpy()+strcat().

(AFAIK nobody has looked at the readdir(3) implemenation in *BSD to see
if the same is true on those platforms, and we can't be sure of MacOS
even though we know it's based on *BSD.)

Change-Id: I5481f18ba1eebe7ee177895eecc9a80a71b60568
BUG: 1356998
Signed-off-by: Kaleb S. KEITHLEY 
Reviewed-on: http://review.gluster.org/14838
Smoke: Gluster Build System 
Reviewed-by: Niels de Vos 
CentOS-regression: Gluster Build System 
NetBSD-regression: NetBSD Build System 
Reviewed-by: Kotresh HR 
Reviewed-by: Jeff Darcy

libglusterfs: Fix security prefix comparison

2016-05-04T11:28:29+00:00

BUG: 1331860
Change-Id: If35012ee35104848d7d3b21900c7f533d0253cde
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.org/14194
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Jeff Darcy

build: reduce warnings when building the syscall compatibility layer

2016-04-25T08:18:42+00:00

For whatever reason my Fedora 23 started to complain loudly when
compiling syscall.c.

Change-Id: I72d278d6dc9abb77018c2590c113552383b639d1
BUG: 1198849
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/14034
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
NetBSD-regression: NetBSD Build System 
Reviewed-by: Kaleb KEITHLEY

experimental: add fdl (Full Data Logging) translator

2016-02-13T13:13:07+00:00

NSR needs logging that is different than our existing changelog in
several ways:

 * Full data, not just metadata

 * Pre-op, not post-op

 * High performance

 * Supports the concept of time-bounded "terms"

Others (for example EC) might need the same thing.  This patch adds such
a translator.  It also adds code to dump the resulting journals, and to replay
them using syncops, plus (very rudimentary) tests for all of the above.

Change-Id: I29680a1b4e0a9e7d5a8497fef302c46434b86636
Signed-off-by: Jeff Darcy 
Reviewed-on: http://review.gluster.org/12450
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
NetBSD-regression: NetBSD Build System