glusterfs.git/libglusterfs/src/statedump.c, branch v3.7.19

core: use reference counting for mem_acct structures

2015-05-09T21:27:36+00:00

When freeing memory, our memory-accounting code expects to be able to
dereference from the (previously) allocated block to its owning
translator.  However, as we have already found once in option
validation and twice in logging, that translator might itself have
been freed and the dereference attempt causes on of our daemons to
crash with SIGSEGV.  This patch attempts to fix that as follows:

 * We no longer embed a struct mem_acct directly in a struct xlator,
   but instead allocate it separately.

 * Allocated memory blocks now contain a pointer to the mem_acct
   instead of the xlator.

 * The mem_acct structure contains a reference count, manipulated in
   both the normal and translator allocate/free code using atomic
   increments and decrements.

 * Because it's now a separate structure, we can defer freeing the
   mem_acct until its reference count reaches zero (either way).

 * Some unit tests were disabled, because they embedded their own
   copies of the implementation for what they were supposedly testing.
   Life's too short to spend time fixing tests that seem designed to
   impede progress by requiring a certain implementation as well as
   behavior.

Change-Id: Id929b11387927136f78626901729296b6c0d0fd7
BUG: 1219026
Signed-off-by: Jeff Darcy 
Reviewed-on: http://review.gluster.org/10417
Tested-by: Gluster Build System 
Reviewed-by: Krishnan Parthasarathi 
Reviewed-by: Niels de Vos 
Reviewed-by: Pranith Kumar Karampuri 
Reviewed-on: http://review.gluster.org/10723
Tested-by: NetBSD Build System

statedump: Print curr_stdalloc in mempool statedump ...

2014-08-30T02:31:41+00:00

 ...for, it is curr_stdalloc that is incremented for every mem_get()
and decremented on every call to mem_put() and can be used to detect
leaks, when cold_count is 0.

Change-Id: I418a132c3ea4c0b99ea5c6840ff3024d8d19ddf4
BUG: 1134221
Signed-off-by: Krutika Dhananjay 
Reviewed-on: http://review.gluster.org/8557
Tested-by: Gluster Build System 
Reviewed-by: Humble Devassy Chirammal 
Reviewed-by: Pranith Kumar Karampuri 
Tested-by: Pranith Kumar Karampuri

statedump: Don't print mem-type numbers

2014-07-07T04:21:58+00:00

Change-Id: I381bfa9535fe60c37758761d34b98dbbc4e5f569
BUG: 1114188
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.org/8239
Reviewed-by: Krishnan Parthasarathi 
Reviewed-by: Humble Devassy Chirammal 
Tested-by: Justin Clift 
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

meta: export process state dump

2014-05-06T00:29:27+00:00

Various parts of process state dump are exposed
through most appropriate virual files/dirs

Change-Id: Iff30f8ea76552f2f6d9c98def688c5ec4bc6f2af
BUG: 1089216
Signed-off-by: Anand Avati 
Reviewed-on: http://review.gluster.org/7542
Tested-by: Gluster Build System 
Reviewed-by: Harshavardhana

mem-accounting: store type string and print in meta

2014-05-06T00:27:51+00:00

Change-Id: Ied1de473c72967110b54f033768f7ac60bf66edc
BUG: 1089216
Signed-off-by: Anand Avati 
Reviewed-on: http://review.gluster.org/7541
Tested-by: Gluster Build System 
Reviewed-by: Harshavardhana

statedump: strfd based APIs

2014-05-06T00:27:37+00:00

Expose strfd based APIs for extracing various types of xlator
state information.

Change-Id: Ibbb6594b6fb31206bc6a1b1ea6514ed41889583b
BUG: 1089216
Signed-off-by: Anand Avati 
Reviewed-on: http://review.gluster.org/7540
Tested-by: Gluster Build System 
Reviewed-by: Harshavardhana

glusterfs : Moved option files, and statedumps from /tmp

2013-01-29T23:27:29+00:00

Change-Id: Ibdede396c4d6859225937316b7a59a661bcaf9f5
BUG: 764890
Signed-off-by: Avra Sengupta 
Reviewed-on: http://review.gluster.org/4422
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

Use more portable mkstemp() instead fo mkostemp()

2012-11-22T18:06:45+00:00

mkostemp() with O_CREAT|O_EXCL|O_RDWR|O_TRUNC|O_APPEND is mkstemp()
and mkstemp() is available on more systems than mkostemp()

NULL-commit to cause jankins ro rebuild

BUG: 764655
Change-Id: I6ee0f635d3699bd70b0963b24af07bd7d5c2dc58
Signed-off-by: Emmanuel Dreyfus 
Reviewed-on: http://review.gluster.org/4152
Reviewed-by: Kaleb KEITHLEY 
Tested-by: Gluster Build System

glusterfs: code cleanup

2012-10-16T05:43:02+00:00

Change-Id: I99bbb720d8b42c8b3899bb1353c6b73f7fcd50f1
BUG: 764890
Signed-off-by: Raghavendra Bhat 
Reviewed-on: http://review.gluster.org/4042
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

protocol/server: dump the ltable and fd table related inodes only

2012-09-18T04:15:07+00:00

Do not dump the entire inode table in the statedump. Instead dump
those inodes only which are present in fdtable or ltable.

Change-Id: If848f9a6198927b4cc0abd47339461f3ea41d6df
BUG: 844688
Signed-off-by: Raghavendra Bhat 
Reviewed-on: http://review.gluster.org/3848
Tested-by: Gluster Build System 
Reviewed-by: Amar Tumballi 
Reviewed-by: Anand Avati