glusterfs.git/libglusterfs/src/logging.c, branch v3.12.5

logging: localtime logging, cmdline, volume set option

2017-08-03T12:04:50+00:00

Despite the fact that appliances generally use UTC, some
users really want log entries in localtime.

fixes gluster/glusterfs#272

feature page: https://review.gluster.org/17807

Backport from master https://review.gluster.org/#/c/16911/

Change-Id: I5fbf2c3eedd9eb128fb3f851dd67b2f4081c8bba
Signed-off-by: Kaleb S. KEITHLEY 
Reviewed-on: https://review.gluster.org/17928
CentOS-regression: Gluster Build System 
Smoke: Gluster Build System 
Reviewed-by: Shyamsundar Ranganathan

fuse: memory leak fixes

2017-07-14T09:35:24+00:00

Fix fuse ctx memory leak in case an error occurs and the cleanup path
is different than usual. Also fix a memory leak in logging if
eh_save_history() fails.

Change-Id: I7ec967c807b0ed91184e5b958be70702215c46c9
BUG: 1470220
Signed-off-by: Danny Couture 
Reviewed-on: https://review.gluster.org/17759
Reviewed-by: Niels de Vos 
Smoke: Gluster Build System 
Reviewed-by: N Balachandran 
Reviewed-by: Prashanth Pai 
Reviewed-by: Amar Tumballi 
Tested-by: Amar Tumballi 
CentOS-regression: Gluster Build System 
Reviewed-by: Raghavendra G

logging: Support for Structured logging format

2017-06-29T11:55:39+00:00

Wrapper for `gf_log` and `gf_msg` to add support for
structured logging format.

Two new wrappers available `gf_slog` and `gf_smsg`

Example 1: All static details

    gf_slog ("cli", GF_LOG_INFO, "Volume Set",
             "name=gv1",
             "option=changelog.changelog",
             "value=on",
             NULL);

    gf_smsg ("cli", GF_LOG_INFO, 0, MSGID_VOLUME_SET,
             "Volume Set",
             "name=gv1",
             "option=changelog.changelog",
             "value=on",
             NULL);

Example 2: Using Format chars in key values

    gf_slog ("cli", GF_LOG_INFO, "Volume Set",
             "name=%s", volume_name,
             "option=%s", option_name,
             "value=%s", option_value,
             NULL);

    gf_smsg ("cli", GF_LOG_INFO, 0, MSGID_VOLUME_SET,
             "Volume Set",
             "name=%s", volume_name,
             "option=%s", option_name,
             "value=%s", option_value,
             NULL);

Formats as,

    ...

Example:

    Volume Set	name=gv1	option=changelog.changelog	value=on

Updates: #240
Change-Id: I871727be16a39f681d41f363daa0029b8066fb52
Signed-off-by: Aravinda VK 
Reviewed-on: https://review.gluster.org/17543
Reviewed-by: MOHIT AGRAWAL 
Smoke: Gluster Build System 
Reviewed-by: Amar Tumballi 
Tested-by: Amar Tumballi 
CentOS-regression: Gluster Build System 
NetBSD-regression: NetBSD Build System

Do not call va_end twice in _gf_log_eh

2017-02-24T14:49:19+00:00

Since va_end is called after the out label,
we do not need to call it here, as it make va_end undefined,
and thus could cause problem. And this is a error
on cppcheck.

Change-Id: I6e96c796bd37fa3cde989996ab93f9a438c0ee74
BUG: 789278
Signed-off-by: Michael Scherer 
Reviewed-on: https://review.gluster.org/16745
Smoke: Gluster Build System 
Tested-by: Michael Scherer 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Shyamsundar Ranganathan

logging: Fix per xl log level

2016-08-15T12:04:15+00:00

Currently per xlator loglevel setting doesn't work, due to the
flaw in loglevel checking. Fix the same.

Per xlator logging can be set using the below command:

Eg: setfattr -n trusted.glusterfs.patchy-md-cache.set-log-level -v TRACE /mnt/glusterfs/0

Change-Id: I8ff1d15bd5693b6f682d99bee22a4bbb5eee646c
BUG: 1362520
Signed-off-by: Poornima G 
Reviewed-on: http://review.gluster.org/15071
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Niels de Vos 
Reviewed-by: Jeff Darcy

libglusterfs: coverity fix

2016-04-14T12:55:50+00:00

fix missing varargs cleanup

CID 1124856: string overflow

CID 1124656: NULL return

CID 1124374: constant expression

Change-Id: Iead530c599bdfef05a40c68b892215f4e4f02247
BUG: 789278
Signed-off-by: Sakshi Bansal 
Reviewed-on: http://review.gluster.org/9630
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Jeff Darcy

libglusterfs: open cmd_history log file with O_APPEND and O_WRONLY

2016-03-29T19:10:47+00:00

Commit 8fdfa0c introduced a fix to ensure cmd_history file is log rotated
properly. However with this fix fdopen() is called with mode "a" on a fd which
was not opened with O_WRONLY & O_APPEND resulting into a fdopen() failure.

Fix is to open cmd_history.log file with O_CREATE|O_WRONLY|O_APPEND mode

Change-Id: I75ef350560aa6d5435c78c5fd83adfde1a73bfc3
BUG: 1286959
Signed-off-by: Atin Mukherjee 
Reviewed-on: http://review.gluster.org/13829
Smoke: Gluster Build System 
Reviewed-by: Niels de Vos 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System

gfapi: Fix the crashes caused by global_xlator and THIS

2016-03-23T05:47:31+00:00

Issue: http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10922

The right fix for this is elaborate and intrusive, until it is in place,
this patch provides a temperory fix. This fix is necessary, as without this
libgfapi applications like qemu, samba, NFS ganesha are prone to crashes.
This patch will be reverted completely, once the actual fix gets accepted.

Change-Id: Ic975ab0bb03ba415cdf9bddba1534ba4d2d2820c
BUG: 1319374
Signed-off-by: Poornima G 
Reviewed-on: http://review.gluster.org/13784
Smoke: Gluster Build System 
Reviewed-by: Shyamsundar Ranganathan 
Reviewed-by: Jeff Darcy 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System

libglusterfs: close & open cmd_history.log on log rotate

2016-02-04T21:51:53+00:00

Post log rotate, cmd_history.log is not refreshed (closed & opened back)
due to which new commands still land up in the log rotated file.

Fix is to close and open cmd_history.log file upon log rotation

Change-Id: Ie6990c9d55b0afa544bc5c84de3db49ff4b1299b
BUG: 1286959
Signed-off-by: Gaurav Kumar Garg 
Reviewed-on: http://review.gluster.org/12832
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Niels de Vos 
NetBSD-regression: NetBSD Build System

core: use syscall wrappers instead of direct syscalls - libglusterfs

2015-11-16T14:18:10+00:00

various xlators and other components are invoking system calls
directly instead of using the libglusterfs/syscall.[ch] wrappers.

If not using the system call wrappers there should be a comment
in the source explaining why the wrapper isn't used.

Change-Id: Ieeca2d36adbc884e4cfa0026dba40df70310d40b
BUG: 1267967
Signed-off-by: Kaleb S. KEITHLEY 
Reviewed-on: http://review.gluster.org/12275
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System 
Reviewed-by: Jeff Darcy