glusterfs.git/libglusterfs/src/graph.y, branch v3.12.5

libglusterfs: Fix a crash due to race between inode_ctx_set and inode_ref

2017-02-20T03:26:09+00:00

Issue:
Currently inode ref count is gaurded by inode_table->lock, and
inode_ctx is gauarded by inode->lock. With the new patch [1]
inode_ref was modified to change the inode_ctx to track the ref
count per xlator. Thus inode_ref performed under inode_table->lock
is modifying inode_ctx which has to be modified only under inode->lock

Solution:
When a inode is created, inode_ctx holder is allocated for all the xlators.
Hence in case of inode_ctx_set instead of using the first free index in
inode ctx holder, we can have predecided index for every xlator in the graph.

Credits Pranith K 

[1] http://review.gluster.org/13736

Change-Id: I1bfe111c211fcc4fcd761bba01dc87c4c69b5170
BUG: 1423373
Signed-off-by: Poornima G 
Reviewed-on: https://review.gluster.org/16622
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
Reviewed-by: Niels de Vos 
CentOS-regression: Gluster Build System 
Reviewed-by: Pranith Kumar Karampuri

core: assorted spelling mistakes reported by Debian

2016-05-26T15:55:16+00:00

See also
> Change-Id: I567a4be8f0f31f6285550f243fe802895f6bc43b

Reported-by: Patrick Matthäi 
BUG: 1336793

Change-Id: Icb9a6ff94d86663a5bca4ba931d810439c02556e
Signed-off-by: Kaleb S KEITHLEY 
Reviewed-on: http://review.gluster.org/14526
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Ravishankar N 
Reviewed-by: Jeff Darcy

core: use syscall wrappers instead of direct syscalls - tail

2015-11-16T23:20:17+00:00

tail, as in dog chasing its tail. These are the unwrapped
syscalls that have crept in (or were missed) in the previous
patches.

various xlators and other components are invoking system calls
directly instead of using the libglusterfs/syscall.[ch] wrappers.

If not using the system call wrappers there should be a comment
in the source explaining why the wrapper isn't used.

Change-Id: If183487de92fc7cbc47d4c5aa3f3e80eae50b84f
BUG: 1267967
Signed-off-by: Kaleb S KEITHLEY 
Reviewed-on: http://review.gluster.org/12589
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System 
Reviewed-by: Jeff Darcy

graph/libglusterfs : porting to a new logging framework

2015-06-26T02:58:08+00:00

Change-Id: I57ed5c979c15559443712a61f0b1a61c7f5557d8
BUG: 1194640
Signed-off-by: Mohamed Ashiq 
Reviewed-on: http://review.gluster.org/10822
Tested-by: NetBSD Build System 
Reviewed-by: Pranith Kumar Karampuri

libglusterfs: wrong function definition of synclock_destory().

2014-08-06T08:29:28+00:00

synclock_destory() has been prototyped in syncop.h,
how-ever synclock_destroy() is the actual function used in syncop.c.
Correcting this function definition along with few typos.


Change-Id: I35a818190c1d37c303279ca7a820f01895751bd9
BUG: 1075417
Signed-off-by: Humble Chirammal 
Reviewed-on: http://review.gluster.org/8266
Tested-by: Gluster Build System 
Reviewed-by: Raghavendra Talur 
Reviewed-by: soumya k 
Reviewed-by: Poornima G 
Reviewed-by: Vijay Bellur

glusterfsd, libgfapi: destroy the temporary graphs constructed for comparison

2013-10-04T04:32:43+00:00

* The new and the oldgraphs which have been constructed whenever there is
  a volfile change (either reconfigure of the existing graph or creating
  a new graph) for comparison should be freed. Otherwise frequent graph
  changes will lead to huge memory leak

Change-Id: I4faddb1aa9393b34cd2de6732e537a60f600026a
BUG: 948178
Signed-off-by: Raghavendra Bhat 
Reviewed-on: http://review.gluster.org/5388
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

parser: use private namespace 'graphyy' instead of 'yy'

2013-09-22T06:45:09+00:00

This can cause linker errors when accessing glusterfs through
libgfapi if the caller also uses a parser with 'yy' prefix.

Change-Id: I6544333c47a1f18193741420717c989e4bdea7b1
BUG: 764890
Signed-off-by: Anand Avati 
Reviewed-on: http://review.gluster.org/5643
Tested-by: Gluster Build System 
Reviewed-by: Amar Tumballi

parser: make the parser thread safe.

2013-09-07T00:54:10+00:00

The volfile parser thread safe by guarding the parsing phase
in a mutex. Thread safety becomes a problem when there are multiple
glfs_t objects created by gfapi and all of them potentially parse
the respective volfiles at the same time.

Change-Id: I4376019c4956994b72397ab36e6ac3ce849797ec
BUG: 1004519
Signed-off-by: Anand Avati 
Reviewed-on: http://review.gluster.org/5790
Reviewed-by: Raghavendra G 
Reviewed-by: Raghavendra Bhat 
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

glusterfsd: Cleanup temporary files from /tmp

2013-04-08T21:21:39+00:00

For each gluster{d,fs,fsd} start, one or more temporary
file(s) created in /tmp were not being unlinked. This
patch cleans that up.

Modified a typo in an unrelated log message as well.

Change-Id: I3dec2a2ca40c7d6828eb238ec9cd08b6072cf0dd
BUG: 949327
Signed-off-by: Vijay Bellur 
Reviewed-on: http://review.gluster.org/4786
Reviewed-by: Krishnan Parthasarathi 
Reviewed-by: Raghavendra Bhat 
Tested-by: Gluster Build System

glusterfsd: Fixed fd leak due to use of tmpfile()

2013-03-22T20:34:29+00:00

Change-Id: I3c2dc070ebe967100170e39f3545acacc6016d61
BUG: 924075
Signed-off-by: Krishnan Parthasarathi 
Reviewed-on: http://review.gluster.org/4703
Tested-by: Gluster Build System 
Reviewed-by: Jeff Darcy