glusterfs.git/libglusterfs/src/fd.c, branch v3.7.19

libglusterfs: Negate all but O_DIRECT flag if present on anon fds

2016-06-17T00:21:20+00:00

        Backport of: http://review.gluster.org/14665

This is to prevent any unforeseen problems that might arise due to
writevs and readvs being wound with @flag parameter containing
O_TRUNC or O_APPEND especially wrt translators like sharding and ec
where O_TRUNC write or O_APPEND write on individual shards/fragments
is not the same as O_TRUNC write or O_APPEND write as expected by the
application.

Change-Id: Ib0110731d6099bc888b7ada552a2abbea8e76051
BUG: 1342903
Signed-off-by: Krutika Dhananjay 
Reviewed-on: http://review.gluster.org/14735
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
Reviewed-by: Pranith Kumar Karampuri 
CentOS-regression: Gluster Build System

core, shard: Make shards inherit main file's O_DIRECT flag if present

2016-06-16T16:04:10+00:00

        Backport of: http://review.gluster.org/14191

If the application opens a file with O_DIRECT, the shards'
anon fds would also need to inherit the flag. Towards this,
shard xl would be passing the odirect flag in the @flags parameter
to the WRITEV fop. This will be used in anon fd resolution
and subsequent opening by posix xl.

Change-Id: I3a0593fa46cc25e390a5762a0354b469c2a1532d
BUG: 1342903
Signed-off-by: Krutika Dhananjay 
Reviewed-on: http://review.gluster.org/14663
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
NetBSD-regression: NetBSD Build System 
Reviewed-by: Jeff Darcy

libglusterfs: Even anonymous fds must have fd->flags set

2016-06-08T09:44:08+00:00

        Backport of: http://review.gluster.org/10219

We do not set the same flags to anonymous fd that posix uses to open
an anonymous fd in the backend. If there are any xlators which rely on
these flags for their operation they may not work well.

Add proper flags to anonymous fds at the time of their creation and
refer to them for subsequent operations.

Change-Id: I60d5b04ab851c31fbe4e5e74bee1af1b14daa52e
BUG: 1342903
Signed-off-by: Raghavendra Talur 
Reviewed-on: http://review.gluster.org/14662
Tested-by: Krutika Dhananjay 
NetBSD-regression: NetBSD Build System 
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Pranith Kumar Karampuri

all: reduce "inline" usage

2016-01-18T09:02:34+00:00

There are three kinds of inline functions: plain inline, extern inline,
and static inline.  All three have been removed from .c files, except
those in "contrib" which aren't our problem.  Inlines in .h files, which
are overwhelmingly "static inline" already, have generally been left
alone.  Over time we should be able to "lower" these into .c files, but
that has to be done in a case-by-case fashion requiring more manual
effort.  This part was easy to do automatically without (as far as I can
tell) any ill effect.

In the process, several pieces of dead code were flagged by the
compiler, and were removed.

backport of Change-Id: I56a5e614735c9e0a6ee420dab949eac22e25c155,
http://review.gluster.org/11769, BUG: 1245331

Change-Id: Iba1efb0bc578ea4a5e9bf76b7bd93dc1be9eba44
BUG: 1283302
Signed-off-by: Kaleb S KEITHLEY 
Reviewed-on: http://review.gluster.org/12646
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Niels de Vos

fd: Do fd_bind on successful open

2015-10-06T06:11:02+00:00

- fd_unref should decrement fd->inode->fd_count only if it is present in the
inode's fd list.
- successful open/opendir should perform fd_bind.

 >Change-Id: I81dd04f330e2fee86369a6dc7147af44f3d49169
 >BUG: 1207735
 >Signed-off-by: Pranith Kumar K 
 >Reviewed-on: http://review.gluster.org/11044
 >Reviewed-by: Anoop C S 
 >Tested-by: NetBSD Build System 
 >Tested-by: Gluster Build System 
 >Reviewed-by: Raghavendra G 

BUG: 1259697
Change-Id: I73b79dd3519aa085fb84dde74b321511cbccce1a
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.org/12100
Tested-by: Gluster Build System 
Tested-by: NetBSD Build System 
Reviewed-by: Raghavendra G

libgfapi: Gracefully exit when glfd is invalid

2015-08-26T16:17:19+00:00

This is a backport of: http://review.gluster.org/10759

When glfs_* methods operating on glfd are invoked after calling
glfs_close(), the program segfaults inside __GLFS_ENTRY_VALIDATE_FD
trying to deference glfd->fd->inode which is invalid.

Also, returning EBADF seemed more specific than EINVAL.

BUG: 1240920
Change-Id: I13a92dca52da9a300252b69e026581b3a9e931fd
Signed-off-by: Prashanth Pai 
Reviewed-on-master: http://review.gluster.org/10759
Tested-by: Gluster Build System 
Reviewed-by: Shyamsundar Ranganathan 
Reviewed-on: http://review.gluster.org/11571
Reviewed-by: Niels de Vos 
Reviewed-by: Humble Devassy Chirammal 
Reviewed-by: bipin kunal 
Tested-by: NetBSD Build System

libglusterfs removing strerror in logging

2015-07-28T13:47:06+00:00

        Backport of  http://review.gluster.org/11464

Cherry picked from 9384a824041aeef0e58644cc9fe71dc7fa13eb35
>Change-Id: I8a0f40834da1151ddaef6139af3782bc076df57e
>BUG: 1194640
>Signed-off-by: Mohamed Ashiq Liyazudeen 
>Reviewed-on: http://review.gluster.org/11464
>Tested-by: Gluster Build System 
>Tested-by: NetBSD Build System 
>Reviewed-by: Pranith Kumar Karampuri 

Change-Id: I8a0f40834da1151ddaef6139af3782bc076df57e
BUG: 1217722
Signed-off-by: Mohamed Ashiq Liyazudeen 
Reviewed-on: http://review.gluster.org/11727
Tested-by: Gluster Build System 
Tested-by: NetBSD Build System 
Reviewed-by: Pranith Kumar Karampuri

fd,inode/libglusterfs : porting to a new logging framework

2015-07-07T12:18:35+00:00

        Backport of http://review.gluster.org/#/c/10825/

Cherry picked from d32b221747cf6742cffaff5a60e16269dffd04cc
>Change-Id: I4beba3b50456f802824374b6e3fa8079d72f2c00
>BUG: 1194640
>Signed-off-by: Mohamed Ashiq 
>Reviewed-on: http://review.gluster.org/10825
>Reviewed-by: Pranith Kumar Karampuri 
>Tested-by: Pranith Kumar Karampuri 

Change-Id: I4beba3b50456f802824374b6e3fa8079d72f2c00
BUG: 1217722
Signed-off-by: Mohamed Ashiq 
Reviewed-on: http://review.gluster.org/11402
Tested-by: Gluster Build System 
Tested-by: NetBSD Build System 
Reviewed-by: Pranith Kumar Karampuri

libglusterfs: wrong function definition of synclock_destory().

2014-08-06T08:29:28+00:00

synclock_destory() has been prototyped in syncop.h,
how-ever synclock_destroy() is the actual function used in syncop.c.
Correcting this function definition along with few typos.


Change-Id: I35a818190c1d37c303279ca7a820f01895751bd9
BUG: 1075417
Signed-off-by: Humble Chirammal 
Reviewed-on: http://review.gluster.org/8266
Tested-by: Gluster Build System 
Reviewed-by: Raghavendra Talur 
Reviewed-by: soumya k 
Reviewed-by: Poornima G 
Reviewed-by: Vijay Bellur

build: MacOSX Porting fixes

2014-04-24T21:41:48+00:00

git@forge.gluster.org:~schafdog/glusterfs-core/osx-glusterfs

Working functionality on MacOSX

 - GlusterD (management daemon)
 - GlusterCLI (management cli)
 - GlusterFS FUSE (using OSXFUSE)
 - GlusterNFS (without NLM - issues with rpc.statd)

Change-Id: I20193d3f8904388e47344e523b3787dbeab044ac
BUG: 1089172
Signed-off-by: Harshavardhana 
Signed-off-by: Dennis Schafroth 
Tested-by: Harshavardhana 
Tested-by: Dennis Schafroth 
Reviewed-on: http://review.gluster.org/7503
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati