glusterfs.git/libglusterfs/src/fd.c, branch v3.1.3qa4

nfs: opendir/closedir for every readdir

2010-11-15T12:03:50+00:00

Revert "nfs3: Unref & unbind dir fd with inode lock on EOF"

This reverts commit 4e6fb304ce41acbaf7c9ba67c06bf443e65082e8.

The above commit (which unbinds fds at EOF) does not fix the original
bug (1619) because a readdir from a second app could have already
started before the readdir_cbk of the first app's readdir reaches
NFS code. Hence the race still exists.

Performing extra unrefs when EOF is received is not a reliable way
of detecting that a client has performed a closedir (and to close
the fd ourselves). Neither is interpreting a 0 cookies a new opendir.
Clients can always use telldir/seekdir and hit EOFs twice.

Due to the way NFS3 protocol is designed, it is just not possible
for the server to reliably detect opendirs/closedirs performed by
the client and map the corresponding readdirs to the same dir fd
on the server side.

The only reliable way of fixing this is to perform opendir/closedir
at the cost of performance. Any optimization towards keeping dir fds
open attempting to map them with application's opendir/closedir will
either result in fd leaks or extra fd unrefs.

Signed-off-by: Anand V. Avati 
Signed-off-by: Anand V. Avati 

BUG: 2061 (NFS server crashes in readdir_fstat_cbk due to extra fd unref)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2061

Change assert to GF_ASSERT

2010-10-12T09:39:01+00:00

Signed-off-by: Vijay Bellur 
Signed-off-by: Vijay Bellur 

BUG: 971 (dynamic volume management)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=971

Copyright changes

2010-10-11T14:31:12+00:00

Signed-off-by: Vijay Bellur 
Signed-off-by: Vijay Bellur 

BUG: 971 (dynamic volume management)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=971

Change GNU GPL to GNU AGPL

2010-10-04T14:50:05+00:00

Signed-off-by: Pranith Kumar K 
Signed-off-by: Vijay Bellur 

BUG: 1388 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1388

check for 'link_inode' in server protocol

2010-09-18T07:51:34+00:00

* also log and return in case of 'fd_bind' getting fd with NULL inode.

Signed-off-by: Amar Tumballi 
Signed-off-by: Vijay Bellur 

BUG: 1635 (running mixed tests glusterfs crashed)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1635

nfs3: Unref & unbind dir fd with inode lock on EOF

2010-09-17T13:24:01+00:00

..so that when EOF is reached on this fd, any further
requests on the same inode do not get handled through this
fd but result in a new fd being opened.

Unbinding results in the fd getting deleted from the inode's fd list.

Signed-off-by: Shehjar Tikoo 
Signed-off-by: Vijay Bellur 

BUG: 1619 (glusterfs nfs server crashed on dht+replica(2x2))
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1619

performance/write-behind: dump contents of wb-file

2010-09-16T13:38:38+00:00

Signed-off-by: Raghavendra G 
Signed-off-by: Vijay Bellur 

BUG: 1059 (enhancements for getting statistics from performance translators)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1059

performance/stat-prefetch: while removing an entry from cache, remove it from caches stored in all opened fds.

2010-08-28T11:47:37+00:00

Signed-off-by: Raghavendra G 
Signed-off-by: Vijay Bellur 

BUG: 1414 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1414

Fix memory corruption in mem pool

2010-08-18T13:55:46+00:00

Added new interface mem_get0, which calls memset on the
mem pool entries being returned.
Gluster and Kernel compile should now succeed.

Signed-off-by: shishir gowda 
Signed-off-by: Anand V. Avati 

BUG: 1393 (Gluster and kernel compile fails)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1393

fuse resolve related changes

2010-08-12T05:24:38+00:00

Now fuse is fully complaint with DVM, as even if there is a fop
request on inode belonging to old graph, it will be resolved
corresponding to new graph and operations will be performed wrt.
new graph, which makes DVM truely spontaneous.

Signed-off-by: Amar Tumballi 
Signed-off-by: Anand V. Avati 

BUG: 1240 (DVM: after graph change, inodes should resolve to new inode-table)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1240