glusterfs.git/libglusterfs/src/common-utils.c, branch v3.3.0qa35

glusterd: IPv4 auth improvment

2012-04-13T08:02:07+00:00

Check if last character of an IPv4 address is valid to prevent successful
validation of addresses with '.' as last character.

Change-Id: I0af6c288e12a47986ce3f8b02c317b99767e69e6
BUG: 811458
Signed-off-by: Kaushal M 
Reviewed-on: http://review.gluster.com/3124
Tested-by: Gluster Build System 
Reviewed-by: Jeff Darcy 
Reviewed-by: Vijay Bellur

Replace GPLV3 MD5 with OpenSSL MD5

2012-04-04T23:13:21+00:00

Ric asked me to look at replacing the GPL licensed MD5 code with
something better, i.e. perhaps faster, and with a less restrictive
license, etc. So I took a couple hour holiday from working on
wrapping up the client_t and did this.

OpenSSL (nee SSLeay) is released under the OpenSSL license, a BSD/MIT
style license. OpenSSL (libcrypto.so) is used on Linux, OS X and *BSD,
Open Solaris, etc. IOW it's universally available on the platforms we
care about. It's written by Eric Young (eay), now at EMC/RSA, and I
can say from experience that the OpenSSL implementation of MD5 (at least)
is every bit as fast as RSA's proprietary implementation (primarily
because the implementations are very, very similar.) The last time I
surveyed MD5 implementations I found they're all pretty much the same
speed.

I changed the APIs (and ABIs) for the strong and weak checksums.
Strictly speaking I didn't need to do that. They're only called on
short strings of data, i.e. pathnames, so using int32_t and uint32_t
is ostensibly okay. My change is arguably a better, more general API
for this sort of thing. It's also what bit me when gerrit/jenkins
validation failed due to glusterfs segv-ing. (I didn't pay close enough
attention to the implementation of the weak checksum. But it forced me
to learn what gerrit/jenkins are doing and going forward I can do better
testing before submitting to gerrit.)

Now resubmitting with a BZ

Change-Id: I545fade1604e74fc68399894550229bd57a5e0df
BUG: 807718
Signed-off-by: Kaleb KEITHLEY 
Reviewed-on: http://review.gluster.com/3019
Tested-by: Gluster Build System 
Reviewed-by: Jeff Darcy

mgmt/glusterd : volume set validation fixes

2012-03-18T07:52:40+00:00

This is the new version of the patch by Kaushik at review.gluster.com/699

The following new option types have been introduced:
 * GF_OPTION_TYPE_INTERNET_ADDRESS_LIST
 * GF_OPTION_TYPE_PRIORITY_LIST
 * GF_OPTION_TYPE_SIZE_LIST
and option types of several options in translators have been updated to use the
new types.

valid_internet_address(), valid_ipv4_address() & valid_ipv6_address() functions
has been updated for * wildcard matching. Previously used standalone wildcard
address checking functions have been removed.

Changes have been done to stripe translator to correctly set, update and use
stripe-blocksize. Also minimum value for block-size has been set to 16KB.

Change-Id: I2aa484ff695f6a915a8fc9a9f965cf0344f41d59
BUG: 765248
Signed-off-by: Kaushal M 
Reviewed-on: http://review.gluster.com/2899
Tested-by: Gluster Build System 
Reviewed-by: Shishir Gowda 
Reviewed-by: Anand Avati

libglusterfs/options: Cleanup xlator percent_sizet code.

2012-02-22T06:23:09+00:00

Change-Id: I1a39252d6c26f7e30b77ef682b8b3cdcde8a4a51
BUG: 769691
Signed-off-by: Harshavardhana 
Reviewed-on: http://review.gluster.com/2619
Tested-by: Gluster Build System 
Reviewed-by: Amar Tumballi

cli, protocol/server : improve validation for the option auth.(allow/reject)

2012-02-06T06:19:54+00:00

cli now checks validity of address list given for 'volume set auth.*'

Server xlator checks addresses supplied to auth.(allow/reject) option
including wildcards for correctness in case volfile is manually edited.

Original patch done by shylesh@gluster.com
Original patch  is at http://patches.gluster.com/patch/7566/

Change-Id: Icf52d6eeef64d6632b15aa90a379fadacdf74fef
BUG: 764197
Signed-off-by: Kaushal M 
Reviewed-on: http://review.gluster.com/306
Tested-by: Gluster Build System 
Reviewed-by: Jeff Darcy 
Reviewed-by: Vijay Bellur

common-utils: Add support for solaris, bsd and mac os/x

2012-01-26T10:32:08+00:00

get_mem_size() is more standardized now.

Change-Id: I8e3dc29df0a64a5eb8eea4fd3965b268cb1a85c2
BUG: 772808
Signed-off-by: Harshavardhana 
Reviewed-on: http://review.gluster.com/2618
Tested-by: Gluster Build System 
Reviewed-by: Kaleb KEITHLEY 
Reviewed-by: Vijay Bellur

core: change lk-owner as a 1k buffer

2012-01-25T04:14:17+00:00

so, NLM can send the lk-owner field directly to the locks translators,
while doing the same effort, also enabled sending maximum of 500 aux gid
over protocol.

Change-Id: I87c2514392748416f7ffe21d5154faad2e413969
Signed-off-by: Amar Tumballi 
BUG: 767229
Reviewed-on: http://review.gluster.com/779
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

common-utils: Cleanup old stuff and standardize

2012-01-13T05:40:36+00:00

Change-Id: If15058c3a1cc4070d1ebbabe37e012a70353310e
BUG: 769691
Signed-off-by: Harshavardhana 
Reviewed-on: http://review.gluster.com/2635
Tested-by: Gluster Build System 
Reviewed-by: Amar Tumballi 
Reviewed-by: Vijay Bellur

cli: volume status enhancement

2012-01-12T09:58:26+00:00

    * Support "gluster volume status (all)" option to display all
      volumes' status.

    * On option "detail" appended to "gluster volume status *",
      amount of storage free, total storage, and backend filesystem
      details like inode size, inode count, free inodes, fs type,
      device name of each brick is displayed.

    * One can also obtain [detailed]status of only one brick.

    * Format of the enhanced volume status command is:
      "gluster volume status [all|] [] [detail]"

    * Some generic functions have been added to common-utils:

           skipword
           get_nth_word
      These functions enable parsing and fetching
      of words in a sentence.

           glusterd_get_brick_root    (in glusterd)
      These are self explanatory.

Change-Id: I6f40c1e19810f8504cd3b1786207364053d82e28
BUG: 765464
Signed-off-by: Rajesh Amaravathi 
Reviewed-on: http://review.gluster.com/777
Tested-by: Gluster Build System 
Reviewed-by: Amar Tumballi

lib/mount-broker: move utility functions to common-utils

2012-01-05T16:51:22+00:00

functions skipwhite and nwstrtail have been moved from
mount-broker to common-utils library for general use.

Change-Id: I9cfefb28bbfcf5d0bd37e35865ff3f3b7923fc53
BUG: 765464
Signed-off-by: Rajesh Amaravathi 
Reviewed-on: http://review.gluster.com/2560
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur 
Reviewed-by: Csaba Henk