glusterfs.git/geo-replication/src, branch v6.7

geo-rep : fix mountbroker setup

2019-09-27T11:32:48+00:00

Problem:

Unable to setup mountbroker root directory while creating geo-replication
session for non-root user.

Casue:
With patch[1] which defines the max-port for glusterd one extra sapce
got added in field of 'option max-port'.
[1]. https://review.gluster.org/#/c/glusterfs/+/21872/

In geo-rep spliting of key-value pair form vol file was done on the
basis of space so this additional space caused "ValueError: too many values
to unpack".

Solution:
Use split so that it can treat consecutive whitespace as a single separator.

Backport of https://review.gluster.org/#/c/glusterfs/+/22716/

>Fixes: bz#1709248
>Change-Id: Ia22070a43f95d66d84cb35487f23f9ee58b68c73
>Signed-off-by: Sunny Kumar 
>(cherry picked from commit 3dd03146bb7037ae2ebea0579d0b81be27fdd927)

Fixes: bz#1750228
Signed-off-by: Sunny Kumar 
Change-Id: Ia22070a43f95d66d84cb35487f23f9ee58b68c73

geo-rep: Fix mount broker setup issue

2019-08-07T04:51:13+00:00

Even the use builtin 'type' command as in patch [1]
causes issues if argument in question is not part of PATH
environment variable for that user. This patch fixes the
same by doing source /etc/profile. This was already being
used in another part of script.

[1] https://review.gluster.org/23089


Backport of:
 > Patch: https://review.gluster.org/23136/
 > Change-Id: Iceb78835967ec6a4350983eec9af28398410c002
 > BUG: 1734738
 > Signed-off-by: Kotresh HR 
(cherry picked from commit 84f7794547522463841068063b22fd3a8d8fca2b)

Change-Id: Iceb78835967ec6a4350983eec9af28398410c002
fixes: bz#1737712
Signed-off-by: Kotresh HR

geo-rep: Fix mount broker setup issue

2019-08-05T11:31:20+00:00

The patch [1] added validation in gverify.sh to check if the gluster
binary exists on slave by executing gluster directly on slave.  But for
non-root users, even though gluster binary is present, path is not
found when executed via ssh. Hence validate the gluster binary using
bash builtin 'type' command.

[1] https://review.gluster.org/19224

Backport of:
 > Patch: https://review.gluster.org/23089/
 > Change-Id: I93ca62c0c5b1e16263e586ddbbca8407d60ca126
 > BUG: 1731920
 > Signed-off-by: Kotresh HR 
(cherry picked from commit 2aa731a259ea457c07494e3c3edf6d5f7c02fe77)

Change-Id: I93ca62c0c5b1e16263e586ddbbca8407d60ca126
fixes: bz#1733880
Signed-off-by: Kotresh HR

geo-rep: IPv6 support

2019-04-17T13:58:46+00:00

`address_family=inet6` needs to be added while mounting master and
slave volumes in gverify script.

New option introduced to gluster cli(`--inet6`) which will be used
internally by geo-rep while calling `gluster volume info
--remote-host=`.

Backport of https://review.gluster.org/22363

Fixes: bz#1695436
Change-Id: I1e0d42cae07158df043e64a2f991882d8c897837
Signed-off-by: Aravinda VK 
(cherry picked from commit 240e1d6821fbb779c3dd73f6f0225d755a5b7cc6)

geo-rep: Make slave volume read-only (by default)

2018-12-07T09:37:54+00:00

Added a command to set "features.read-only" option
to a default value "on" for slave volume.
Changes are made in:
$SRC//extras/hook-scripts/S56glusterd-geo-rep-create-post.sh
for root geo-rep and
$SRC/geo-replication/src/set_geo_rep_pem_keys.sh
for non-root geo-rep.

Fixes: bz#1654187

Change-Id: I15beeae3506f3f6b1dcba0a5c50b6344fd468c7c
Signed-off-by: Harpreet Kaur

libglusterfs: Move devel headers under glusterfs directory

2018-12-05T21:47:04+00:00

libglusterfs devel package headers are referenced in code using
include semantics for a program, this while it works can be better
especially when dealing with out of tree xlator builds or in
general out of tree devel package usage.

Towards this, the following changes are done,
- moved all devel headers under a glusterfs directory
- Included these headers using system header notation <> in all
code outside of libglusterfs
- Included these headers using own program notation "" within
libglusterfs

This change although big, is just moving around the headers and
making it correct when including these headers from other sources.

This helps us correctly include libglusterfs includes without
namespace conflicts.

Change-Id: Id2a98854e671a7ee5d73be44da5ba1a74252423b
Updates: bz#1193929
Signed-off-by: ShyamsundarR

geo-rep: Fix permissions with non-root setup

2018-11-26T04:20:57+00:00

Problem:
In non-root fail-over/fail-back(FO/FB), when slave is
promoted as master, the session goes to 'Faulty'

Cause:
The command 'gluster-mountbroker  '
is run as a pre-requisite on slave in non-root setup.
It modifies the permission and group of following required
directories and files recursively

  [1] /var/lib/glusterd/geo-replication
  [2] /var/log/glusterfs/geo-replication-slaves

In a normal setup, this is executed on slave node and hence
doing it recursively is not an issue on [1]. But when original
master becomes slave in non-root during FO/FB, it contains
ssh public keys and modifying permissions on them causes
geo-rep to fail with incorrect permissions.

Fix:
Don't do permission change recursively. Fix permissions for
required files.

fixes: bz#1651498
Change-Id: I68a744644842e3b00abc26c95c06f123aa78361d
Signed-off-by: Kotresh HR

geo-rep/scripts: Fix traceback in gluster-mountbroker

2018-10-30T13:13:08+00:00

When 'gluster-mountbroker status' was issued, it
crashes in a corner case with 'str object has not
attribute get'. Fixed the same.

fixes: bz#1643929
Signed-off-by: Kotresh HR 
Change-Id: Iaf1a937ed0136b3b2058230c75fa89a215d8a5eb

geo-rep : fix high sev coverity isuue

2018-10-25T05:34:27+00:00

This patch fixes CID: 1382374: USE_AFTER_FREE.

Change-Id: If408f52ee291312fb83095126ebd6bb79ae95e26
updates: bz#789278
Signed-off-by: Sunny Kumar

Land part 2 of clang-format changes

2018-09-12T12:22:45+00:00

Change-Id: Ia84cc24c8924e6d22d02ac15f611c10e26db99b4
Signed-off-by: Nigel Babu