glusterfs.git/geo-replication/src/gsyncd.c, branch v3.12.5

geo-rep: address potential leak of memory

2016-07-19T11:25:35+00:00

fix memory leak reported by clang analyzer:
gsyncd.c:411:17: warning: Potential leak of 
                 memory pointed to by 'argv'
                 in main()


Change-Id: I179fb1c095cf4d331b5910df6388dc724cb4ac96
BUG: 1332419
Signed-off-by: Prasanna Kumar Kalever 
Reviewed-on: http://review.gluster.org/14151
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Smoke: Gluster Build System 
Reviewed-by: Kotresh HR

core: use syscall wrappers instead of direct syscalls - miscellaneous

2015-10-28T20:38:42+00:00

various xlators and other components are invoking system calls
directly instead of using the libglusterfs/syscall.[ch] wrappers.

If not using the system call wrappers there should be a comment
in the source explaining why the wrapper isn't used.

Change-Id: I1f47820534c890a00b452fa61f7438eb2b3f667c
BUG: 1267967
Signed-off-by: Kaleb S. KEITHLEY 
Reviewed-on: http://review.gluster.org/12276
Tested-by: Gluster Build System 
Reviewed-by: Jeff Darcy

geo-rep: Fix gsyncd failing to start on slave

2015-08-06T05:40:22+00:00

This is a regression introduced by 2ca6441.
The memory is freed while the caller expects
it be not. The patch fixes the same.

Change-Id: I76d95eef15b3f7af365b392f2426c8b0388254fc
BUG: 1222898
Signed-off-by: Kotresh HR 
Reviewed-on: http://review.gluster.org/11751
Reviewed-by: Saravanakumar Arumugam 
Tested-by: Gluster Build System 
Tested-by: NetBSD Build System 
Reviewed-by: Milind Changire 
Reviewed-by: Venky Shankar

geo-replication: fix memory leak in gsyncd

2015-07-14T13:12:06+00:00

1. leak in str2argv() function:

char *strdup(const char *s);
The strdup() function returns a pointer to a new string which is a
duplicate of the  string  s. Memory for the new string is obtained
with malloc(3), and can be freed with free(3).

so when using strdup, user has to take care of freeing the memory
allocated by strdup library function.

2. leak in main() function:

str2argv() function calls calloc and allocates memory pointed to argv,
after return from str2argv() memory pointed to argv has to be cleaned
in main().

This patch is to fix 2 memory leaks mentioned above.

Change-Id: I6bf26101e0460a7324ac7bdb69905839688d4987
BUG: 1222898
Signed-off-by: Prasanna Kumar Kalever 
Reviewed-on: http://review.gluster.org/10831
Tested-by: NetBSD Build System 
Reviewed-by: Milind Changire 
Reviewed-by: Kotresh HR 
Reviewed-by: Venky Shankar

build: do not #include "config.h" in each file

2015-05-29T12:43:17+00:00

Instead of including config.h in each file, and have the additional
config.h included from the compiler commandline (-include option).

When a .c file tests for a certain #define, and config.h was not
included, incorrect assumtions were made. With this change, it can not
happen again.

BUG: 1222319
Change-Id: I4f9097b8740b81ecfe8b218d52ca50361f74cb64
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/10808
Tested-by: Gluster Build System 
Tested-by: NetBSD Build System
Reviewed-by: Kaleb KEITHLEY 
Reviewed-by: Pranith Kumar Karampuri

geo-rep: Fixing the typo errors

2015-02-03T18:03:41+00:00

Change-Id: Iacc67e4ba9ac45e0858f3befe84ffb8fccf7e1c3
BUG: 1075417
Signed-off-by: arao 
Reviewed-on: http://review.gluster.org/9502
Tested-by: Gluster Build System 
Reviewed-by: Humble Devassy Chirammal

gsyncd : Use --remote-host option during cli invocation

2014-05-26T02:52:24+00:00

Required for unprivileged geo-replication sessions to
execute glusterd commands (which are however restricted).

Change-Id: Ib83b81defa061717f4465ffa665450d0f5d3d20d
BUG: 1077452
Signed-off-by: Venky Shankar 
Reviewed-on: http://review.gluster.org/7833
Reviewed-by: Kotresh HR 
Tested-by: Gluster Build System

gsyncd / geo-rep: Initialize default memory accounting

2014-05-07T06:45:12+00:00

commit 7fba3a8 enables memory accounting by default. Since
geo-replication binary (gsyncd) does not declare a memory
accounting function, call like GF_{CALLOC,MALLOC} result
int asserts.

This patch initializes default memory accounting.

Change-Id: I9ad1de8bca6745a9899a006a863a7cfeef73d52f
BUG: 1094708
Signed-off-by: Venky Shankar 
Reviewed-on: http://review.gluster.org/7683
Reviewed-by: Kotresh HR 
Reviewed-by: Vijay Bellur

glusterd/cli changes for distributed geo-rep

2013-07-26T20:19:18+00:00

Commands:
gluster system:: execute gsec_create
gluster volume geo-rep   create [push-pem] [force]
gluster volume geo-rep   start [force]
gluster volume geo-rep   stop [force]
gluster volume geo-rep   delete
gluster volume geo-rep   config
gluster volume geo-rep   status

The geo-replication is distributed. The session will be created, and
gsyncd will be spawned on all relevant nodes, instead of only one
node.

geo-rep: Collecting status detail related data

Added persistent store for saving information about
TotalFilesSynced, TotalSyncTime, TotalBytesSynced

Changes in the status information in socket:
Existing(Ex):
FilesSynced=2;BytesSynced=2507;Uptime=00:26:01;

New(Ex):
FilesSynced=2;BytesSynced=2507;Uptime=00:26:01;SyncTime=0.69978;
TotalSyncTime=2.890044;TotalFilesSynced=6;TotalBytesSynced=143640;

Persistent details stored in
/var/lib/glusterd/geo-replication/${mastervol}/${eSlave}-detail.status

Change-Id: I1db7fc13ffca2e415c05200b0109b1254067f111
BUG: 847839
Original Author: Avra Sengupta 
Original Author: Venky Shankar 
Original Author: Aravinda VK 
Original Author: Amar Tumballi 
Original Author: Csaba Henk 
Signed-off-by: Avra Sengupta 
Reviewed-on: http://review.gluster.org/5132
Reviewed-by: Vijay Bellur 
Tested-by: Vijay Bellur

gsyncd: distribute the crawling load

2013-07-26T20:18:57+00:00

* also consume changelog for change detection.
* Status fixes
* Use new libgfchangelog done API
* process (and sync) one changelog at a time

Change-Id: I24891615bb762e0741b1819ddfdef8802326cb16
BUG: 847839
Original Author: Csaba Henk 
Original Author: Aravinda VK 
Original Author: Venky Shankar 
Original Author: Amar Tumballi 
Original Author: Avra Sengupta 
Signed-off-by: Avra Sengupta 
Reviewed-on: http://review.gluster.org/5131
Reviewed-by: Vijay Bellur 
Tested-by: Vijay Bellur