glusterfs.git/extras, branch v3.10.4

common-ha: surviving ganesha.nfsd not put in grace on fail-over

2017-06-14T11:46:35+00:00

Behavior change is seen in new HA in RHEL 7.4 Beta. Up to now clone
RAs have been created with "pcs resource create ... meta notify=true".
Their notify method is invoked with pre-start or post-stop when one of
the clone RAs is started or stopped.

In 7.4 Beta the notify method we observe that the notify method is not
invoked when one of the clones is stopped (or started).

Ken Gaillot, one of the pacemaker devs, wrote:
  With the above command, pcs puts the notify=true meta-attribute
  on the primitive instead of the clone. Looking at the pcs help,
  that seems expected (--clone notify=true would put it on the clone,
  meta notify=true puts it on the primitive). If you drop the "meta"
  above, I think it will work again.

And indeed his suggested fix does work on both RHEL 7.4 Beta and RHEL
7.3 and presumably Fedora.

Change-Id: Idbb539f1366df6d39f77431c357dff4e53a2df6d
BUG: 1461019
Signed-off-by: Kaleb S. KEITHLEY 
Reviewed-on: https://review.gluster.org/17534
Smoke: Gluster Build System 
Reviewed-by: soumya k 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System

common-ha: adding a node to existing cluster failed to start pacemaker

2017-05-17T09:33:56+00:00

`pcs cluster start` in add_node() needs to wait for SSL certs to
propagate, etc. -- just like setup.

Change-Id: I44876305630a82e471824c085ed9ac58df08caa2
BUG: 1450053
Signed-off-by: Kaleb S. KEITHLEY 
Reviewed-on: https://review.gluster.org/17255
Reviewed-by: soumya k 
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: jiffin tony Thottan

ganesha : minor improvments for commit e91cdf4 (17081)

2017-05-03T22:35:56+00:00

Change-Id: I3af13e081c5e46cc6f2c132e7a5106ac3355c850
BUG: 1443490
Signed-off-by: Jiffin Tony Thottan 
Reviewed-on: https://review.gluster.org/17152
Smoke: Gluster Build System 
Reviewed-by: soumya k 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Kaleb KEITHLEY

ganesha/scripts : remove dependency over export configuration file for unexport

2017-05-01T21:44:23+00:00

Currently unexport is performed by reading export id from volume configuration
file. So unexport has dependency over that file. This patch will unexport with
help of dbus command ShowExport. And it will only unexport the share which is
added via cli.

Change-Id: I6f3c9b2bb48f0328b18e9cc0e4b9356174afd596
BUG: 1427079
Signed-off-by: Jiffin Tony Thottan 
Reviewed-on: https://review.gluster.org/16771
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Kaleb KEITHLEY 
Reviewed-by: Raghavendra Talur

ganesha : allow refresh-config and volume export/unexport in failover state

2017-04-24T10:33:51+00:00

If ganesha is not running on one of nodes in HA cluster, then alli dbus
commands send to that ganesha server will fail. This results in both
refresh-config and volume export/unepxort failure. This change will
gracefully handle those scenarios.

Change-Id: I3f1b7b7ca98e54c273c266e56357d8e24dd1b14b
BUG: 1443490
Signed-off-by: Jiffin Tony Thottan 
Reviewed-on: https://review.gluster.org/17081
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: soumya k 
Reviewed-by: Kaleb KEITHLEY

common-ha: Use UpdateExports dbus msg for refresh-config

2017-04-24T10:33:28+00:00

In nfs-ganesha 2.4, new dbs msg type "UpdateExports" support
has been added. With this support, the exports can be re-configured
dynamically without the need to re-export the entries.

Note : This change was of part of 3.10 branching, but the commit 142ee0c
overwrites this patch. Hence resubmitting this change
Upstream reference :
>Change-Id: Iee7330d33e91db1126974a2ff46becb3764f2e5e
>BUG: 1382258
>Author:    Soumya Koduri 
>Reviewed-on: http://review.gluster.org/15617
>Smoke: Gluster Build System 
>CentOS-regression: Gluster Build System 
>NetBSD-regression: NetBSD Build System 
>Reviewed-by: Kaleb KEITHLEY 

Change-Id: Iee7330d33e91db1126974a2ff46becb3764f2e5e
BUG: 1443478
Author:    Soumya Koduri 
Signed-off-by: Jiffin Tony Thottan 
Reviewed-on: https://review.gluster.org/17080
Smoke: Gluster Build System 
Reviewed-by: soumya k 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System

ganesha/scripts : Stop ganesha process on all nodes if cluster setup fails

2017-04-24T10:32:39+00:00

During staging phase of volume option "nfs-ganesha", symlink "ganesha.conf"
will be created plus ganesha process will be started. The cluster setup
happens during commit phase of that option. So if cluster set up fails, the
ganesha process will be running on all cluster nodes.

Change-Id: Ib2cb85364b7ef5b702acb4826ffdf8e6f31a2acd
BUG: 1426156
Signed-off-by: Jiffin Tony Thottan 
Reviewed-on: https://review.gluster.org/16823
Smoke: Gluster Build System 
Tested-by: Kaleb KEITHLEY 
Reviewed-by: soumya k 
Reviewed-by: Kaleb KEITHLEY 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System

ganesha/scripts : Remove export entries from ganesha.conf during cleanup

2017-04-24T10:30:54+00:00

Change-Id: I288f7c9ced23d258a7ce1242d8efe03a4bf6f746
BUG: 1425726
Signed-off-by: Jiffin Tony Thottan 
Reviewed-on: https://review.gluster.org/16708
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: soumya k 
Reviewed-by: Kaleb KEITHLEY

common-ha: fixes for Debian-based systems

2017-04-13T15:37:57+00:00

1) Debian-based systems don't have /usr/libexec/... and there is
a hard-coded invocation of /usr/libexec/ganesha/ganesha-ha.sh within
ganesha-ha.sh itself.
Fix: save $0 and use it instead for further invocations of self.

2) default shell is /bin/dash (not /bin/bash). Various runner_run()
invocations for ganesha used what amounts to
  exec("sh /usr/$libexec/ganesha/ganesha-ha.sh ...);
which executes the script using the default shell, but there are
some bash-specific idioms that don't work if the shell is dash.
Fix: change to exec("/usr/$libexec/ganesha/ganesha-ha.sh ...); so that
the shebang forces the use of /bin/bash

3) Fedora and RHEL7 have merged /bin/ and /usr/bin, /bin is a symlink
to /usr/bin. Debian-based systems are not merged, and systemd systems
have /bin/systemctl. The logic to find .../bin/systemctl is backwards.
If the logic looks for /usr/bin/systemctl it will not find it on
Debian-based systems; if it looks for /bin/systemctl it will find it
on Fedora and RHEL by virtue of the symlink. (RHEL6 and others will
find their respective init regardless.)
Fix: change the logic to look for /bin/systemctl instead.

4) The logic for deciding to run systemctl (or not) is a bit silly.
Fix: simply invoke the found method via the function pointer in the
table.

Change-Id: I33681b296a73aebb078bda6ac0d3a1d3b9770a21
BUG: 1440148
Signed-off-by: Kaleb S. KEITHLEY 
Reviewed-on: https://review.gluster.org/17013
Smoke: Gluster Build System 
Reviewed-by: Niels de Vos 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: jiffin tony Thottan

build/packaging: Debian and Ubuntu don't have /usr/libexec

2017-03-13T14:19:00+00:00

GLUSTERFS_LIBEXECDIR is effectively hard-coded to /usr/libexec/glusterfs
in configure(.ac)

Debian-based distributions don't have a /usr/libexec/ directory

This issues is partially mitigated by the use of $libexecdir in
some of the Makefile.am files, but even so the incorrectly defined
GLUSTERFS_LIBEXECDIR results in various things such as gsyncd,
glusterfind, eventsd, etc., trying to invoke other scripts and
programs from a location that doesn't exist.

And once we correctly define GLUSTERFS_LIBEXECDIR, then we might as
well use it appropriatedly.

master change https://review.gluster.org/16880
master BZ: 1430841

Change-Id: If5219cadc51ae316f7ba2e2831d739235c77902d
BUG: 1430844
Signed-off-by: Kaleb S. KEITHLEY 
Reviewed-on: https://review.gluster.org/16881
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Milind Changire 
Reviewed-by: Shyamsundar Ranganathan