glusterfs.git/cli, branch v3.7.4

cli: on error invoke cli_cmd_broadcast_response function in separate thread

2015-08-31T15:04:08+00:00

This is a backport of http://review.gluster.org/#/c/11990/

There is a problem in current CLI framework
CLI holds the lock when processing command.
When processing quota list command, below sequence of steps executed in the
same thread and causing deadlock

1) CLI holds the lock
2) Send rpc_clnt_submit request to quotad for quota usage
3) If quotad is down, rpc_clnt_submit invokes cbk function with error
4) cbk function cli_quotad_getlimit_cbk tries to hold lock to broadcast
   the results and hangs, because same thread has already holding the lock

This patch fixes the problem by creating seperate thread for
broadcasting the result

> Change-Id: I53be006eadf6aaf348083d9168535530d70a8ab3
> BUG: 1242819
> Signed-off-by: vmallika 

Change-Id: Ic3c651c143e4143cfb4542d99b4856e582022e36
BUG: 1257881
Signed-off-by: vmallika 
Reviewed-on: http://review.gluster.org/12038
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System 
Reviewed-by: Kaushal M

quota :display the size of soft limit percentage

2015-08-26T12:09:47+00:00

Display the size equivalent to the soft limit percentage
in gluster v quota  list  and
gluster v quota  list-objects  command

        Backport of http://review.gluster.org/#/c/11808/

Cherry picked from commit b9e87f39386fc9c591c7698357c2899afc255b95
> Change-Id: I31ee82e9e836068348cf9458dcaf13f043d9fd87
> BUG: 1248521
> Signed-off-by: Manikandan Selvaganesh 
> Reviewed-on: http://review.gluster.org/11808
> Tested-by: NetBSD Build System 
> Reviewed-by: Vijaikumar Mallikarjuna 
> Reviewed-by: Raghavendra G 

Change-Id: I31ee82e9e836068348cf9458dcaf13f043d9fd87
BUG: 1255644
Signed-off-by: Manikandan Selvaganesh 
Reviewed-on: http://review.gluster.org/11977
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System 
Reviewed-by: Raghavendra G

xml output: Fix non-uniform opErrstr xml output

2015-08-18T07:00:16+00:00

    Backport of http://review.gluster.org/#/c/11835/

Display  in case of no operrstr for
all xml output of gluster commands.

Change-Id: Ie16f749f90b4642357c562012408c434cd38661f
BUG: 1253607
Signed-off-by: Avra Sengupta 
Reviewed-on: http://review.gluster.org/11920
Tested-by: NetBSD Build System 
Reviewed-by: Rajesh Joseph

rpc: add owner xlator argument to rpc_clnt_new

2015-08-14T10:10:47+00:00

The @owner argument tells RPC layer the xlator that owns
the connection and to which xlator THIS needs be set during
network notifications like CONNECT and DISCONNECT.

Code paths that originate from the head of a (volume) graph and use
STACK_WIND ensure that the RPC local endpoint has the right xlator saved
in the frame of the call (callback pair). This guarantees that the
callback is executed in the right xlator context.

The client handshake process which includes fetching of brick ports from
glusterd, setting lk-version on the brick for the session, don't have
the correct xlator set in their frames. The problem lies with RPC
notifications. It doesn't have the provision to set THIS with the xlator
that is registered with the corresponding RPC programs. e.g,
RPC_CLNT_CONNECT event received by protocol/client doesn't have THIS set
to its xlator. This implies, call(-callbacks) originating from this
thread don't have the right xlator set too.

The fix would be to save the xlator registered with the RPC connection
during rpc_clnt_new. e.g, protocol/client's xlator would be saved with
the RPC connection that it 'owns'. RPC notifications such as CONNECT,
DISCONNECT, etc inherit THIS from the RPC connection's xlator.

Change-Id: I9dea2c35378c511d800ef58f7fa2ea5552f2c409
BUG: 1253212
Signed-off-by: Krishnan Parthasarathi 
Reviewed-on: http://review.gluster.org/11436
Tested-by: Gluster Build System 
Tested-by: NetBSD Build System 
Reviewed-by: Raghavendra G 
(cherry picked from commit f7668938cd7745d024f3d2884e04cd744d0a69ab)
Reviewed-on: http://review.gluster.org/11908
Reviewed-by: Pranith Kumar Karampuri

quota : checking for absolute path in quota command

2015-08-13T05:29:35+00:00

Currently, if absolute path is not entered in
"gluster volume quota  list ",
it just shows the header (Path Hard-limit Soft-limit...)
instead of showing an error message.

With this patch, it shows an error to enter the absolute path.

        Backport of http://review.gluster.org/#/c/11738/

Cherry picked from commit 06c3cf61249e05ae1212a43d5fc1db57bad5f718
> Change-Id: I2c3d34bfdc7b924d00b11f8649b73a5069cbc2dc
> BUG: 1245558
> Signed-off-by: Manikandan Selvaganesh 
> Reviewed-on: http://review.gluster.org/11738
> Tested-by: NetBSD Build System 
> Tested-by: Gluster Build System 
> Reviewed-by: Vijaikumar Mallikarjuna 
> Reviewed-by: Raghavendra G 

Change-Id: I2c3d34bfdc7b924d00b11f8649b73a5069cbc2dc
BUG: 1252873
Signed-off-by: Manikandan Selvaganesh 
Reviewed-on: http://review.gluster.org/11899
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System 
Reviewed-by: Raghavendra G

quota :validating soft limit percentage

2015-08-12T10:49:21+00:00

        Backport of http://review.gluster.org/#/c/11566/

Cherry-picked from commit bc6110fa37f1d6214d2e8cce367e0b7abd6976c3
> Change-Id: I14c049c84c468b6415a1de45441b2fed94e8ed4b
> BUG: 1240654
> Signed-off-by: Manikandan Selvaganesh 
> Reviewed-on: http://review.gluster.org/11566
> Tested-by: NetBSD Build System 
> Tested-by: Gluster Build System 
> Reviewed-by: Vijaikumar Mallikarjuna 
> Reviewed-by: Raghavendra G 

Change-Id: I14c049c84c468b6415a1de45441b2fed94e8ed4b
BUG: 1244724
Signed-off-by: Manikandan Selvaganesh 
Reviewed-on: http://review.gluster.org/11723
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System 
Reviewed-by: Raghavendra G

cli : changing the gluster peer probe message

2015-08-06T06:31:10+00:00

The gluster peer probe command with invalid ips dont report that
IP's can also be a valid in usage.

	Backport of http://review.gluster.org/11657

Cherry picked from 746f23ce055f7beed20aa4038f61ad5bdd84419f
>Change-Id: I8f58341a2b76369ccf62f88ca0ecd8a9a9529af6
>BUG: 1242742
>Signed-off-by: Mohamed Ashiq Liyazudeen 
>Reviewed-on: http://review.gluster.org/11657
>Reviewed-by: Atin Mukherjee 
>Tested-by: Gluster Build System 
>Reviewed-by: Humble Devassy Chirammal 
>Tested-by: NetBSD Build System 

Change-Id: I8f58341a2b76369ccf62f88ca0ecd8a9a9529af6
BUG: 1247910
Signed-off-by: Mohamed Ashiq Liyazudeen 
Reviewed-on: http://review.gluster.org/11786
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System 
Reviewed-by: Atin Mukherjee

cli: Create missing logbuf_pool

2015-07-24T11:19:30+00:00

        Backport of http://review.gluster.org/#/c/11691/

Since logbuf_pool was not created via glusterfs_ctx_defaults_init(),
the following error was present in cli logs repeateadly for each
and every execution of a gluster command.

E [mem-pool.c:417:mem_get0] (-->/usr/local/lib/libglusterfs.so.0(+0x7e262)
[0x7fdbc0b1f262] -->/usr/local/lib/libglusterfs.so.0(_gf_msg+0x804)
[0x7fdbc0ac7844] -->/usr/local/lib/libglusterfs.so.0(mem_get0+0x78)
[0x7fdbc0af5b48] ) 0-mem-pool: invalid argument [Invalid argument]

This change creates ctx->logbuf_pool via glusterfs_ctx_defaults_init()
in cli.c so that the above error is no longer logged in cli logs.

Change-Id: I3fcd9cfefa06ddd52e1989b039ff5637372c3235
BUG: 1244103
Signed-off-by: Anoop C S 
Reviewed-on: http://review.gluster.org/11705
Reviewed-by: Jeff Darcy 
Tested-by: Gluster Build System 
Tested-by: NetBSD Build System 
Reviewed-by: Atin Mukherjee

quota/marker: fix spurious failure afr-quota-xattr-mdata-heal.t

2015-07-13T06:53:27+00:00

This is a backport of http://review.gluster.org/#/c/11583

During quota-update process if inode info is present in size-xattr and
missing in contri-xattrs, then in function '_mq_get_metadata', we set
contri-size as zero (on error -2, which means usage info present, but
inode info missing).
With this we are calculating wrong delta and updating the same.

With this patch we are ignoring errors if inode info in xattrs are
missing

> Change-Id: I7940a0e299b8bb425b5b43746b1f13f775c7fb92
> BUG: 1241153
> Signed-off-by: vmallika 

Change-Id: Ie85fa84b5362ae179cc43402bd6a3a6d96a04b81
BUG: 1241831
Signed-off-by: vmallika 
Reviewed-on: http://review.gluster.org/11614
Tested-by: Gluster Build System 
Tested-by: NetBSD Build System 
Reviewed-by: Krishnan Parthasarathi

common-ha : Fixing add node operation

2015-06-22T09:37:11+00:00

Resource create for the added node referenced a variable
new_node that was never passed. This led to a wrong schema
type in the cib file and hence the added node always ended
up in failed state. And also, resources were wrongly
created twice and led to more errors. I have fixed the variable
name and deleted the repetitive invocation of the recreate-resource
function.

The new node has to be added to the existing ganesha-ha config
file for correct behaviour during subsequent add-node operations.
This edited file has to be copied to all the other cluster nodes.
I have added a fix for this as well.

This is a backport of the fix that is merged on master,
http://review.gluster.org/#/c/11316/5

Change-Id: I21e3fcffe8274986be53766e12a2c049eaa2da09
BUG: 1234216
Signed-off-by: Meghana M 
Reviewed-on: http://review.gluster.org/11337
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System 
Reviewed-by: soumya k 
Reviewed-by: Kaleb KEITHLEY