glusterfs.git/cli, branch v3.6.1

porting: OSX build fixes

2014-10-23T19:09:49+00:00

 - xml build
 - do not redefine AT_SYMLINK_FOLLOW

Change-Id: I516b3713904a6bad946a30f76fe4821f2ac61fd3
BUG: 1130307
Signed-off-by: Harshavardhana 
Reviewed-on: http://review.gluster.org/8970
Tested-by: Gluster Build System 
Reviewed-by: Kaleb KEITHLEY

Do not hardcode umount(8) path, emulate lazy umount

2014-10-03T15:01:29+00:00

1) Use a system-dependent macro for umount(8) location instead of
relying on $PATH  to find it, for security and portability sake.

2) Introduce gf_umount_lazy() to replace umount -l (-l for lazy) invocations,
which is only supported on Linux; On Linux behavior in unchanged. On other
systems, we fork an external process (umountd) that will take care of
periodically attempt to unmount, and optionally rmdir.

Backport of Ia91167c0652f8ddab85136324b08f87c5ac1edd51d

BUG: 1138897
Change-Id: I9d82c87e85af0dee79f2de39bc697c486b7103c8
Signed-off-by: Emmanuel Dreyfus 
Reviewed-on: http://review.gluster.org/8863
Tested-by: Gluster Build System 
Reviewed-by: Csaba Henk 
Reviewed-by: Vijay Bellur

cli/snapshot : Add confirmation dialog to snapshot restore operation.

2014-09-23T10:14:39+00:00

When restoring a volume, the user is not prompted for confirmation.
Since restoring a volume rolls back the data to a previous point in time,
there is the potential for updates to be lost.
Hence it is better to display a confirmation dialogue during snapshot
restore operation.

Change-Id: I7b23eaeb43ad2aafa508e2ca5750d9b0fc7d6e36
BUG: 1145092
Signed-off-by: Sachin Pandit 
Reviewed-on: http://review.gluster.org/8525
Tested-by: Gluster Build System 
Reviewed-by: Vijaikumar Mallikarjuna 
Reviewed-by: Rajesh Joseph 
Reviewed-by: Kaushal M 
Signed-off-by: Sachin Pandit 
Reviewed-on: http://review.gluster.org/8806

cli/snapshot : update of a snapshot delete syntax in documentation.

2014-09-23T10:13:40+00:00

Change-Id: Id1a4b9684a8dd5750ee6eed841e3d5195407fb7e
BUG: 1145084
Signed-off-by: Sachin Pandit 
Reviewed-on: http://review.gluster.org/8534
Tested-by: Gluster Build System 
Reviewed-by: Kaushal M 
Signed-off-by: Sachin Pandit 
Reviewed-on: http://review.gluster.org/8805
Reviewed-by: Vijaikumar Mallikarjuna

feature/snapshot : Interface to delete all snapshots belonging to a system as-well-as to a particular volume

2014-09-23T09:01:04+00:00

Problem :
With the current design we can only delete a single snapshot.
And the deletion of volume which contains snapshot is not allowed.
Because of that user might be forced to delete all the snapshots
manually before he is allowed to delete a volume.

Solution:
Following is the interface with which user can delete
all the snapshots of a system or belonging to a particular volume.

        Syntax : gluster snapshot delete all

        *To delete all the snapshots present in a system

        Syntax : gluster snapshot delete volume 

        *To deletes all the snapshot present in a volume specified.

========================================================================
Sample Output:

Case 1 : Deleting a single snapshot.
[root@snapshot-24 glusterfs]# gluster snapshot delete snap1
Deleting snap will erase all the information about the snap. Do you still want to continue? (y/n) y
snapshot delete: snap1: snap removed successfully

-----------------------------------------------------------------
Case 2 : Deleting all the snapshots in a Volume.
[root@snapshot-24 glusterfs]# gluster snapshot delete volume vol1
Volume (vol1) contains 9 snapshot(s).
Do you still want to continue and delete them?  (y/n) y
snapshot delete: snap2: snap removed successfully
snapshot delete: snap3: snap removed successfully
snapshot delete: snap4: snap removed successfully
snapshot delete: snap5: snap removed successfully
.
.
.

-----------------------------------------------------------------
Case 3 : Deleting all the snapshots in a system.
[root@snapshot-24 glusterfs]# gluster snapshot delete all
System contains 4 snapshot(s).
Do you still want to continue and delete them?  (y/n) y
snapshot delete: snap7: snap removed successfully
snapshot delete: snap8: snap removed successfully
snapshot delete: snap9: snap removed successfully
snapshot delete: snap10: snap removed successfully
========================================================================

Change-Id: Ifec8e128ab2011cbbba208376b9c92cfbe7d8d71
BUG: 1145083
Signed-off-by: Sachin Pandit 
Reviewed-on: http://review.gluster.org/8162
Reviewed-by: Atin Mukherjee 
Tested-by: Gluster Build System 
Reviewed-by: Avra Sengupta 
Reviewed-by: Raghavendra Bhat 
Reviewed-by: Kaushal M 
Signed-off-by: Sachin Pandit 
Reviewed-on: http://review.gluster.org/8798
Reviewed-by: Vijaikumar Mallikarjuna

cli/snapshot : gluster volume info should not show the options which are not set explicitly.

2014-09-23T09:00:22+00:00

Problem : Even though snap-max-hard-limit, snap-max-soft-limit and
auto-delete values were not set explicitly, It was getting showed
in the output of gluster volume info.

Solution : Check if the value is already present in dictionary
(That means, it is set), If value is not present then consider
the default value,

NOTE : This patch doesn't solve the problem where the values
which is set globally are being displayed in gluster volume info

Change-Id: I61445b3d2a12eb68c38a19bea53b9051ad028050
BUG: 1145020
Signed-off-by: Sachin Pandit 
Reviewed-on: http://review.gluster.org/8191
Tested-by: Gluster Build System 
Reviewed-by: Atin Mukherjee 
Reviewed-by: Avra Sengupta 
Reviewed-by: Raghavendra Bhat 
Reviewed-by: Kaushal M 
Signed-off-by: Sachin Pandit 
Reviewed-on: http://review.gluster.org/8793
Reviewed-by: Vijaikumar Mallikarjuna

Fix quotad RPC options use-after-free bug in gluster

2014-09-08T06:24:58+00:00

In cli/src/cli.c:cli_quotad_clnt_rpc_init(), dict_unref (rpc_opts)
causes the options to be freed while code in rpc/rpc-transport/socket
still relies on it. The options are corrupted when memory is reallocated,
which sometimes leads to a crashes on NetBSD when socket_connect()
attempted to read options.

Fix the problem by not doing the dict_unref(). Make sure the rpc_opts
are freed on error, though.

This is a backport of If1d6ea50cc3e1599e9e369863c8db0c0694d3671

BUG: 1138897
Change-Id: Idcd46c3ee9a7daa64dfeb8950e14d6b99f177bb3
Signed-off-by: Emmanuel Dreyfus 
Reviewed-on: http://review.gluster.org/8635
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

build: make GLUSTERD_WORKDIR rely on localstatedir

2014-09-03T18:01:45+00:00

Backport from master branch - http://review.gluster.org/#/c/8246/

- Break-way from '/var/lib/glusterd' hard-coded previously,
  instead rely on 'configure' value from 'localstatedir'
- Provide 's/lib/db' as default working directory for gluster
  management daemon for BSD and Darwin based installations
- loff_t is really off_t on Darwin
- fix-off the warnings generated by clang on FreeBSD/Darwin
- Now 'tests/*' use GLUSTERD_WORKDIR a common variable for all
  platforms.
- Define proper environment for running tests, define correct PATH
  and LD_LIBRARY_PATH when running tests, so that the desired version
  of glusterfs is used, regardless where it is installed.
  (Thanks to manu@netbsd.org for this additional work)

Change-Id: I06e684ac4c26d1e74c9daf76753403ad15f79276
BUG: 1130308
Signed-off-by: Harshavardhana 
Reviewed-on: http://review.gluster.org/8486
Tested-by: Gluster Build System

cli: Xml output for geo-replication status command

2014-08-28T16:52:25+00:00

This patch adds xml output for geo-replication status
and status detail command.
sample:
--------------------------------------------------------------
  
    
      master
      
        
        :2a301d66-b9d2-44b4-b827-d680d67123eb:ssh://XXXXXXXXXX::slave
          
            localhost.localdomain
            2a301d66-b9d2-44b4-b827-d680d67123eb
            /root/master_b1
            ssh://XXXXXXXXXXX::slave
            faulty
            N/A
            N/A
          
        
      
    
  
-------------------------------------------------------------

Change-Id: Ia19dbe751c3ab1ec7cb8923cdd6c8b99c374072f
BUG: 1133464
Signed-off-by: ndarshan 
Reviewed-on: http://review.gluster.org/8089
Tested-by: Gluster Build System 
Reviewed-by: Kaushal M 
Signed-off-by: ndarshan 
Reviewed-on: http://review.gluster.org/8532
Reviewed-by: Sachin Pandit 
Reviewed-by: Vijay Bellur

cli: Xml output for geo-replication config command.

2014-08-28T16:52:07+00:00

This patch adds xml output for geo-replication config
command.
sample:
---------------------------------------------------------------------

  0
  0
  
  
    
      value
      value
      ...
      ...
      ...
    
  

---------------------------------------------------------------------

Change-Id: Iac0451983ae5d0e65b95604eb1c29b968e1ee22f
BUG: 1133464
Signed-off-by: ndarshan 
Reviewed-on: http://review.gluster.org/8270
Tested-by: Gluster Build System 
Reviewed-by: Kaushal M 
Signed-off-by: ndarshan 
Reviewed-on: http://review.gluster.org/8527
Reviewed-by: Sachin Pandit 
Reviewed-by: Vijay Bellur