glusterfs.git/cli/src, branch v3.7.0beta1

cli: fix vol_type in volume info xml

2015-04-28T08:55:25+00:00

xml parsing of voltype should be inline with the cli

Backport of http://review.gluster.org/10271

Change-Id: I41ddddac00d07f03b56a041e1c3f5a132fbd7393
BUG: 1215517
Signed-off-by: Atin Mukherjee 
Reviewed-on: http://review.gluster.org/10271
Tested-by: NetBSD Build System
Tested-by: Gluster Build System 
Reviewed-by: Kaushal M 
(cherry picked from commit 4c3724f195240e40994b71add255f85ee1b025fb)
Reviewed-on: http://review.gluster.org/10396
Reviewed-by: Krishnan Parthasarathi

glusterd: incorrect rsp.op_ret handling in volume get in cli

2015-04-28T08:54:19+00:00

Cherry picked from commit 540fc2829bd63a2fa070c68ed105eb23145df406:
> Change-Id: Iabe99c06166578fc90121e7cfdca4a6a3f5328ae
> BUG: 1211132
> Signed-off-by: Atin Mukherjee 
> Reviewed-on: http://review.gluster.org/10229
> Reviewed-by: Niels de Vos 
> Tested-by: Gluster Build System 
> Reviewed-by: Kaushal M 

Change-Id: Iabe99c06166578fc90121e7cfdca4a6a3f5328ae
BUG: 1215547
Signed-off-by: Atin Mukherjee 
Reviewed-on: http://review.gluster.org/10398
Reviewed-by: Niels de Vos 
Tested-by: NetBSD Build System
Tested-by: Gluster Build System

Fix case mistake for MKDIR_P in Makefiles

2015-04-23T05:31:42+00:00

Some makefiles used $(mkdir_p) instead of the corectly defined $(MKDIR_P).
The former is substituted as an empty string, leading to possible failures
depending of the user shell tolerance. NetBSD's /bin/sh seems to choke
more easily than Linux's /bin/bash, but if the later does not fail, it
does not created the intended directories anyway.

Resubmit after rebase in hope that regression test will have less
spurious failures.

Backport of: I8caed4000f3c91cb3a685453848fb854793945ed

BUG: 1212676
Change-Id: I393ffda8aa24bffce86f7b1f19b999ffa30c3562
Signed-off-by: Emmanuel Dreyfus 
Reviewed-on: http://review.gluster.org/10279
Tested-by: NetBSD Build System
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

geo-rep/cli : Fix geo-rep cli crash

2015-04-22T12:53:32+00:00

Fixes crash dump when "gluster vol geo-rep  status"
is run because of incorrect argc and index comparison.

Change-Id: Id14d63d020ad9c5951b54ef50e7c140e58d9d7a6
BUG: 1213048
Reviewed-on: http://review.gluster.org/10264
Signed-off-by: Kotresh HR 
Reviewed-on: http://review.gluster.org/10291
Tested-by: NetBSD Build System
Reviewed-by: Vijay Bellur 
Tested-by: Vijay Bellur

quota/disperse: handle inode quotas in xattr aggregate

2015-04-14T05:01:18+00:00

with the inode quota feature, quota size is now
increased from 64bit to 192bits which contains
values of 'file size', 'file count' and 'dir count'

This change in quota size xattr needs to be handled
in disperse xattr aggregation

Signed-off-by: vmallika 

Change-Id: I5fd28aa9f5b8b6cba83a98360236417a97ac16ee
BUG: 1207967
Reviewed-on: http://review.gluster.org/10112
Reviewed-by: Pranith Kumar Karampuri 
Tested-by: Gluster Build System 
Reviewed-by: Sachin Pandit 
Reviewed-by: Raghavendra G 
Tested-by: Raghavendra G

quota/cli: validate quota hard-limit option

2015-04-10T11:21:48+00:00

Quota hard-limit is supported only upto: 9223372036854775807 (int 64)

In CLI, it is allowed to set the value upto 16384PB (unsigned int 64),
this is not a valid value as the xattrop for quota accounting and
the quota enforcer operates on a signed int64 limit value.

This patches fixes the problem in CLI and allows user to set
the hard-limit value only from range 0 - 9223372036854775807

Change-Id: Ifce6e509e1832ef21d3278bacfa5bd71040c8cba
BUG: 1206432
Signed-off-by: vmallika 
Reviewed-on: http://review.gluster.org/10022
Tested-by: Gluster Build System 
Reviewed-by: Kaushal M 
Reviewed-by: Vijay Bellur

gluster-cli : Removing logically dead code

2015-04-10T10:02:23+00:00

Coverity CID: 1124451

Change-Id: I7b2901fdd2ace4666f9e2c6deaf3838322a1c6ff
BUG: 789278
Signed-off-by: Nandaja Varma 
Reviewed-on: http://review.gluster.org/9579
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

glusterd/snapshot: Fix CLI msg for snap limit set

2015-04-10T08:04:33+00:00

Change of message from "will lead to deletion of snaps"
to "Will limit creation of new snaps" when setting the
snapshot limits.

Change-Id: I4732555bb35d3ad30c2cef6ea6c7da42a8edf35d
BUG: 1116263
Signed-off-by: Joseph Fernandes 
Reviewed-on: http://review.gluster.org/8236
Tested-by: Gluster Build System 
Reviewed-by: Avra Sengupta 
Reviewed-by: Krishnan Parthasarathi 
Tested-by: Krishnan Parthasarathi

gluster-cli : Extra checks for word_count removed.

2015-04-10T06:40:26+00:00

Coverity IDs:
1124453
1124454

In the first case, In the beginning of the function check is made
to see of the word_count is less than 4. If yes it returns. So it
wouldn't reach this part if that check takes the true path. So
this code is logically dead.

In second and third case, this is in false branch for word_cound <6.
So word_count can't possibly be less than 5 at this point.

Change-Id: Id5e1c81045ce7bc0ee6b7612ea54ef2b7f54b699
BUG: 789278
Signed-off-by: Nandaja Varma 
Reviewed-on: http://review.gluster.org/9582
Tested-by: Gluster Build System 
Reviewed-by: Humble Devassy Chirammal 
Reviewed-by: Vijay Bellur

glusterd: remove-brick status/stop should not show output for non-existing brick

2015-04-09T17:21:06+00:00

Previously when user start remove-brick operation on a volume then by
giving non-existing brick for remove-brick status/stop command it was
showing remove-brick status/stoping remove-brick operation on a volume.

With this fix it will validate bricks which user have given for
remove-brick status/stop command and if bricks are part of volume then
it will show statistics of remove-brick operation otherwise it will show
error "Incorrect brick  for ".

Change-Id: I151284ef78c25f52d1b39cdbd71ebfb9eb4b8471
BUG: 1121584
Signed-off-by: Gaurav Kumar Garg 
Reviewed-on: http://review.gluster.org/9681
Tested-by: Gluster Build System 
Reviewed-by: Krishnan Parthasarathi 
Tested-by: Krishnan Parthasarathi