glusterfs.git/cli/src/cli.h, branch v3.4.7

cli: Add statusStr xml tag to task list and rebalance/remove brick status

2013-09-19T17:28:27+00:00

 Backport of cd7951aa31ae4bbdf35fc6d1f2466636844b889d from master

New xml tag statusStr added to following gluster cli commands
gluster volume status all --xml (For Task status)
gluster volume rebalance  status --xml
gluster volume remove-brick   status --xml

Example(volume status all):

    Rebalance
    82d8d122-8738-4144-8507-d93fc98b61df
    3
    completed


Example(volume rebalance  status)

    localhost
    0
    0
    0
    0
    3
    completed


Also modified task status as string instead of showing number
in gluster volume status all

Example:
Status of volume: gv1
Gluster process                                         Port    Online  Pid
------------------------------------------------------------------------------
Brick sumne.sumne:/gfs/b1                               49154   Y       15489
Brick sumne.sumne:/gfs/b2                               49155   Y       15493
NFS Server on localhost                                 N/A     N       15913

           Task                                      ID         Status
           ----                                      --         ------
      Rebalance    82d8d122-8738-4144-8507-d93fc98b61df      completed

BUG: 1003521
Change-Id: I2f6845b621cbd5a74aeb3a3195f944536745e0ec
Original-author: Aravinda VK 
Signed-off-by: Kaushal M 
Reviewed-on: http://review.gluster.org/5969
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

glusterfs : Moved option files, and statedumps from /tmp

2013-01-29T23:27:29+00:00

Change-Id: Ibdede396c4d6859225937316b7a59a661bcaf9f5
BUG: 764890
Signed-off-by: Avra Sengupta 
Reviewed-on: http://review.gluster.org/4422
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

debug/trace: save the recent fops received in the event-history

2013-01-18T05:15:13+00:00

* Make use of event-history in debug/trace xlator to dump the recent fops,
when statedump is given. trace xlator saves the fop it received along
with the time in the event-history and upon statedump signal, dumps its
history. The size of the event-history can be given as a xlator option.

* Make changes in trace to take logging into log-file or logging to
history as an option. By default both are off.

Change-Id: I12baee5805c6efb55735cead4e2093fb94d7a6a0
BUG: 797171
Signed-off-by: Raghavendra Bhat 
Reviewed-on: http://review.gluster.org/4088
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

cli: output xml in pretty format

2013-01-17T07:59:48+00:00

Gluster cli now prints XML outputs in 'pretty' format. This solves the problem
of empty elements occuring as two tags instead of being collapsed into one.

Change-Id: Iab7aeadcff29c18ae388b58e446a16e937ac09ed
BUG: 849293
Signed-off-by: Kaushal M 
Reviewed-on: http://review.gluster.org/4355
Reviewed-by: Krutika Dhananjay 
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

BD Backend: CLI commands to create/delete image

2012-11-29T17:39:53+00:00

Cli commands  added to create/delete a LV device.

The following command creates lv in a given vg.
$ gluster bd create :/ 

The following command deletes lv in a given vg.
$ gluster bd delete :/

BUG: 805138
Change-Id: Ie4e100eca14e2ee32cf2bb4dd064b17230d673bf
Signed-off-by: M. Mohan Kumar 
Reviewed-on: http://review.gluster.org/3718
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

cli: XML output for "geo-replication {start|stop}"

2012-11-23T10:08:16+00:00

Change-Id: I8d2213cc00deb458fb765b848d0e3452574cc98f
BUG: 864499
Signed-off-by: Kaushal M 
Reviewed-on: http://review.gluster.org/4217
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

cli: Changes and enhancements to XML output

2012-10-11T23:34:16+00:00

This patch contains several xml related changes which fix some bugs and
introduce xml output for commands which were missing it. These include,
* XML output for rebalance & remove-brick status
* XML output for replace-brick
* XML output for 'volume status all' in on xml document
* proper XML output for "volume {create|start|stop|delete}"
* type & status of a volume in 'volume info' is now given as a string as well

This patch also cleans up the '#if (HAVE_LIB_XML)' sections from the code-base,
so that it is not littered around.

Change-Id: I5bb022adf0fedf7e3ead92b4b79bfa02b0b5fef5
BUG: 828131
Signed-off-by: Kaushal M 
Reviewed-on: http://review.gluster.org/3869
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

cli: removed extra dict unrefs and memory leaks

2012-09-30T21:12:01+00:00

PROBLEMS ADDRESSED:
a. The following change
      http://review.gluster.com/#change,3948
   introduces extra dict unrefs in cli.
b. There are instances of memory leak in gf_cli_*_cbk functions.

FIX:
Problem (a) is fixed by ensuring the dict is ref'd (indirectly at
the time of creation) and unref'd (in CLI_STACK_DESTROY) ONLY
once. The following is the rationale behind this approach:

   The number of refs and unrefs on dict varies across the different
   commands that use it. The cli thread MUST wait for the
   gf_cli_*_cbks to complete before the frame is destroyed. This
   rules out the need to do extra refs and unrefs in the code path.

Problem (b) is fixed by doing unref on dicts that are created for
the purpose of unserializing the response but never freed in
gf_cli_*_cbk functions.

Change-Id: I5a7431543fc8e3cac4d256f5c87d1e3c62a331be
BUG: 823081
Signed-off-by: Krutika Dhananjay 
Reviewed-on: http://review.gluster.org/3966
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

glusterd: Fix to log command status at the appropriate time

2012-09-20T15:26:22+00:00

PROBLEM:
In the existing implementation, the success/failure of
execution of a command is decided (and logged) in glusterd
handler functions. Strictly speaking, the logging mechanism
must take into account what course the command takes within
the state machine before concluding whether it succeeded or
failed.

FIX:
This patch attempts to fix the above issue for vol commands.
The format of the log message is as follows:
    for failure:
     : FAILED : 
    for success:
     : SUCCESS

APPROACH (in a nutshell):

 * The command string is packed into dict at cli and sent to
   glusterd.
 * glusterd logs the command status just before doing a
   "submit_reply", which is called (either directly or
   indirectly via a call to glusterd_op_cli_send_response)
   at 2 places for every vol command:
   i. in handler functions, and
   ii. in glusterd_op_txn_complete

In short, the failure of a command in the handler implies the
command has indeed failed. However, its success in the handler
does NOT necessarily mean the command succeeded/will succeed.

Change-Id: I5a8a2ddc318ef2dc2a9699f704a6bcd2f0ab0277
BUG: 823081
Signed-off-by: Krutika Dhananjay 
Reviewed-on: http://review.gluster.org/3948
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

All: License message change

2012-09-13T20:19:37+00:00

License message changed for server-side, dual license GPLV2 and LGPLv3+.

Change-Id: Ia9e53061b9d2df3b3ef3bc9778dceff77db46a09
BUG: 852318
Signed-off-by: Varun Shastry 
Reviewed-on: http://review.gluster.org/3940
Tested-by: Gluster Build System 
Reviewed-by: Kaleb KEITHLEY 
Reviewed-by: Anand Avati