glusterfs.git/cli/src/cli.c, branch v3.7.16

cli/quota: Sort the list output alphabetically by path

2016-04-27T16:46:50+00:00

This is a backport of http://review.gluster.org/14000

> Change-Id: I0b124e119d167817be2ae3eb52ac6c80fc7db5d1
> BUG: 1320716
> Signed-off-by: vmallika 
> Reviewed-on: http://review.gluster.org/14000
> Smoke: Gluster Build System 
> NetBSD-regression: NetBSD Build System 
> CentOS-regression: Gluster Build System 
> Reviewed-by: Kaushal M 

Change-Id: I87e12d58c8e267b2af67e287998e7313efc70af4
BUG: 1330018
Signed-off-by: vmallika 
Reviewed-on: http://review.gluster.org/14061
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
NetBSD-regression: NetBSD Build System

cli: on error invoke cli_cmd_broadcast_response function in separate thread

2015-08-31T15:04:08+00:00

This is a backport of http://review.gluster.org/#/c/11990/

There is a problem in current CLI framework
CLI holds the lock when processing command.
When processing quota list command, below sequence of steps executed in the
same thread and causing deadlock

1) CLI holds the lock
2) Send rpc_clnt_submit request to quotad for quota usage
3) If quotad is down, rpc_clnt_submit invokes cbk function with error
4) cbk function cli_quotad_getlimit_cbk tries to hold lock to broadcast
   the results and hangs, because same thread has already holding the lock

This patch fixes the problem by creating seperate thread for
broadcasting the result

> Change-Id: I53be006eadf6aaf348083d9168535530d70a8ab3
> BUG: 1242819
> Signed-off-by: vmallika 

Change-Id: Ic3c651c143e4143cfb4542d99b4856e582022e36
BUG: 1257881
Signed-off-by: vmallika 
Reviewed-on: http://review.gluster.org/12038
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System 
Reviewed-by: Kaushal M

quota :display the size of soft limit percentage

2015-08-26T12:09:47+00:00

Display the size equivalent to the soft limit percentage
in gluster v quota  list  and
gluster v quota  list-objects  command

        Backport of http://review.gluster.org/#/c/11808/

Cherry picked from commit b9e87f39386fc9c591c7698357c2899afc255b95
> Change-Id: I31ee82e9e836068348cf9458dcaf13f043d9fd87
> BUG: 1248521
> Signed-off-by: Manikandan Selvaganesh 
> Reviewed-on: http://review.gluster.org/11808
> Tested-by: NetBSD Build System 
> Reviewed-by: Vijaikumar Mallikarjuna 
> Reviewed-by: Raghavendra G 

Change-Id: I31ee82e9e836068348cf9458dcaf13f043d9fd87
BUG: 1255644
Signed-off-by: Manikandan Selvaganesh 
Reviewed-on: http://review.gluster.org/11977
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System 
Reviewed-by: Raghavendra G

rpc: add owner xlator argument to rpc_clnt_new

2015-08-14T10:10:47+00:00

The @owner argument tells RPC layer the xlator that owns
the connection and to which xlator THIS needs be set during
network notifications like CONNECT and DISCONNECT.

Code paths that originate from the head of a (volume) graph and use
STACK_WIND ensure that the RPC local endpoint has the right xlator saved
in the frame of the call (callback pair). This guarantees that the
callback is executed in the right xlator context.

The client handshake process which includes fetching of brick ports from
glusterd, setting lk-version on the brick for the session, don't have
the correct xlator set in their frames. The problem lies with RPC
notifications. It doesn't have the provision to set THIS with the xlator
that is registered with the corresponding RPC programs. e.g,
RPC_CLNT_CONNECT event received by protocol/client doesn't have THIS set
to its xlator. This implies, call(-callbacks) originating from this
thread don't have the right xlator set too.

The fix would be to save the xlator registered with the RPC connection
during rpc_clnt_new. e.g, protocol/client's xlator would be saved with
the RPC connection that it 'owns'. RPC notifications such as CONNECT,
DISCONNECT, etc inherit THIS from the RPC connection's xlator.

Change-Id: I9dea2c35378c511d800ef58f7fa2ea5552f2c409
BUG: 1253212
Signed-off-by: Krishnan Parthasarathi 
Reviewed-on: http://review.gluster.org/11436
Tested-by: Gluster Build System 
Tested-by: NetBSD Build System 
Reviewed-by: Raghavendra G 
(cherry picked from commit f7668938cd7745d024f3d2884e04cd744d0a69ab)
Reviewed-on: http://review.gluster.org/11908
Reviewed-by: Pranith Kumar Karampuri

cli: Create missing logbuf_pool

2015-07-24T11:19:30+00:00

        Backport of http://review.gluster.org/#/c/11691/

Since logbuf_pool was not created via glusterfs_ctx_defaults_init(),
the following error was present in cli logs repeateadly for each
and every execution of a gluster command.

E [mem-pool.c:417:mem_get0] (-->/usr/local/lib/libglusterfs.so.0(+0x7e262)
[0x7fdbc0b1f262] -->/usr/local/lib/libglusterfs.so.0(_gf_msg+0x804)
[0x7fdbc0ac7844] -->/usr/local/lib/libglusterfs.so.0(mem_get0+0x78)
[0x7fdbc0af5b48] ) 0-mem-pool: invalid argument [Invalid argument]

This change creates ctx->logbuf_pool via glusterfs_ctx_defaults_init()
in cli.c so that the above error is no longer logged in cli logs.

Change-Id: I3fcd9cfefa06ddd52e1989b039ff5637372c3235
BUG: 1244103
Signed-off-by: Anoop C S 
Reviewed-on: http://review.gluster.org/11705
Reviewed-by: Jeff Darcy 
Tested-by: Gluster Build System 
Tested-by: NetBSD Build System 
Reviewed-by: Atin Mukherjee

geo-rep/cli : Fix geo-rep cli crash

2015-04-22T12:53:32+00:00

Fixes crash dump when "gluster vol geo-rep  status"
is run because of incorrect argc and index comparison.

Change-Id: Id14d63d020ad9c5951b54ef50e7c140e58d9d7a6
BUG: 1213048
Reviewed-on: http://review.gluster.org/10264
Signed-off-by: Kotresh HR 
Reviewed-on: http://review.gluster.org/10291
Tested-by: NetBSD Build System
Reviewed-by: Vijay Bellur 
Tested-by: Vijay Bellur

cli: Allow options prefixed with '--' for geo-rep config cmds

2015-04-09T11:36:04+00:00

Geo-replications allows users to send rsync_options from
cli but while parsing, options prefixed with '--' are
treated as unrecognized apart from a few options. Because
of this rsync_options can't be set through cli. This
patch allows such options if it's a geo-rep config command.

e.g.
gluster vol geo-rep master fedora1::slave config rsync-options \
"--bwlimit=1.5m"

Change-Id: I4b4f10c0efd3f3a362ece65e697d5ce1498f84ac
BUG: 1168108
Signed-off-by: Kotresh HR 
Reviewed-on: http://review.gluster.org/9198
Reviewed-by: Aravinda VK 
Tested-by: Gluster Build System 
Reviewed-by: Krishnan Parthasarathi 
Tested-by: Krishnan Parthasarathi

cli: log gluster version in cli init

2015-03-26T07:17:36+00:00

Change-Id: I4994043d303212da795c76867a7ee4355d318a8c
Signed-off-by: Atin Mukherjee 
Reviewed-on: http://review.gluster.org/9951
Tested-by: Gluster Build System 
Reviewed-by: Kaleb KEITHLEY 
Reviewed-by: Krishnan Parthasarathi 
Tested-by: Krishnan Parthasarathi

features/quota : Introducing inode quota

2015-03-19T01:24:12+00:00

==========================================================================
                             Inode quota
==========================================================================
= Currently, the only way to retrieve the number of files/objects in a   =
= directory or volume is to do a crawl of the entire directory/volume.   =
= This is expensive and is not scalable.                                 =
=                                                                        =
= The proposed mechanism will provide an easier alternative to determine =
= the count of files/objects in a directory or volume.                   =
=                                                                        =
= The new mechanism proposes to store count of objects/files as part of  =
= an extended attribute of a directory. Each directory's extended        =
= attribute value will indicate the number of files/objects present      =
= in a tree with the directory being considered as the root of the tree. =
=                                                                        =
= The count value can be accessed by performing a getxattr().            =
= Cluster translators like afr, dht and stripe will perform aggregation  =
= of count values from various bricks when getxattr() happens on the key =
= associated with file/object count.                                     =

A new interface is introduced:
------------------------------
        limit-objects  : limit the number of inodes at directory level
        list-objects   : list the directories where the limit is set
        remove-objects : remove the limit from the directory

==========================================================================

CLI COMMAND:
gluster volume quota  limit-objects   []

*  is a hard-limit for number of objects limitation for path ""
  If hard-limit is exceeded, creation of file/directory is no longer
permitted.

*  is a soft-limit for number of objects creation for path ""
  If soft-limit is exceeded, a warning is issued for each creation.

CLI COMMAND:
gluster volume quota  remove-objects [path]

==========================================================================

CLI COMMAND:
gluster volume quota  list-objects [path] ...

Sample output:
------------------
  Path                   Hard-limit Soft-limit   Used  Available
Soft-limit exceeded?
Hard-limit exceeded?
  ------------------------------------------------------------------------
--------------------------------------
  /dir                      10       80%          10       0
Yes
        Yes

==========================================================================

[root@snapshot-28 dir]# ls
a  b  file11  file12  file13  file14  file15  file16  file17
[root@snapshot-28 dir]# touch a1
touch: cannot touch `a1': Disk quota exceeded
* Nine files are created in directory "dir" and directory is included in
* the
count too. Hence the limit "10" is reached and further file creation
fails

==========================================================================

Note: We have also done some re-factoring in cli for volume name
validation. New function cli_validate_volname is created

==========================================================================

Change-Id: I1823497de4f790a2a20ebb1770293472ea33ee2b
BUG: 1190108
Signed-off-by: Sachin Pandit 
Signed-off-by: vmallika 
Reviewed-on: http://review.gluster.org/9769
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

quota: quotad.socket files should be created under /var/run/gluster

2015-03-03T12:51:39+00:00

Change-Id: I49502a4f7516c02f7e321c16eebd748545afde07
BUG: 1197587
Signed-off-by: vmallika 
Reviewed-on: http://review.gluster.org/9778
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur