glusterfs.git/cli/src/cli-rpc-ops.c, branch v3.7.19

cli: fix volume status xml generation

2016-11-14T11:09:36+00:00

While generating xml, if CLI fails in between xml output doesn't get dumped into
stdout. Fix is to invoke cli_xml_output_vol_status_end () in such failures.

>Reviewed-on: http://review.gluster.org/15384
>NetBSD-regression: NetBSD Build System 
>CentOS-regression: Gluster Build System 
>Smoke: Gluster Build System 
>Reviewed-by: Samikshan Bairagya 
>Reviewed-by: Prashanth Pai 

Change-Id: I7cb3097f5ae23092e6d20f68bd75aa190c31ed88
BUG: 1392181
Signed-off-by: Atin Mukherjee 
Reviewed-on: http://review.gluster.org/15820
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
NetBSD-regression: NetBSD Build System 
Reviewed-by: Prashanth Pai

snapshot/cli: Fix snapshot status xml output

2016-11-02T06:33:45+00:00

    Backport of http://review.gluster.org/#/c/14018/

snap status --xml errors out if a brick is down and
doesn't have pid. It is handled in the cli of the snap
status where "N/A" is displayed in such a scenario.
Handled the same in xml

snap status  --xml fails as the writer is
not initialised for the same. Using GF_SNAP_STATUS_TYPE_ITER
instead of GF_SNAP_STATUS_TYPE_SNAP for all snap's
status to differentiate between the two scenarios.

Added testcase volume-snapshot-xml.t to check
all snapshot commands xml outputs

> Reviewed-on: http://review.gluster.org/14018
> Smoke: Gluster Build System 
> CentOS-regression: Gluster Build System 
> NetBSD-regression: NetBSD Build System 
> Reviewed-by: Rajesh Joseph 

Change-Id: I99563e8f3e84f1aaeabd865326bb825c44f5c745
BUG: 1369363
Signed-off-by: Avra Sengupta 
Reviewed-on: http://review.gluster.org/15290
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Rajesh Joseph

gluster: Fixed typos

2016-09-08T14:08:20+00:00

This is not a backport from master as one of
these typos has already been fixed in master.

Posting this on behalf of Patrick M.
credit: pmatthaei@debian.org

Change-Id: I15dca6fc2c7df2fcb84db8f01c8585eeff26a114
BUG: 1223935
Original-author: Patrick Matthäi 
Signed-off-by: N Balachandran 
Reviewed-on: http://review.gluster.org/15122
CentOS-regression: Gluster Build System 
NetBSD-regression: NetBSD Build System 
Reviewed-by: Niels de Vos 
Smoke: Gluster Build System

build: correctly format some (s)size_t messages

2016-09-07T11:49:42+00:00

On 32-bit builds the are are warnings like these:

    posix.c:6438: warning: format '%ld' expects type 'long int', but argument 11 has type 'ssize_t'

Instead of using "%l" for (signed) size_t variables, "%z" should be
used.

Cherry picked from commit 3af889f02722f4636d2ea30570de6477e8b5a3a9:
> BUG: 1198849
> Change-Id: I6f57b5e8ea174dd9e3056aff5da685e497894ccf
> Signed-off-by: Niels de Vos 
> Reviewed-on: http://review.gluster.org/14933
> NetBSD-regression: NetBSD Build System 
> CentOS-regression: Gluster Build System 
> Reviewed-by: Kaleb KEITHLEY 
> Smoke: Gluster Build System 

This patch is not really recommended for backporting, but we do have a
new smoke test that fails when these warnings pop-up. It is cleaner to
correct the code in the release-3.7 branch then to modify the smoke test
to skip this branch.

Change-Id: I6f57b5e8ea174dd9e3056aff5da685e497894ccf
BUG: 1225842
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/15401
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Kaleb KEITHLEY 
Smoke: Gluster Build System

feature/bitrot: Show whether scrub is in progress/idle

2016-07-15T13:42:25+00:00

Backport of http://review.gluster.org/14864/

Bitrot scrub status shows whether the scrub is paused
or active. It doesn't show whether the scrubber is
actually scrubbing or waiting in the timer wheel
for the next schedule. This patch shows this status
with "In Progress" and "Idle" respectively.

Change-Id: I995d8553d1ff166503ae1e7b46282fc3ba961f0b
BUG: 1355635
Signed-off-by: Kotresh HR 
(cherry picked from commit f4757d256e3e00132ef204c01ed61f78f705ad6b)
Reviewed-on: http://review.gluster.org/14900
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
NetBSD-regression: NetBSD Build System 
Reviewed-by: Jeff Darcy

tier/cli : printing a warning instead of skipping the node

2016-05-20T18:19:49+00:00

        back-port of : http://review.gluster.org/#/c/14347/8

Problem: skipping the status of the nodes down creates confusion
to the user as one might see the status as completed for all nodes
and while performing detach commit, the operation will fail as the
node is down

Fix: Display a warning message

Note: When the last node is down (as per the peer list) then
warning message can't be displayed as the total number of peers
participating in the transaction is considered to be the total count.

>Change-Id: Ib7afbd1b26df3378e4d537db06f41f5c105ad86e
>BUG: 1324439
>Signed-off-by: hari gowtham 

Change-Id: Ie4296e932abaf163edc55b540b26dc6f5824ea85
BUG: 1328410
Signed-off-by: hari gowtham 
Reviewed-on: http://review.gluster.org/14458
Tested-by: hari gowtham 
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
Reviewed-by: Atin Mukherjee 
CentOS-regression: Gluster Build System

cli/bitrot: Unmask scrub statistics

2016-05-04T05:45:43+00:00

Revert the commit 2a37dbd845348a774f45c4d77cffebc32c749251
The scrub statistics were masked because of inaccurate
stats. Now with http://review.gluster.org/#/c/14044/
it's fixed, hence unmasking it.

>Change-Id: Iffff5f48eb8121b617af82ecfb70bec5b2772c23
>BUG: 1329211
>Signed-off-by: Kotresh HR 
>Reviewed-on: http://review.gluster.org/14121
>Smoke: Gluster Build System 
>NetBSD-regression: NetBSD Build System 
>CentOS-regression: Gluster Build System 
>Reviewed-by: Venky Shankar 
>Reviewed-by: Atin Mukherjee 
>Signed-off-by: Kotresh HR 

Change-Id: I958bcae4eebca6bdf7b80866e2c40d3428ef78a4
BUG: 1332072
Signed-off-by: Kotresh HR 
Reviewed-on: http://review.gluster.org/14142
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
NetBSD-regression: NetBSD Build System 
Reviewed-by: Venky Shankar

cli/quota: Sort the list output alphabetically by path

2016-04-27T16:46:50+00:00

This is a backport of http://review.gluster.org/14000

> Change-Id: I0b124e119d167817be2ae3eb52ac6c80fc7db5d1
> BUG: 1320716
> Signed-off-by: vmallika 
> Reviewed-on: http://review.gluster.org/14000
> Smoke: Gluster Build System 
> NetBSD-regression: NetBSD Build System 
> CentOS-regression: Gluster Build System 
> Reviewed-by: Kaushal M 

Change-Id: I87e12d58c8e267b2af67e287998e7313efc70af4
BUG: 1330018
Signed-off-by: vmallika 
Reviewed-on: http://review.gluster.org/14061
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
NetBSD-regression: NetBSD Build System

Tier: tier command fails message when any node is down

2016-04-22T15:12:39+00:00

        back-port of : http://review.gluster.org/#/c/13918/

PROBLEM: the dict doesn't get set on the node if its down.
so while printing the output on cli we get a ENOENT
which ends in a tier command failed.

FIX: this patch skips the node that wasn't available
and carrys on with the next node for both tier status
and tier detach status.

>Change-Id: I718a034b18b109748ec67f3ace56540c50650d23
>BUG: 1324439
>Signed-off-by: hari 
>Reviewed-on: http://review.gluster.org/13918
>Smoke: Gluster Build System 
>Tested-by: hari gowtham 
>NetBSD-regression: NetBSD Build System 
>CentOS-regression: Gluster Build System 
>Reviewed-by: Kaushal M 

Change-Id: Ia23df47596adb24816de4a2a1c8db875f145838e
BUG: 1328410
Signed-off-by: hari 
Reviewed-on: http://review.gluster.org/14030
Smoke: Gluster Build System 
Tested-by: hari gowtham 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Dan Lambright

quota/cli: display quota usage on path when limit not set

2016-04-05T12:27:21+00:00

This is a backport of http://review.gluster.org/#/c/13893/

When a quota limit is not set, 'quota list ' should still display
the usage when a path parameter is specified.

> Change-Id: Ida12d9c5e348fbd98db4d68d9324c623cbdd3dea
> BUG: 1323360
> Signed-off-by: vmallika 

Change-Id: I51cf46faffb324d2632dfde4264cd95d2da22479
BUG: 1323490
Signed-off-by: vmallika 
Reviewed-on: http://review.gluster.org/13895
CentOS-regression: Gluster Build System 
NetBSD-regression: NetBSD Build System 
Smoke: Gluster Build System