glusterfs.git/cli/src/cli-rpc-ops.c, branch v3.12.5

cli: correct rebalance status elapsed check

2017-11-10T08:51:04+00:00

Check that elapsed time has crossed 10 mins for at least
one rebalance process before displaying the estimates.

> BUG: 1479528
> Signed-off-by: N Balachandran 
(cherry picked from commit 56aef68530b3bab27730aa62e4fbc513d3dba65f)
Change-Id: Ib357a6f0d0125a178e94ede1e31514fdc6ce3593
BUG: 1511271
Signed-off-by: N Balachandran

geo-rep/scheduler: Add validation for session existence

2017-10-12T18:44:40+00:00

Added validation to check for session existence
to give out proper error message out.

> Change-Id: I13c5f6ef29c1395cff092a14e1bd2c197a39f058
> BUG: 1499159
> Signed-off-by: Kotresh HR 
(cherry picked from commit 938addeb7ec634e431c2c8c0a768a2a9ed056c0d)


Change-Id: I13c5f6ef29c1395cff092a14e1bd2c197a39f058
BUG: 1499392
Signed-off-by: Kotresh HR

cli/afr: gluster volume heal info "healed" command output is not appropriate

2017-10-11T10:02:57+00:00

Problem: "gluster volume heal info [healed] [heal-failed]" command
          output on terminal is not appropriate in case of down any volume.

Solution: To make message more appropriate change the condition
          in function "gd_syncop_mgmt_brick_op".

Test : To verify the fix followed below procedure
       1) Create 2*3 distribute replicate volume
       2) set self-heal daemon off
       3) kill two bricks (3, 6)
       4) create some file on mount point
       5) bring brick 3,6 up
       6) kill other two brick (2 and 4)
       7) make self heal daemon on
       8) run "gluster v heal "

Note: After apply the patch options (healed | heal-failed) will deprecate
      from command line.

> BUG: 1388509
> Change-Id: I229c320c9caeb2525c76b78b44a53a64b088545a
> Signed-off-by: Mohit Agrawal 
> (Cherry pick from commit d1f15cdeb609a1b720a04a502f7a63b2d3922f41)

BUG: 1500662
Change-Id: I229c320c9caeb2525c76b78b44a53a64b088545a
Signed-off-by: Mohit Agrawal

tier: separation of attach-tier from add-brick

2017-08-04T20:34:03+00:00

PROBLEM: Both attach tier and add brick have the same RPC
and set of code. This becomes a hurdle while tring to implement
add brick on a tiered volume.

FIX: This patch separates the add brick and attach tier
giving them separate RPCs.

>Change-Id: Iec57e972be968a9ff00b15b507e56a4f6dc398a2
>BUG: 1376326
>Signed-off-by: hari gowtham 
>Reviewed-on: https://review.gluster.org/15503
>Smoke: Gluster Build System 
>Tested-by: hari gowtham 
>Reviewed-by: Samikshan Bairagya 
>CentOS-regression: Gluster Build System 

Signed-off-by: hari gowtham 
Change-Id: Iec57e972be968a9ff00b15b507e56a4f6dc398a2
BUG: 1478276
Reviewed-on: https://review.gluster.org/17974
Smoke: Gluster Build System 
Tested-by: hari gowtham 
Reviewed-by: Shyamsundar Ranganathan 
CentOS-regression: Gluster Build System

glusterd: Add geo-replication session details to get-state output

2017-08-04T13:32:52+00:00

This commit adds support to the get-state CLI to capture details
on geo-replication session as obtained in
`gluster volume geo-replication status detail` in its output.

> Reviewed-on: https://review.gluster.org/17941
> Smoke: Gluster Build System 
> Reviewed-by: Shubhendu Tripathi 
> CentOS-regression: Gluster Build System 
> Reviewed-by: Atin Mukherjee 

(cherry picked from commit 2e7daeffef05c6100cbcc39f1be62935711db3eb)

Fixes: #291
Change-Id: I2fbcba70bfdaf439522637234805545194777ed4
Signed-off-by: Samikshan Bairagya 
Reviewed-on: https://review.gluster.org/17971
CentOS-regression: Gluster Build System 
Smoke: Gluster Build System 
Reviewed-by: Shyamsundar Ranganathan

cluster/dht: Fix negative rebalance estimates

2017-07-31T17:20:17+00:00

The calculation of the rebalance estimates will start
after the rebalance operation has been running for 10
minutes. This patch also changes the cli rebalance status
code to use unsigned variables for the time calculations.

> BUG: 1457985
> Signed-off-by: N Balachandran 
> Reviewed-on: https://review.gluster.org/17863
> Reviewed-by: Amar Tumballi 
> Smoke: Gluster Build System 
> Reviewed-by: Atin Mukherjee 
> CentOS-regression: Gluster Build System 
(cherry picked from commit e21c915679244ddc1fae886e52badf02b4d95efc)
Change-Id: Ic76f517c59ad938a407f1cf5e3b9add571690a6c
BUG: 1475399
Signed-off-by: N Balachandran 
Reviewed-on: https://review.gluster.org/17882
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Shyamsundar Ranganathan

Tier/cli: detach status xml output

2017-05-17T05:07:39+00:00

Problem: detach status xml output was broken because
of the wrong argument. The status_op sent to verify
whether it is a tier status command was as false.

Fix: the argument being passed was changed from false
to true.

Change-Id: I8cdd4dd972d6bfbb61c1182cbf4097767f83c7c5
BUG: 1446362
Signed-off-by: hari gowtham 
Reviewed-on: https://review.gluster.org/17131
Smoke: Gluster Build System 
Tested-by: hari gowtham 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Atin Mukherjee 
Reviewed-by: N Balachandran

dht:Spacing issue in fix-layout o/p

2017-05-09T15:21:11+00:00

There is a spacing issue in the status output of
the rebalance fix-layout operations. If the local
host name is big then we will have spacing issue.

Change-Id: I2fcc4fd382723fb7e93cb4d4dad03dae682cc1a8
BUG: 1437748
Signed-off-by: AnkitRaj 
Reviewed-on: https://review.gluster.org/17203
Smoke: Gluster Build System 
Tested-by: ankitraj
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Jeff Darcy

cli: fix build error with --disable-xml-output

2017-05-08T17:35:35+00:00

./configure --disable-xml-output --disable-georeplication
make

Making all in src
  CC       cli.o
In file included from cli.c:42:0:
cli.h:440:24: error: unknown type name ‘xmlTextWriterPtr’
 cli_xml_output_common (xmlTextWriterPtr writer, int op_ret, int op_errno,
                        ^
cli.h:443:26: error: unknown type name ‘xmlTextWriterPtr’
 cli_xml_snapshot_delete (xmlTextWriterPtr writer, xmlDocPtr doc, dict_t *dict,
                          ^
cli.h:443:51: error: unknown type name ‘xmlDocPtr’
 cli_xml_snapshot_delete (xmlTextWriterPtr writer, xmlDocPtr doc, dict_t *dict,
                                                   ^
make[1]: *** [cli.o] Error 1
make: *** [all-recursive] Error 1

Change-Id: I36c2dfc11f89d774b62dfe6f50b156826bed5b66
Signed-off-by: Kinglong Mee 
Reviewed-on: https://review.gluster.org/17136
Smoke: Gluster Build System 
Reviewed-by: Atin Mukherjee 
Reviewed-by: Prashanth Pai 
Tested-by: Prashanth Pai 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System

Fixes quota aux mount failure

2017-05-08T06:15:55+00:00

The aux mount is created on the first limit/remove_limit/list command
and it remains until volume is stopped / deleted / (quota is disabled)
, where we do a lazy unmount. If the process is uncleanly terminated,
then the mount entry remains and we get (Transport disconnected) error
on subsequent attempts to run quota list/limit-usage/remove commands.

Second issue, There is also a risk of inadvertent rm -rf on the
/var/run/gluster causing data loss for the user. Ideally, /var/run is
a temp path for application use and should not cause any data loss to
persistent storage.

Solution:
1) unmount the aux mount after each use.
2) clean stale mount before mounting, if any.

One caveat with doing mount/unmount on each command is that we cannot
use same mount point for both list and limit commands.
The reason for this is that list command needs mount to be accessible
in cli after response from glusterd, So it could be unmounted by a
limit command if executed in parallel (had we used same mount point)
Hence we use separate mount points for list and limit commands.

Change-Id: I4f9e39da2ac2b65941399bffb6440db8a6ba59d0
BUG: 1433906
Signed-off-by: Sanoj Unnikrishnan 
Reviewed-on: https://review.gluster.org/16938
NetBSD-regression: NetBSD Build System 
Smoke: Gluster Build System 
Reviewed-by: Manikandan Selvaganesh 
CentOS-regression: Gluster Build System 
Reviewed-by: Raghavendra G 
Reviewed-by: Atin Mukherjee