glusterfs.git/cli/src/cli-cmd-volume.c, branch v3.12.5

cli: Fixed a use_after_free

2018-01-10T06:56:27+00:00

gf_event in cli_cmd_volume_create_cbk was accessing
memory that had already been freed.

> Change-Id: I447c939fa9b31e18819a62c3b356c14cca390787
> BUG: 1530910
> Signed-off-by: N Balachandran 
(cherry picked from commit fa903173540df5b82c295a8f7b24848098e49a41)

Change-Id: I447c939fa9b31e18819a62c3b356c14cca390787
BUG: 1531372
Signed-off-by: N Balachandran

cli: remove summary option from heal info command

2017-12-01T04:49:28+00:00

commit c49fcf570439e47a5e1224436bbaf3f8dd580105 was a straight forward backport
from its corresponding master patch but in doing so, also added the 'summary'
option to the CLI. The heal info summary command is present only in
glusterfs-3.13. So remove it from the CLI in 3.12

Change-Id: Idb742f0b9752726c94619c0528fe792e4f5134fd
BUG: 1518061
Signed-off-by: Ravishankar N 
Reported-by: Shubhendu Tripathi

cli: gluster help changes

2017-11-08T06:14:38+00:00

gluster cli help now shows only the top level
help commands. gluster  help will now show
help commands for .

Change-Id: I263f53a0870d80ef4cfaad455fdaa47e2ac4423b
BUG: 1509786
> BUG: 1474768
> Signed-off-by: N Balachandran 
(cherry picked from commit 89dc54f50c9f800ca4446ea8fe736e4860588845)
Signed-off-by: N Balachandran

cli/afr: gluster volume heal info "healed" command output is not appropriate

2017-10-11T10:02:57+00:00

Problem: "gluster volume heal info [healed] [heal-failed]" command
          output on terminal is not appropriate in case of down any volume.

Solution: To make message more appropriate change the condition
          in function "gd_syncop_mgmt_brick_op".

Test : To verify the fix followed below procedure
       1) Create 2*3 distribute replicate volume
       2) set self-heal daemon off
       3) kill two bricks (3, 6)
       4) create some file on mount point
       5) bring brick 3,6 up
       6) kill other two brick (2 and 4)
       7) make self heal daemon on
       8) run "gluster v heal "

Note: After apply the patch options (healed | heal-failed) will deprecate
      from command line.

> BUG: 1388509
> Change-Id: I229c320c9caeb2525c76b78b44a53a64b088545a
> Signed-off-by: Mohit Agrawal 
> (Cherry pick from commit d1f15cdeb609a1b720a04a502f7a63b2d3922f41)

BUG: 1500662
Change-Id: I229c320c9caeb2525c76b78b44a53a64b088545a
Signed-off-by: Mohit Agrawal

events : Add brick list in EVENT_VOLUME_CREATE

2017-09-28T20:56:21+00:00

>Reviewed-on: https://review.gluster.org/18306
>Reviewed-by: Prashanth Pai 
>Smoke: Gluster Build System 
>Reviewed-by: Aravinda VK 
>CentOS-regression: Gluster Build System 
>(cherry picked from commit f6775423d7fbe71fe35e6154388e77aae2e264ad)

Change-Id: Ibf87ae5ca57f9d27c036f329a30c8f81b51c52bf
BUG: 1491292
Signed-off-by: Atin Mukherjee

tier: separation of attach-tier from add-brick

2017-08-04T20:34:03+00:00

PROBLEM: Both attach tier and add brick have the same RPC
and set of code. This becomes a hurdle while tring to implement
add brick on a tiered volume.

FIX: This patch separates the add brick and attach tier
giving them separate RPCs.

>Change-Id: Iec57e972be968a9ff00b15b507e56a4f6dc398a2
>BUG: 1376326
>Signed-off-by: hari gowtham 
>Reviewed-on: https://review.gluster.org/15503
>Smoke: Gluster Build System 
>Tested-by: hari gowtham 
>Reviewed-by: Samikshan Bairagya 
>CentOS-regression: Gluster Build System 

Signed-off-by: hari gowtham 
Change-Id: Iec57e972be968a9ff00b15b507e56a4f6dc398a2
BUG: 1478276
Reviewed-on: https://review.gluster.org/17974
Smoke: Gluster Build System 
Tested-by: hari gowtham 
Reviewed-by: Shyamsundar Ranganathan 
CentOS-regression: Gluster Build System

cli: error out incomplete CLI commands

2017-07-31T17:29:29+00:00

cli_cmd_bricks_parse () & cli_cmd_volume_remove_brick_parse () were not
handling the the error cases where the command is incomplete with
missing brick details which could lead to glusterd crashes.

Credit : george.lian@nokia.com

>Reviewed-on: https://review.gluster.org/17870
>Smoke: Gluster Build System 
>CentOS-regression: Gluster Build System 
>Reviewed-by: Jeff Darcy 
>(cherry picked from commit c136024613c697fec87aaff3a070862b92c57977)

Change-Id: Ia6303457a2aa279465aa75d4e1cfcc948893d5de
BUG: 1475641
Signed-off-by: Atin Mukherjee 
Reviewed-on: https://review.gluster.org/17892
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Shyamsundar Ranganathan

cli: add 'all' option in gluster v get cli usage

2017-06-06T11:31:48+00:00

Change-Id: If216b13b7f9072f875eb2c5019d3b50b8bf3313e
BUG: 1458582
Signed-off-by: Atin Mukherjee 
Reviewed-on: https://review.gluster.org/17460
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Samikshan Bairagya

glusterd: Make reset-brick work correctly if brick-mux is on

2017-05-10T18:58:21+00:00

Reset brick currently kills of the corresponding brick process.
However, with brick multiplexing enabled, stopping the brick
process would render all bricks attached to it unavailable. To
handle this correctly, we need to make sure that the brick process
is terminated only if brick-multiplexing is disabled. Otherwise,
we should send the GLUSTERD_BRICK_TERMINATE rpc to the respective
brick process to detach the brick that is to be reset.

Change-Id: I69002d66ffe6ec36ef48af09b66c522c6d35ac58
BUG: 1446172
Signed-off-by: Samikshan Bairagya 
Reviewed-on: https://review.gluster.org/17128
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Atin Mukherjee

Fix 'flush' type, coverity warning

2017-05-10T12:34:00+00:00

As getchar returna a int, (which is 4 bytes on most
common platforms, and at least 2 bytes), and char being often
1 byte, the conversion would lose information, hence
the warning.

Change-Id: I5b0b39c636ff49ef5c15d51a7f798e21635eca06
BUG: 789278
Signed-off-by: Michael Scherer 
Reviewed-on: https://review.gluster.org/17193
Tested-by: Michael Scherer 
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
Reviewed-by: Prashanth Pai 
CentOS-regression: Gluster Build System 
Reviewed-by: Zhou Zhengping 
Reviewed-by: Jeff Darcy