glusterfs.git/cli/src/cli-cmd-system.c, branch v4.1.3

cli: Fixed coverity issue in cli-cmd-system.c

2017-12-20T15:44:22+00:00

This patch adds a missing check of the return value of strtok_r()
and returns an error if it's NULL.

It also fixes a couple of leaks.

Change-Id: Ib15d6f843516e44c3bd8790a2e3ad936e357f6d4
BUG: 789278
Signed-off-by: Xavier Hernandez

cli: Fix double unref of dict

2016-08-31T12:10:56+00:00

Problem: `gluster system:: uuid get` hangs due to double unref of dict.

Fix:
Remove the unnecessary unref in cli_cmd_uuid_get_cbk(). In the said
function, if calling proc->fn() is sucessful, the dict is automatically
unrefed in its cbk as a part of cli_local_wipe(). If calling proc->fn() fails,
then CLI_STACK_DESTROY() takes care of the unref.

Change-Id: Ib656d200f14a27415b36794a0bdadfe36b0d5306
BUG: 1371775
Signed-off-by: Ravishankar N 
Reviewed-on: http://review.gluster.org/15368
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Smoke: Gluster Build System 
Reviewed-by: Atin Mukherjee

dict: Don't expose get_new_dict/dict_destroy

2016-07-26T06:47:33+00:00

get_new_dict/dict_destroy is causing confusion where, dict_new/dict_destroy or
get_new_dict/dict_unref are used instead of dict_new/dict_unref.

Change-Id: I4cc69f5b6711d720823395e20fd624a0c6c1168c
BUG: 1296043
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.org/13183
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
NetBSD-regression: NetBSD Build System 
Reviewed-by: Jeff Darcy 
Reviewed-by: Krutika Dhananjay

cli : 'gluster volume help' output sorted alphabetically

2015-10-28T20:42:32+00:00

'gluster volume help' output is not sorted alphabetically.
This makes little harder for the user to search or get to know of
few gluster volume commands usage just from gluster cli.

Change-Id: I855da2e4748a5c2ff3be319c50fa9548d676ee8a
BUG: 1242894
Signed-off-by: Mohamed Ashiq 
Reviewed-on: http://review.gluster.org/11663
Tested-by: Gluster Build System 
Reviewed-by: Manikandan Selvaganesh 
Reviewed-by: Anand Nekkunti

build: do not #include "config.h" in each file

2015-05-29T12:43:17+00:00

Instead of including config.h in each file, and have the additional
config.h included from the compiler commandline (-include option).

When a .c file tests for a certain #define, and config.h was not
included, incorrect assumtions were made. With this change, it can not
happen again.

BUG: 1222319
Change-Id: I4f9097b8740b81ecfe8b218d52ca50361f74cb64
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/10808
Tested-by: Gluster Build System 
Tested-by: NetBSD Build System
Reviewed-by: Kaleb KEITHLEY 
Reviewed-by: Pranith Kumar Karampuri

cli : glusterd getspec usage correction

2014-07-30T09:31:34+00:00

gluster system getspec asks to input volume-id instead of volume name

Change-Id: I0baef9c937fc8948477aa65c8f98916b28c1e484
BUG: 1121870
Signed-off-by: Atin Mukherjee 
Reviewed-on: http://review.gluster.org/8342
Tested-by: Gluster Build System 
Reviewed-by: Krishnan Parthasarathi 
Tested-by: Krishnan Parthasarathi

glusterd/cli changes for distributed geo-rep

2013-07-26T20:19:18+00:00

Commands:
gluster system:: execute gsec_create
gluster volume geo-rep   create [push-pem] [force]
gluster volume geo-rep   start [force]
gluster volume geo-rep   stop [force]
gluster volume geo-rep   delete
gluster volume geo-rep   config
gluster volume geo-rep   status

The geo-replication is distributed. The session will be created, and
gsyncd will be spawned on all relevant nodes, instead of only one
node.

geo-rep: Collecting status detail related data

Added persistent store for saving information about
TotalFilesSynced, TotalSyncTime, TotalBytesSynced

Changes in the status information in socket:
Existing(Ex):
FilesSynced=2;BytesSynced=2507;Uptime=00:26:01;

New(Ex):
FilesSynced=2;BytesSynced=2507;Uptime=00:26:01;SyncTime=0.69978;
TotalSyncTime=2.890044;TotalFilesSynced=6;TotalBytesSynced=143640;

Persistent details stored in
/var/lib/glusterd/geo-replication/${mastervol}/${eSlave}-detail.status

Change-Id: I1db7fc13ffca2e415c05200b0109b1254067f111
BUG: 847839
Original Author: Avra Sengupta 
Original Author: Venky Shankar 
Original Author: Aravinda VK 
Original Author: Amar Tumballi 
Original Author: Csaba Henk 
Signed-off-by: Avra Sengupta 
Reviewed-on: http://review.gluster.org/5132
Reviewed-by: Vijay Bellur 
Tested-by: Vijay Bellur

glusterd: Add a cmd for getting uuid of local node

2013-06-10T19:20:05+00:00

Usage: gluster system:: uuid get

This is needed since we generate uuid of a node in a lazy manner. ie, we
generate a uuid for the node only on the first volume or peer operation,
when the node needs an external identity.  With this command, we can
force[1] the uuid generation, without a volume or peer operation performed.

[1]: Querying for uuid (or uuid get), forces uuid to come into
existence.

Change-Id: I62c8b6754117756aa4d773dd48af4ddeb1a1d878
BUG: 971661
Signed-off-by: Krishnan Parthasarathi 
Reviewed-on: http://review.gluster.org/5175
Tested-by: Gluster Build System 
Reviewed-by: Kaushal M

glusterd, cli: implement gluster system uuid reset command

2012-11-29T00:28:55+00:00

A commonly faced problem among glusterfs users is: after a fresh
installation of glusterfs in a virtual machine, the VM image is
cloned to make multiple instances of the server. This breaks
glusterd because right after glusterfs installation on the first
boot glusterd would have created the node UUID and this gets
inherited into the clone. The result is wierd behavior at the time
of peer probe where glusterd does not (yet) deal with UUID
collisions in a user friendly way.

To handle it gluster peer reset command is implemented which upon
execution changes the uuid of local glusterd.

Change-Id: If207dd2ad93ab94ef1a3253f409c21c442975f87
BUG: 811493
Signed-off-by: Raghavendra Bhat 
Reviewed-on: http://review.gluster.org/3637
Reviewed-by: Pranith Kumar Karampuri 
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

All: License message change

2012-09-13T20:19:37+00:00

License message changed for server-side, dual license GPLV2 and LGPLv3+.

Change-Id: Ia9e53061b9d2df3b3ef3bc9778dceff77db46a09
BUG: 852318
Signed-off-by: Varun Shastry 
Reviewed-on: http://review.gluster.org/3940
Tested-by: Gluster Build System 
Reviewed-by: Kaleb KEITHLEY 
Reviewed-by: Anand Avati