glusterfs.git/cli/src/cli-cmd-parser.c, branch v3.7.19

geo-rep/cli: Validate Checkpoint label

2016-12-01T05:55:47+00:00

Checkpoint command accepts "now" or any other Time
in "%Y-%m-%d %H:%M:%S" format as label.

Validation added with this patch for the input label. Checkpoint set
will fail for invalid label.

> Reviewed-on: http://review.gluster.org/15721
> Smoke: Gluster Build System 
> CentOS-regression: Gluster Build System 
> NetBSD-regression: NetBSD Build System 
> Reviewed-by: Saravanakumar Arumugam 
> Reviewed-by: Kotresh HR 

BUG: 1395628
Change-Id: I23518c151ab4b294f64cae3b78baaacb3d8f7b82
Signed-off-by: Aravinda VK 
(cherry picked from commit 8a1993b32f476765f9f5c9294e7c3f2ae75198a0)
Reviewed-on: http://review.gluster.org/15856
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Smoke: Gluster Build System 
Reviewed-by: Kotresh HR 
Reviewed-by: Saravanakumar Arumugam

georep: add reset-sync-time option for session delete

2016-07-21T10:04:23+00:00

Set the stime xattr at all the brick roots to (0,0) if the argument
reset-sync-time has been provided on the command-line.
To avoid testing against directory specific stime, the remote
stime is assumed to be minus_infinity, if the root directory
stime is set to (0,0), before the directory scan begins.
This triggers a full volume resync to slave in the case of a
geo-rep session recreation with the same master-slave volume
pair.

Command synopsis:
gluster volume geo-replication  :: delete \
    [reset-sync-time]

Update gluster cli man page to include new sub-command reset-sync-time.

Change-Id: Ie4ce03b9425ed9bb81eda8681058c0fc6f990948
BUG: 1357772
Signed-off-by: Milind Changire 
Reviewed-on: http://review.gluster.org/14051
Reviewed-by: Kotresh HR 
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Aravinda VK 
(cherry picked from commit 70fd68d94f768c098b3178c151fa92c5079a8cfd)
Reviewed-on: http://review.gluster.org/14952

features/bitrot: Option to set scrub interval to a minute

2016-07-15T13:42:43+00:00

Backport of http://review.gluster.org/#/c/14836/

Bitrot scrub-frequency supports "hourly|daily|weekly|biweekly|monthly".
But it is painful for testing as minimum  scrub-interval is an hour
Hence introducing a scrub interval of minute to ease testing.
It is intentionally not exposed in bitrot command help as it is
only for testing.

e.g.,
gluster vol bitrot  scrub-frequency minute

Change-Id: I155a65298d3fad5ae9e529d9c7d4b0d25fa297c0
BUG: 1354425
Signed-off-by: Kotresh HR 
(cherry picked from commit 7df1174f7bed2a00631cf17201f5217a053afeb1)
Reviewed-on: http://review.gluster.org/14887
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Jeff Darcy

cli: fix crash in arbiter keyword parsing

2016-06-28T06:37:07+00:00

Backport of http://review.gluster.org/#/c/14738/

A negative case like `gluster volume create volname arbiter 3 /bricks{1..3}`
must not crash. 'arbiter' keyword is valid only for (3 way) replica volumes.

The .t that is added will crash and create a core *without* the fix when
run but will still pass all TESTs. Since the regression framework fails
the .t if it creates a core,  we can consider it a valid test 'that
fails without the fix'.

Change-Id: Ie2d7ced66025ea3617d30f6f823b22401e6d2fde
BUG: 1348056
Signed-off-by: Ravishankar N 
(cherry picked from commit b5c492dfea2d2e2075aa88d7153fba57b06e739d)
Reviewed-on: http://review.gluster.org/14765
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Atin Mukherjee

afr: add mtime based split-brain resolution to CLI

2016-04-04T17:33:56+00:00

Backport of http://review.gluster.org/#/c/13828/

Extended the CLI to include support for split-brain resolution based on
mtime. The command syntax is:

$:gluster volume heal  split-brain latest-mtime 

where  can be either the full file name as seen from the root of the
volume (or) the gfid-string representation of the file.

Change-Id: I7a16f72ff1a4495aa69f43f22758a9404e958b4f
BUG: 1321748
Signed-off-by: Ravishankar N 
Reviewed-on: http://review.gluster.org/13838
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
Reviewed-by: Anuradha Talur 
CentOS-regression: Gluster Build System 
Reviewed-by: Pranith Kumar Karampuri

cli: Do not remove whitespace if key is user.* in volume set

2016-03-24T09:23:16+00:00

Backport of http://review.gluster.org/#/c/13669

setting any user.* option can have multiple words in the key and hence skip the
process of trimming whitespaces.

Change-Id: Ia295428d7cda55e5470fef668325bea497f2333d
BUG: 1320821
Signed-off-by: Atin Mukherjee 
Reviewed-on: http://review.gluster.org/13669
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
NetBSD-regression: NetBSD Build System 
Reviewed-by: Kaushal M 
Reviewed-on: http://review.gluster.org/13821

snapshot/cli: Keep the dict keys uniform

2016-03-22T07:52:32+00:00

    Backport of http://review.gluster.org/#/c/13677/

snapshot info was using a different dictionary key
as compared to other snapshot commands. This was
throwing a recurring error log in cli.log

Change-Id: I9eb9a4541c10a45ec7673a23c89c85a7dce9f3ec
BUG: 1317363
Signed-off-by: Avra Sengupta 
Reviewed-on: http://review.gluster.org/13677
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Rajesh Joseph 
(cherry picked from commit 1af963dc753d97efb3cbe3e5179a2148c41c9a7d)
Reviewed-on: http://review.gluster.org/13691

cli : provide prompt for the nfs-ganesha disable cli

2016-02-22T12:46:11+00:00

Presently, when we are executing the command "gluster nfs-ganesha disable",
the disable of nfs-ganesha cluster starts working whereas, in some cases
the user may not want to disable the cluster. So we shall let him know by
giving a prompt to let him say "yes or no" for going ahead with the disable
procedures.

Change-Id: I860dad1479f7ca16bc2736b8056b609473bef65f
BUG: 1289031
Signed-off-by: Jiffin Tony Thottan 
Reviewed-on: http://review.gluster.org/13450
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Kaleb KEITHLEY 
Reviewed-by: Niels de Vos

cli/quota : quota is not enforcing when limit is set to 0

2016-02-11T06:11:06+00:00

When limit value is set to 0, quota assumes that limit is not
set and is not enforcing currently. The patch fixes this issue by
restricting the user from setting limit value = 0.

        Backport of http://review.gluster.org/#/c/13309/

> Change-Id: I316653165cd9766600f95b5f23e5b8abcc2b41e7
> BUG: 1302554
> Signed-off-by: Manikandan Selvaganesh 

Change-Id: I83623cba54873f27bd65d5d6d85b1f8e9d895f55
BUG: 1306136
Signed-off-by: Manikandan Selvaganesh 
Reviewed-on: http://review.gluster.org/13417
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Raghavendra G

all: reduce "inline" usage

2016-01-18T09:02:34+00:00

There are three kinds of inline functions: plain inline, extern inline,
and static inline.  All three have been removed from .c files, except
those in "contrib" which aren't our problem.  Inlines in .h files, which
are overwhelmingly "static inline" already, have generally been left
alone.  Over time we should be able to "lower" these into .c files, but
that has to be done in a case-by-case fashion requiring more manual
effort.  This part was easy to do automatically without (as far as I can
tell) any ill effect.

In the process, several pieces of dead code were flagged by the
compiler, and were removed.

backport of Change-Id: I56a5e614735c9e0a6ee420dab949eac22e25c155,
http://review.gluster.org/11769, BUG: 1245331

Change-Id: Iba1efb0bc578ea4a5e9bf76b7bd93dc1be9eba44
BUG: 1283302
Signed-off-by: Kaleb S KEITHLEY 
Reviewed-on: http://review.gluster.org/12646
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Niels de Vos