glusterfs.git/api, branch v3.5.6

api: versioned symbols in libgfapi.so for compatibility

2015-02-09T12:16:53+00:00

Use versioned symbols to keep libgfapi at libgfapi.so.0.0.0

Some nits uncovered:

+ there are a couple functions declared that do not have an
  associated definition, e.g. glfs_truncate(), glfs_caller_specific_init()

+ there are five private/internal functions used by heal/src/glfsheal
  and the gfapi master xlator (glfs-master.c): glfs_loc_touchup(),
  glfs_active_subvol(), and glfs_subvol_done(), glfs_init_done(),
  glfs_resolve_at(); which are not declared in glfs.h;

+ for this initial pass at versioned symbols, we use the earliest version
  of all public symbols, i.e. those for which there are declarations in
  glfs.h or glfs-handles.h.
  Further investigation as we do backports to 3.6, 3.4, and 3.4
  will be required to determine if older implementations need to
  be preserved (forward ported) and their associated alias(es) and
  symbol version(s) defined.

FWIW, we should consider linking all of our libraries with a map, it'll
result in a cleaner ABI. Perhaps something for an intern to do or a
Google Summer of Code project.

Change-Id: I513b9aad9c5fd7d8b34ff33acac35f37b6baaab6
BUG: 1160711
Signed-off-by: Kaleb S. KEITHLEY 
Reviewed-on: http://review.gluster.org/9056
Tested-by: Gluster Build System 
Reviewed-by: Niels de Vos

gfapi: In glfs_set_volfile_server() remove the port number check.

2014-07-31T07:50:47+00:00

The documentation for glfs_set_volfile_server() api says that the
port zero is a valid value. Specifying 0 uses the default port
number GF_DEFAULT_BASE_PORT. Hence removing the check for port being
zero.

Master branch commit 6567d141c1b0112acb35e711371ae5a879fc645a:
> Change-Id: I942a7fe54a418231a438ab67756537df8f28d2de
> BUG: 1084964
> Signed-off-by: Poornima G 
> Reviewed-on: http://review.gluster.org/7409
> Reviewed-by: Raghavendra Talur 
> Reviewed-by: Krishnan Parthasarathi 
> Tested-by: Gluster Build System 
> Reviewed-by: Vijay Bellur 

Change-Id: I942a7fe54a418231a438ab67756537df8f28d2de
BUG: 1124728
Signed-off-by: Poornima G 
Reviewed-on: http://review.gluster.org/8374
Reviewed-by: Niels de Vos 
Tested-by: Gluster Build System

rpcsvc: Validate RPC procedure number before fetch

2014-07-08T10:36:18+00:00

While accessing the procedures of given RPC program in,
rpcsvc_get_program_vector_sizer(), It was not checking boundary
conditions which would cause buffer overflow and subsequently SEGV.

Make sure rpcsvc_actor_t arrays have numactors number of actors.

FIX:
Validate the RPC procedure number before fetching the actor.

Upstream main review: http://review.gluster.org/7726

BUG: 1096020

Change-Id: Iaf207ee976cb56fa9a554ec82c9eab36d3b289ed
Signed-off-by: Santosh Kumar Pradhan 
Reviewed-on: http://review.gluster.org/8228
Tested-by: Gluster Build System 
Reviewed-by: Niels de Vos

NetBSD build fixes for release-3.5

2014-06-08T09:18:13+00:00

1) Make sure __THROW is definedThis is a backport of I6e7cb1eb59b84988e155e9a8b696e842b7ff8f7f

2) include  before  so that XDR is defined
This was fixed in master within I20193d3f8904388e47344e523b3787dbeab044acbut weonly pull up

3) NetBSD's gettext is in libintl, hence search it at configure time
This is a backport of I651a74fe49c3f087fe135dab3453fd5b18b4268a

4) include  to have WEXITSTATUS defined
This problem does not exist in master as WEXITSTATUS is not used

5) Do not define popcountl() on NetBSD as it is in 
This is a backport of I4428a88b1e0d7c5f6740022861ffe230dbbd84bd

BUG: 764655
Change-Id: Ieea5a2a627e2b7930525d6c525f1602073574a97
Signed-off-by: Emmanuel Dreyfus 
Reviewed-on: http://review.gluster.org/7925
Reviewed-by: Kaleb KEITHLEY 
Reviewed-by: Niels de Vos 
Tested-by: Gluster Build System

libgfapi: Added Handle-based ops to get/set/remove extended attributes in the libgfapi.

2014-05-22T09:33:49+00:00

Cherry picked from commit Change-Id: I1a8e666018d7b93e0bba2d9882935681da909980
and Change-Id: I62f63da37edf722d6d79c75f72ee7403e93e4936

> BUG: 1089414
> Signed-off-by: Soumya Koduri 
> Reviewed-on: http://review.gluster.org/7308
> Reviewed-by: Vijay Bellur 
> Tested-by: Vijay Bellur 

This patch differs a bit from its earlier master patch -
* 'DECODE_SYNCOP_ERR' macro is not defined in this code branch.
So lines where this macro is used are skipped.
* 'syncop_removexattr(..)' definition differs from the one in the master branch.

BUG: 1099878
Change-Id: I1e9cce4efeec038b9736065d39887c35752caead
Signed-off-by: Soumya Koduri 
Reviewed-on: http://review.gluster.org/7825
Reviewed-by: Raghavendra G 
Tested-by: Gluster Build System 
Reviewed-by: Niels de Vos

libgfapi: Added support to fetch volume info from glusterd and store in glfs object.

2014-05-12T15:14:52+00:00

Defined new APIs in the libgfapi module, given a glfs object,
 * to send handshake RPC call to glusterd process to fetch UUID of the volume
 * store it in the glusterfs_context linked to the glfs object.
 * to parse UUID from its cannonical string format into 16-byte array
   before sending it to the libgfapi users.

Defined a RPC call in glusterd which can be used to query volume related
info by other processes using 'clnt_handshake_procs'.

Note - Currently this RPC call to glusterd process is used only to fetch UUID.
But it can be extended to get other volume related structures as well.

In addition to the above, defined a new variable to keep track of such handshake
RPCs still in progress to make sure all the corresponding RPC callbacks have been
processed before libgfapi returns the glfs object initialized.

Also bumping up the GFAPI current version number since there is a new API
"glfs_get_volume_id" defined and exposed by libgfapi as part of these changes.

Cherry picked from commit 5adb10b9ac1c634334f29732e062b12d747ae8c5:
> Change-Id: I303f76d7177d32d25bdb301b1dbcf5cd73f42807
> BUG: 1095775
> Signed-off-by: Soumya Koduri 
> Reviewed-on: http://review.gluster.org/7218
> Reviewed-by: Anand Avati 
> Reviewed-by: Harshavardhana 
> Tested-by: Gluster Build System 
> Reviewed-by: Vijay Bellur 

This change differs a little from the patch in the master branch:
- libgfapi in 3.5 does not have glfs_get_volfile(), so there were some
  merge conflicts resolved,
- libgfapi in 3.5 is not versioned, the configure.ac changes related to
  the versioning have been skipped,
- in the master branch only the XDR .x files are available, release-3.5
  requires a manual re-generation of the relates .h and .c files.

Change-Id: I52c32d0e69a52a7f4285f74164bca6fd83c4f3b3
BUG: 1095775
Signed-off-by: Soumya Koduri 
Reviewed-on: http://review.gluster.org/7741
Reviewed-by: Niels de Vos 
Tested-by: Niels de Vos

gfapi: glfs_set_volfile_server() now entertains multiple calls

2014-05-10T02:06:36+00:00

Backport from - http://review.gluster.org/7317

Previous API:

glfs_set_volfile_server (..., const char *host, ...) - single call

New API's:

glfs_set_volfile_server (..., const char *host1, ...)
glfs_set_volfile_server (..., const char *host2, ...)

Multiple calls to this function with different volfile servers,
port or transport-type would create a list of volfile servers
which would be polled during `volfile_fetch_attempts()`

glfs_unset_volfile_server (..., const char *host, ...) to remove
a server from the list (this is provided for future usage)

>> Change-Id: I313efbd3efbd0214e2a71465f33195788df406cc
>> BUG: 986429
>> Signed-off-by: Harshavardhana 
>> Reviewed-on: http://review.gluster.org/7317
>> Tested-by: Gluster Build System 
>> Reviewed-by: Niels de Vos 
>> Reviewed-by: Anand Avati 

Change-Id: If0020f6b8775bdbe987563247c83d59a2d3744ad
BUG: 986429
Signed-off-by: Harshavardhana 
Reviewed-on: http://review.gluster.org/7384
Tested-by: Gluster Build System 
Reviewed-by: Niels de Vos

features/glupy: Rename Glupy python module to avoid namespace conflict

2014-03-24T17:31:55+00:00

* Rename gluster.py to glupy.py to avoid namespace conflict (#1018619)
* Move the main Glupy files into glusterfs-extra-xlators rpm
* Move the Glupy Translator examples into glusterfs-devel rpm

Backport of: http://review.gluster.org/#/c/6979/

Change-Id: Ie9b71b56502f8e98c527ade381c918446bc7f022
BUG: 1018619
Signed-off-by: Justin Clift 
Reviewed-on: http://review.gluster.org/7316
Tested-by: Gluster Build System 
Reviewed-by: Kaleb KEITHLEY 
Reviewed-by: Jeff Darcy

gfapi: Closed the logfile fd and initialize to NULL in glfs_fini

2014-01-21T04:22:47+00:00

Backport of http://review.gluster.org/6552

Currently if logfile is closed and other threads call gf_log
after glfs_fini() is executed, it may lead to memory corruption.
Adding gf_log_fini() which closes the logfile and initializes
the logfile to NULL, thus any further logging happens to stderr.
Also added gf_log_globals_fini() which should be filled in the
future to release all the logging resources.

BUG: 1030228
Change-Id: I90f7fb744b05bc6bd14c61fe143c0814896991e2
Signed-off-by: Poornima G 
Reviewed-on: http://review.gluster.org/6552
Reviewed-on: http://review.gluster.org/6731
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

libgfapi : Fixing some NULL pointer dereferencing issues.

2014-01-14T08:20:43+00:00

1. Fixing dereferencing null pointer "gio"
2. Checking "frame" before calling STACK_DESTROY (frame->root)

Backport of patch : http://review.gluster.org/#/c/6313/

Change-Id: If2ce8804a8e9f3f99f71a8c0d13900afb5635072
Signed-off-by: Lalatendu Mohanty 
Reviewed-on: http://review.gluster.org/6313
Reviewed-by: Santosh Pradhan 
Tested-by: Gluster Build System 
Reviewed-by: Shyamsundar Ranganathan 
Reviewed-by: Raghavendra Talur 
Reviewed-by: Vijay Bellur 
Signed-off-by: Lalatendu Mohanty 
Reviewed-on: http://review.gluster.org/6688