glusterfs.git/api/src, branch v3.7.13

gfapi: update count when glfs_buf_copy is used

2016-07-07T09:01:01+00:00

Backport of http://review.gluster.org/#/c/14854

glfs_buf_copy collates all iovecs into a iovec with count=1. If
gio->count is not updated it will lead to dereferencing of invalid
address.

Change-Id: I7c58071d5c6515ec6fee3ab36af206fa80cf37c3
BUG: 1352482
Signed-off-by: Raghavendra Talur 
Signed-off-by: Poornima G 
Reported-By: Lindsay Mathieson 
Reported-By: Dmitry Melekhov 
Reported-By: Tom Emerson 
Reviewed-on: http://review.gluster.org/14859
Smoke: Gluster Build System 
Reviewed-by: Prashanth Pai 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System

gfapi/handleops: Avoid using glfd during create

2016-07-03T11:16:01+00:00

To avoid leaking glfd while creating a file using handleops and
since application shall not be interested in it, use the 'fd'
object directly which can be un'refed post create.

This is backport of below mainline patch -
  http://review.gluster.org/14532

> Change-Id: I119874ffb63fb4aa18f846ba1fdbe77874b66a54
> BUG: 1339553
> Signed-off-by: Soumya Koduri 
> Signed-off-by: Jiffin Tony Thottan 
> Reviewed-on: http://review.gluster.org/14532
> NetBSD-regression: NetBSD Build System 
> Reviewed-by: Niels de Vos 
> CentOS-regression: Gluster Build System 
> Tested-by: Gluster Build System 
> Smoke: Gluster Build System 
(cherry picked from commit 763ed1017b0011934ad2414d7396c46e528ea5b3)

Change-Id: I119874ffb63fb4aa18f846ba1fdbe77874b66a54
BUG: 1351877
Signed-off-by: Soumya Koduri 
Reviewed-by: Kaleb S KEITHLEY 
Reviewed-on: http://review.gluster.org/14840
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Niels de Vos 
Smoke: Gluster Build System

gfapi : check the value "iovec" in glfs_io_async_cbk only for read

2016-06-29T12:47:19+00:00

The glfs_io_async_cbk() is called from the cbk of all the async ops
such as write, read, fsync, ftruncate. In all other cases, expect for
read the value for "iovec" is NULL. From the code, glfs_io_async_cbk
checks the value in common routine which may end up in failures.

Thanks Joe Julian for finding issue and suggesting the fix.

Cherry picked from commit 61d72b3d91f2655b04de4ef29262f738a8cf7369:
> Change-Id: I0be0123da68f9d8fbb5d94ede2d45566a9add6a5
> BUG: 1349276
> Signed-off-by: Jiffin Tony Thottan 
> Reported-by: Joe Julian 
> Reviewed-on: http://review.gluster.org/14779
> Reviewed-by: Niels de Vos 
> Smoke: Gluster Build System 
> Tested-by: Kaleb KEITHLEY 
> NetBSD-regression: NetBSD Build System 
> CentOS-regression: Gluster Build System 
> Reviewed-by: Joe Julian 

Change-Id: I0be0123da68f9d8fbb5d94ede2d45566a9add6a5
BUG: 1350880
Reported-by: Joe Julian 
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/14822
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
Reviewed-by: Kaleb KEITHLEY 
CentOS-regression: Gluster Build System 
Reviewed-by: jiffin tony Thottan

gfapi/upcall: Use GF_CALLOC while allocating variables

2016-05-25T11:39:32+00:00

In 'glfs_h_poll_cache_invalidation', use GF_CALLOC to allocate
'up_inode_arg' to set memory accounting which is used/referred when
freeing the same variable in case of any erros.

This is backport of below mainline fix -
         http://review.gluster.org/14521

Change-Id: I365e114fa6d7abb292dacb6fc702128d046df8f8
BUG: 1339226
Signed-off-by: Soumya Koduri 
Reviewed-on: http://review.gluster.org/14522
NetBSD-regression: NetBSD Build System 
Reviewed-by: Niels de Vos 
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System

gfapi: fill iatt in readdirp_cbk if entry->inode is null

2016-05-24T05:48:33+00:00

If any of dirent have inode as null in readdirp_cbk, which indicates
that the stat information is not valid. So for such entries, we send
explicit lookup to fill the stat information.

Backport of>
>Change-Id: I0604bce34583db0bb04b5aae8933766201c6ddad
>BUG: 1330567
>Signed-off-by: Mohammed Rafi KC 
>Reviewed-on: http://review.gluster.org/14079
>NetBSD-regression: NetBSD Build System 
>Smoke: Gluster Build System 
>CentOS-regression: Gluster Build System 
>Reviewed-by: Niels de Vos 

(cherry picked from commit 9423bdeed169076ebedd9af40b52aaac58c9839e)

Change-Id: I90a218c78d5544a3b49b29079c64a8b76e7939df
BUG: 1331263
Signed-off-by: Mohammed Rafi KC 
Reviewed-on: http://review.gluster.org/14109
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
NetBSD-regression: NetBSD Build System 
Reviewed-by: Rajesh Joseph

gfapi: set need_lookup flag on response list

2016-05-24T05:47:07+00:00

We set need_lookup flag for entries returned by readdirp
to force lookup. Currently we are setting on the previously
stored list, rather than response list returned by readdirp.

This patch will iterate over current list returned by readdirp
and will set need_lookup flag.

Back port of>
>Change-Id: Ibd6fcbc188f4c87f40ece7a9dcda27645401c240
>BUG: 1330476
>Signed-off-by: Mohammed Rafi KC 
>Reviewed-on: http://review.gluster.org/14073
>NetBSD-regression: NetBSD Build System 
>Reviewed-by: Niels de Vos 
>Reviewed-by: Rajesh Joseph 
>Smoke: Gluster Build System 
>CentOS-regression: Gluster Build System 

(cherry picked from commit 537557da59876536d33cd25a8ef485e7b5fe8849)


Change-Id: If7bc0f58e5b8fb261625dc5067a6d330d508ebb1
BUG: 1331264
Signed-off-by: Mohammed Rafi KC 
Reviewed-on: http://review.gluster.org/14098
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
NetBSD-regression: NetBSD Build System 
Reviewed-by: Rajesh Joseph

gfapi: clear loc.gfid when retrying after ESTALE

2016-05-13T05:52:46+00:00

If an ESTALE is returned as result of a revalidate lookup, it means the
previous gfid and inode are to be discarded and lookup has to be tried
as a fresh one. A fresh lookup should not have loc.gfid set. We were
creating a new inode and passing it down but not clearing loc.gfid.
This patch fixes that.

>Change-Id: Ib192ada0528b5fb5e49b4e2555f2bcab62710e2d
>BUG: 1334444
>Signed-off-by: Raghavendra Talur 
>Reviewed-on: http://review.gluster.org/14274
>Smoke: Gluster Build System 
>NetBSD-regression: NetBSD Build System 
>Reviewed-by: Niels de Vos 
>CentOS-regression: Gluster Build System 
>Reviewed-by: Pranith Kumar Karampuri 
>(cherry picked from commit b2f09e531029f573772a09572cee0f8e1855481b)

Change-Id: Ib192ada0528b5fb5e49b4e2555f2bcab62710e2d
BUG: 1334441
Signed-off-by: Raghavendra Talur 
Reviewed-on: http://review.gluster.org/14290
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Rajesh Joseph

libglusterfs/gfapi: set appropriate errno for inode_link failures

2016-05-11T14:36:33+00:00

We do not seem to be setting errno appropriately in case
of inode_link failures. This errno may be used by any application
(for eg., nfs-ganesha) to determine the error encountered. This
patch addresses the same.

This is backport of below mainline fix -
        http://review.gluster.org/14278

Change-Id: I674f747c73369d0597a9c463e6ea4c85b9091355
BUG: 1335016
Signed-off-by: Soumya Koduri 
Reviewed-on: http://review.gluster.org/14278
Reviewed-by: Niels de Vos 
Reviewed-by: jiffin tony Thottan 
Reviewed-by: Kaleb KEITHLEY 
Reviewed-on: http://review.gluster.org/14287
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System

gfapi: Fix a deadlock caused by graph switch while aio in progress

2016-05-06T13:24:40+00:00

RCA:
Currently async nature is achieved by submitting a syncop operation to
synctask threads. Consider a scenario where the graph switch is triggered,
the next write fop checks for the next available graph and sets
fs->migration_in_progess and triggers the migration of fds and other
things, which can cause some syncop_lookup operation. While this fop (on
synctask thread) is waiting for syncop_lookup to return, lets say there
are another 17 write async calls submitted, all these writes are blocked
waiting for fs->migration_in_progress to be unset, hence all the 16
synctask threads are blocked waiting for fs->migration_in_progress to be
unset. Now the syncop_lookup returns, but there are no synctask threads to
process the lookup_cbk. If this syncop_lookup doesn't return,
then fs->migration_in_progress can not be unset by the first fop.
Thus causing a deadlock.

To fix this deadlock, changing all the async APIs to use STACK_WIND,
instead of syntask to achieve async nature. glfs_preadv_async is already
implemented using STACK_WIND, now changing all the other async APIs
also to do the same.

This patch as such will not reduce the performance of async IO, the only
thing that can affect is that, in case of write, the buf passed by
application is copied onto iobuf in the same thread wheras before it
was being copied in synctask thread.

Since, the syncop + graph switch logic (lock across fops) is not a good
candidate for synctask, changing the async APIs to use STACK_WIND

Backport of http://review.gluster.org/#/c/14148/

Change-Id: Idf665cae0a8e27697fbfc5ec8d93a6d6bae3a4f1
BUG: 1333268
Signed-off-by: Poornima G 
Reviewed-on: http://review.gluster.org/14223
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Raghavendra Talur 
Reviewed-by: Rajesh Joseph 
Reviewed-by: Atin Mukherjee

gfapi/upcall: Ignore handle create failures

2016-05-03T22:07:21+00:00

In "glfs_h_poll_cache_invalidation", we need to send upcall only if there
is a corresponding inode entry in the gfapi inode table for that handle.

That's because the application will have reference to the inode as long as
it operates on any handle. That means the only case in which we cannot find
inode is when the application has closed the handle (either as part of unlink
or for any other purpose). But since it will have no more references and will
not be interested in any upcall event for that handle, we can safely ignore such
cases.

Note: This will affect only that particular applicaiton process/local libgfapi
client.

This is backport of the below mainline fix -
 http://review.gluster.org/14132

Change-Id: I9499cd9c284350d4a271e58f2a0966db65a7a61c
BUG: 1332433
Signed-off-by: Soumya Koduri 
Reviewed-on: http://review.gluster.org/14132
Reviewed-by: jiffin tony Thottan 
Reviewed-by: Kaleb KEITHLEY 
Reviewed-on: http://review.gluster.org/14181
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Smoke: Gluster Build System