glusterfs.git/api/src/glfs-internal.h, branch v3.8rc0

libgfapi: glfd close is not correctly handled for async fop

2016-02-11T05:46:30+00:00

There is chance that before the async fop is complete client can send
a close. libgfapi destroys glfd on close. Therefore it can lead to
crash or unexpected behaviour when the pening fop reaches libgfapi
layer. Currently we don't provide any api to cancel these outstanding
fops neither we check if the glfd is already closed or not.

Therefore as a fix provided refcount for glfd. Each fop (sync or async)
will take a ref and once the fop is complete it will unref the refcount.
We should not call the registered callback function if glfd is already
closed. To achieve this we maintain state of glfd so that we can safely
take a call if the fd is closed or not.

Change-Id: Ibe71b2225312db3f1be66b244fcf8826c70c357d
BUG: 1303995
Signed-off-by: Rajesh Joseph 
Reviewed-on: http://review.gluster.org/13340
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Shyamsundar Ranganathan 
NetBSD-regression: NetBSD Build System

api: Fix errno being set to EINVAL even on success

2016-01-05T15:41:10+00:00

BUG: 1289068
Change-Id: I7905ac70a537f23e1844c097a24eaa6cb762fb82
Signed-off-by: Prashanth Pai 
Reviewed-on: http://review.gluster.org/12909
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System 
Reviewed-by: jiffin tony Thottan 
Reviewed-by: Kaushal M 
Reviewed-by: Shyamsundar Ranganathan

libgfapi: non-default symbol version macros are incorrect

2015-08-19T16:29:13+00:00

default symbol versions are in form glfs_h_lookupat@@GFAPI_2.7.4,
versus old, non-default versions are in the form glfs_h_lookup@GFAPI_2.4.2

I.e. "@@" versus "@"

Change-Id: I88a6b129558c0b3a6064de7620b3b20425e80bc9
BUG: 1254863
Signed-off-by: Kaleb S. KEITHLEY 
Reviewed-on: http://review.gluster.org/11955
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System 
Reviewed-by: Niels de Vos

rpc: add owner xlator argument to rpc_clnt_new

2015-08-13T06:12:50+00:00

The @owner argument tells RPC layer the xlator that owns
the connection and to which xlator THIS needs be set during
network notifications like CONNECT and DISCONNECT.

Code paths that originate from the head of a (volume) graph and use
STACK_WIND ensure that the RPC local endpoint has the right xlator saved
in the frame of the call (callback pair). This guarantees that the
callback is executed in the right xlator context.

The client handshake process which includes fetching of brick ports from
glusterd, setting lk-version on the brick for the session, don't have
the correct xlator set in their frames. The problem lies with RPC
notifications. It doesn't have the provision to set THIS with the xlator
that is registered with the corresponding RPC programs. e.g,
RPC_CLNT_CONNECT event received by protocol/client doesn't have THIS set
to its xlator. This implies, call(-callbacks) originating from this
thread don't have the right xlator set too.

The fix would be to save the xlator registered with the RPC connection
during rpc_clnt_new. e.g, protocol/client's xlator would be saved with
the RPC connection that it 'owns'. RPC notifications such as CONNECT,
DISCONNECT, etc inherit THIS from the RPC connection's xlator.

Change-Id: I9dea2c35378c511d800ef58f7fa2ea5552f2c409
BUG: 1235582
Signed-off-by: Krishnan Parthasarathi 
Reviewed-on: http://review.gluster.org/11436
Tested-by: Gluster Build System 
Tested-by: NetBSD Build System 
Reviewed-by: Raghavendra G

libgfapi: Gracefully exit when glfd is invalid

2015-07-07T15:06:43+00:00

When glfs_* methods operating on glfd are invoked after calling
glfs_close(), the program segfaults inside __GLFS_ENTRY_VALIDATE_FD
trying to deference glfd->fd->inode which is invalid.

Also, returning EBADF seemed more specific than EINVAL.

BUG: 1221008
Change-Id: I13a92dca52da9a300252b69e026581b3a9e931fd
Signed-off-by: Prashanth Pai 
Reviewed-on: http://review.gluster.org/10759
Tested-by: Gluster Build System 
Reviewed-by: Shyamsundar Ranganathan

build: Mac OS X build issues, gfapi symbol versions

2015-07-04T16:59:18+00:00

fix broken symbol versions

Change-Id: I153b87d80895ddd4718d0a9e51b4c0712b178bd4
BUG: 1238791
Signed-off-by: Kaleb S. KEITHLEY 
Reviewed-on: http://review.gluster.org/11514
Reviewed-by: Shyamsundar Ranganathan 
Reviewed-by: Niels de Vos 
Tested-by: Gluster Build System

Revert "Upcall/gfapi: Return ENOTSUP when upcall feature is disabled"

2015-06-28T08:25:24+00:00

This reverts commit b68f671b2b8a0aafef8f98145aee7044edaa907d from
http://review.gluster.org/11196 . The change depends on modifications to
the cluster xlators, but these are still partially under review.

Dropping this change now, it causes regression tests to fail.

Change-Id: If5ae4a519c9c6312cdb2e2a31acce4b1901f9442
BUG: 1231132
Signed-off-by: Soumya Koduri 
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/11452

gfapi : symlink resolution for glfs_object

2015-06-28T07:53:13+00:00

Generally posix expects symlink should be resolved, before performing an
acl related operation. This patch introduces a new api glfs_h_resolve_symlink()
which will do the same.

Change-Id: Ieee645154455a732edfb2c28834021bab4248810
BUG: 1209735
Signed-off-by: Jiffin Tony Thottan 
Reviewed-on: http://review.gluster.org/11410
Reviewed-by: Niels de Vos 
Reviewed-by: Raghavendra Talur 
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System

Upcall/gfapi: Return ENOTSUP when upcall feature is disabled

2015-06-27T23:22:51+00:00

Changes to detect the list of upcall events enabled using GF_FOP_IPC
and return ENOTSUP to applications in case if they poll for any of
the events disabled.

Change-Id: Icc748054ef903598288119dbe99b1e337174662a
BUG: 1231132
Signed-off-by: Niels de Vos 
Signed-off-by: Soumya Koduri 
Reviewed-on: http://review.gluster.org/11196
Reviewed-by: Kaleb KEITHLEY 
Tested-by: Kaleb KEITHLEY

libgfapi: introduce bit flags for pthread mutex and cond variables

2015-05-28T09:36:50+00:00

At present stage, the initialization and destroy of conditional
and mutex variables of glfs struct happen in different places and
there is no uniform way of destroying these variables incase
there is a failure when initializing these. The fs mutex and
conditional variables are getting destroyed from glfs_free_from_ctx().
However this destroy is not done by a conditional check inside destroy
function. By introducing bit flags in glfs object, we can make use of the
same (if there is a failure in initialization) in glfs_fini()
which is evolving as one and only function to free fs and ctx resources.
This patch introduce the flags field and set the flags according
to the initialization flow of the mutex and conditional variables
of struct glfs members. Without this patch we are compelled to use
the goto lables and other hacks in init functions to make sure
the resources are freed if there is an error path.

Change-Id: I86e2719fb7ce437419a05699b4f06c14b02d0e69
BUG: 1208482
Signed-off-by: Humble Devassy Chirammal 
Signed-off-by: Poornima G 
Reviewed-on: http://review.gluster.org/10120
Reviewed-by: Niels de Vos 
Tested-by: Gluster Build System 
Tested-by: NetBSD Build System
Reviewed-by: Shyamsundar Ranganathan