glusterfs.git, branch v5.6

doc: Added release 5.6 notes

2019-04-09T11:31:16+00:00

Fixes: bz#1693300
Change-Id: I4deaa0ecdd1692fb11f2d90ecc30a2370a659c2f
Signed-off-by: ShyamsundarR

glusterd: fix txn-id mem leak

2019-04-09T11:06:46+00:00

This commit ensures the following:
1. Don't send commit op request to the remote nodes when gluster v
status all is executed as for the status all transaction the local
commit gets the name of the volumes and remote commit ops are
technically a no-op. So no need for additional rpc requests.
2. In op state machine flow, if the transaction is in staged state and
op_info.skip_locking is true, then no need to set the txn id in the
priv->glusterd_txn_opinfo dictionary which never gets freed.

Fixes: bz#1694612
Change-Id: Ib6a9300ea29633f501abac2ba53fb72ff648c822
Signed-off-by: Atin Mukherjee 
(cherry picked from commit 34e010d64905b7387de57840d3fb16a326853c9b)

cluster-syncop: avoid duplicate unlock of inodelk/entrylk

2019-04-08T14:18:16+00:00

When using ec, there are many messages at brick log as,

[inodelk.c:514:__inode_unlock_lock] 0-test-locks:  Matching lock not found for unlock 0-9223372036854775807, lo=68e040a84b7f0000 on 0x7f208c006f78
[MSGID: 115053] [server-rpc-fops_v2.c:280:server4_inodelk_cbk] 0-test-server: 2557439: INODELK  (df4e41be-723f-4289-b7af-b4272b3e880c), client: CTX_ID:67d4a7f3-605a-4965-89a5-31309d62d1fa-GRAPH_ID:0-PID:1659-HOST:openfs-node2-PC_NAME:test-client-1-RECON_NO:-28, error-xlator: test-locks [Invalid argument]

> Change-Id: Ib164d29ebb071f620a4ca9679c4345ef7c88512a
> Signed-off-by: Kinglong Mee 
(cherry-pick of https://review.gluster.org/#/c/glusterfs/+/22377/)

Change-Id: I8345ad6c8e1bbb676917eb47e1c5ed72c162f6ce
Updates: bz#1690952
Signed-off-by: Kinglong Mee

glusterfsd: Multiple shd processes are spawned on brick_mux environment

2019-04-08T14:16:19+00:00

Problem: Multiple shd processes are spawned while starting volumes
         in the loop on brick_mux environment.glusterd spawn a process
         based on a pidfile and shd daemon is taking some time to
         update pid in pidfile due to that glusterd is not able to
         get shd pid

Solution: Commit cd249f4cb783f8d79e79468c455732669e835a4f changed
          the code to update pidfile in parent for any gluster daemon
          after getting the status of forking child in parent.To resolve
          the same correct the condition update pidfile in parent only
          for glusterd and for rest of the daemon pidfile is updated in
          child

> Change-Id: Ifd14797fa949562594a285ec82d58384ad717e81
> fixes: bz#1684404
> Signed-off-by: Mohit Agrawal 
> (cherry picked from commit 66986594a9023c49e61b32769b7e6b260b600626)

Change-Id: Ie0aa2aebd2b92e114a49777a169b600f3a7163f9
fixes: bz#1696147
Signed-off-by: Mohit Agrawal

logging: Fix GF_LOG_OCCASSIONALLY API

2019-04-08T14:15:36+00:00

GF_LOG_OCCASSIONALLY doesn't log on the first instance rather at every
42nd iterations which isn't effective as in some cases we might not have
the code flow hitting the same log for as many as 42 times and we'd end
up suppressing the log.

Fixes: bz#1695391
Change-Id: Iee293281d25a652b64df111d59b13de4efce06fa
Signed-off-by: Atin Mukherjee 
(cherry picked from commit d0d3e10d44366c68fc153e48b229e72a4aa26e61)

client-rpc: Fix the payload being sent on the wire

2019-04-08T14:14:29+00:00

The fops allocate 3 kind of payload(buffer) in the client xlator:
- fop payload, this is the buffer allocated by the write and put fop
- rsphdr paylod, this is the buffer required by the reply cbk of
  some fops like lookup, readdir.
- rsp_paylod, this is the buffer required by the reply cbk of fops like
  readv etc.

Currently, in the lookup and readdir fop the rsphdr is sent as payload,
hence the allocated rsphdr buffer is also sent on the wire, increasing
the bandwidth consumption on the wire.

With this patch, the issue is fixed.

Fixes: bz#1673058
Change-Id: Ie8158921f4db319e60ad5f52d851fa5c9d4a269b
Signed-off-by: Poornima G

cluster/dht: Fix lookup selfheal and rmdir race

2019-04-08T14:06:17+00:00

A race between the lookup selfheal and rmdir can cause
directories to be healed only on non-hashed subvols.
This can prevent the directory from being listed from
the mount point and in turn causes rm -rf to fail with
ENOTEMPTY.
Fix: Update the layout information correctly and reduce
the call count only after processing the response.

Change-Id: I812779aaf3d7bcf24aab1cb158cb6ed50d212451
fixes: bz#1695403
Signed-off-by: N Balachandran 
(cherry picked from commit b0f1d782fc45313fce4e1c0e74127401d5342d05)

gfapi: Unblock epoll thread for upcall processing

2019-04-01T06:01:09+00:00

With commit#ad35193,we have made changes to offload
processing upcall notifications to synctask so as not
to block epoll threads. However seems like the issue wasnt
fully addressed.

In "glfs_cbk_upcall_data" -> "synctask_new1" after creating synctask
if there is no callback defined, the thread waits on synctask_join
till the syncfn is finished. So that way even with those changes,
epoll threads are blocked till the upcalls are processed.

Hence the right fix now is to define a callback function for that
synctask "glfs_cbk_upcall_syncop" so as to unblock epoll/notify threads
completely and the upcall processing can happen in parallel by synctask
threads.

Change-Id: I4d8645e3588fab2c3ca534e0112773aaab68a5dd
fixes: bz#1694562
Signed-off-by: Soumya Koduri 
(cherry picked from commit 4a03a71c6171f6e8382664d9d29857d06ef37741)

doc: Added release notes for 5.5

2019-03-15T12:56:07+00:00

Fixes: bz#1689214
Change-Id: I57a1afa2649828d0399fab2bf163a05cf35358db
Signed-off-by: ShyamsundarR

eventsapi: Fix error while handling GlusterCmdException

2019-03-15T12:45:45+00:00

`GlusterCmdException` was wrongly accessed instead of accessing
`GlusterCmdException.message`.

Fixes: bz#1687249
Change-Id: I35ec1b05726050bfd8761e05ad9b9e47917dc0c6
Signed-off-by: Aravinda VK 
(cherry picked from commit 27f6375df009c8c4798b72aeafce79456007d21f)