glusterfs.git, branch v3.8.4

doc: release-notes for GlusterFS-3.8.4

2016-09-09T15:31:59+00:00

BUG: 1369049
Change-Id: I8f695e867d6043d46c99f55c232eed93580fe3c0
Signed-off-by: Niels de Vos

feature/bitrot: Fix recovery of corrupted hardlink

2016-09-09T14:05:06+00:00

Problem:
When a file with hardlink is corrupted in ec volume,
the recovery steps mentioned was not working.
Only name and metadata was healing but not the data.

Cause:
The bad file marker in the inode context is not removed.
Hence when self heal tries to open the file for data
healing, it fails with EIO.

Background:
The bitrot deletes inode context during forget.

Briefly, the recovery steps involves following steps.
   1. Delete the entry marked with bad file xattr
      from backend. Delete all the hardlinks including
      .glusters hardlink as well.
   2. Access the each hardlink of the file including
      original from the mount.

The step 2 will send lookup to the brick where the files
are deleted from backend and returns with ENOENT. On
ENOENT, server xlator forgets the inode if there are
no dentries associated with it. But in case hardlinks,
the forget won't be called as dentries (other hardlink
files) are associated with the inode. Hence bitrot stube
won't delete it's context failing the data self heal.

Fix:
Bitrot-stub should delete the inode context on getting
ENOENT during lookup.

>Change-Id: Ice6adc18625799e7afd842ab33b3517c2be264c1
>BUG: 1373520
>Signed-off-by: Kotresh HR 
>Reviewed-on: http://review.gluster.org/15408
>Smoke: Gluster Build System 
>NetBSD-regression: NetBSD Build System 
>CentOS-regression: Gluster Build System 
>Reviewed-by: Raghavendra Bhat 
(cherry picked from commit b86a7de9b5ea9dcd0a630dbe09fce6d9ad0d8944)


Change-Id: Ice6adc18625799e7afd842ab33b3517c2be264c1
BUG: 1374565
Signed-off-by: Kotresh HR 
Reviewed-on: http://review.gluster.org/15433
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Raghavendra Bhat

cli: fix volume status xml generation

2016-09-09T08:32:28+00:00

While generating xml, if CLI fails in between xml output doesn't get dumped into
stdout. Fix is to invoke cli_xml_output_vol_status_end () in such failures.

>Reviewed-on: http://review.gluster.org/15384
>NetBSD-regression: NetBSD Build System 
>CentOS-regression: Gluster Build System 
>Smoke: Gluster Build System 
>Reviewed-by: Samikshan Bairagya 
>Reviewed-by: Prashanth Pai 

Change-Id: I7cb3097f5ae23092e6d20f68bd75aa190c31ed88
BUG: 1374290
Signed-off-by: Atin Mukherjee 
Reviewed-on: http://review.gluster.org/15428
Smoke: Gluster Build System 
Reviewed-by: Samikshan Bairagya 
Reviewed-by: Prashanth Pai 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System

cluster/dht: move layout logs to DEBUG level

2016-09-07T14:57:17+00:00

> Reviewed-on: http://review.gluster.org/15343
> NetBSD-regression: NetBSD Build System 
> CentOS-regression: Gluster Build System 
> Reviewed-by: N Balachandran 
> Smoke: Gluster Build System 
> Reviewed-by: Shyamsundar Ranganathan 
> Signed-off-by: Susant Palai 
(cherry picked from commit 15c790b502ba92caa17f2d1870c3d75d547e6bad)

Change-Id: Iad96256218be643b272762b5638a3f6837aff28d
BUG: 1366496
Signed-off-by: Susant Palai 
Reviewed-on: http://review.gluster.org/15413
Reviewed-by: N Balachandran 
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System

tests/cli: Generate SSL certificates

2016-09-07T14:55:05+00:00

Generate SSL certificates before enabling
management encryption to avoid test failure.

master -
This patch is backport of following two master patches

http://review.gluster.org/#/c/13959/ - bug-1320388.t
was first introduced in this patch

http://review.gluster.org/#/c/15202/ - Modified
bug-1320388.t to create SSL cerificate

>Change-Id: Iab23b36703f4653f1d5bb9d14695e4d3fa63ad61
>Signed-off-by: Ashish Pandey 
>BUG: 1368349
>Signed-off-by: Ashish Pandey 
>Reviewed-on: http://review.gluster.org/15202
>Smoke: Gluster Build System 
>NetBSD-regression: NetBSD Build System 
>CentOS-regression: Gluster Build System 
>Reviewed-by: Atin Mukherjee 
>Signed-off-by: Ashish Pandey 

Change-Id: Iab23b36703f4653f1d5bb9d14695e4d3fa63ad61
BUG: 1368918
Signed-off-by: Ashish Pandey 
Reviewed-on: http://review.gluster.org/15228
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Niels de Vos 
Smoke: Gluster Build System

geo-rep: address potential leak of memory

2016-09-07T14:04:56+00:00

fix memory leak reported by clang analyzer:
gsyncd.c:411:17: warning: Potential leak of 
                 memory pointed to by 'argv'
                 in main()



>BUG: 1332419
>Signed-off-by: Prasanna Kumar Kalever 
>Reviewed-on: http://review.gluster.org/14151
>NetBSD-regression: NetBSD Build System 
>CentOS-regression: Gluster Build System 
>Smoke: Gluster Build System 
>Reviewed-by: Kotresh HR 

Change-Id: I179fb1c095cf4d331b5910df6388dc724cb4ac96
BUG: 1332424
Signed-off-by: Prasanna Kumar Kalever 
Change-Id: Id60c851c5462868630349dd4707fd94f1b83e488
Reviewed-on: http://review.gluster.org/15377
Tested-by: Atin Mukherjee 
NetBSD-regression: NetBSD Build System 
Smoke: Gluster Build System 
Reviewed-by: Prasanna Kumar Kalever 
Reviewed-by: Niels de Vos 
CentOS-regression: Gluster Build System

build: correctly format some (s)size_t messages

2016-09-07T14:00:48+00:00

On 32-bit builds the are are warnings like these:

    posix.c:6438: warning: format '%ld' expects type 'long int', but argument 11 has type 'ssize_t'

Instead of using "%l" for (signed) size_t variables, "%z" should be
used.

Cherry picked from commit 3af889f02722f4636d2ea30570de6477e8b5a3a9:
> BUG: 1198849
> Change-Id: I6f57b5e8ea174dd9e3056aff5da685e497894ccf
> Signed-off-by: Niels de Vos 
> Reviewed-on: http://review.gluster.org/14933
> NetBSD-regression: NetBSD Build System 
> CentOS-regression: Gluster Build System 
> Reviewed-by: Kaleb KEITHLEY 
> Smoke: Gluster Build System 

This patch is not really recommended for backporting, but we do have a
new smoke test that fails when these warnings pop-up. It is cleaner to
correct the code in the release-3.7 branch then to modify the smoke test
to skip this branch.

Change-Id: I6f57b5e8ea174dd9e3056aff5da685e497894ccf
BUG: 1373530
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/15410
Reviewed-by: Kaleb KEITHLEY 
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System

common-ha: ganesha_mon: line 137: [: too many arguments ]" messages

2016-09-07T11:49:17+00:00

ensure that there are always valid, non-null arguments to /bin/test

Here there be dragons. Very racy, but if the races lose, they lose
in a way that's consistent with what we're testing for anyway, namely
that the ganesha.nfsd process is gone.

Change-Id: I88b770dd874ffa8576711f8009f27122a4fb0130
BUG: 1372728
Signed-off-by: Kaleb S. KEITHLEY 
Reviewed-on: http://review.gluster.org/15409
Reviewed-by: Niels de Vos 
CentOS-regression: Gluster Build System 
NetBSD-regression: NetBSD Build System 
Smoke: Gluster Build System

features/upcall: segment fault while join thread reaper_thr in fini()

2016-09-05T09:07:18+00:00

reaper_thr thread may not be started according to option
'cache-invalidation', if it's not started, join it in fini will cause a
segment fault.

Cherry picked from commit 7f0042dce94edb58c92662d9e4f852ba006d12dc:
> Change-Id: I1c145a5feb137767880a08e79f810537283fb6b9
> BUG: 1369524
> Signed-off-by: Ryan Ding 
> [ndevos: check .reaper_init_done and make it a boolean]
> Reviewed-on: http://review.gluster.org/15298
> Smoke: Gluster Build System 
> Reviewed-by: soumya k 
> Reviewed-by: Niels de Vos 
> NetBSD-regression: NetBSD Build System 
> CentOS-regression: Gluster Build System 

Change-Id: I1c145a5feb137767880a08e79f810537283fb6b9
BUG: 1371194
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/15336
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Ryan Ding 
Reviewed-by: soumya k

protocol/server: readlink rsp xdr will fail while readlink got an error

2016-09-01T15:20:41+00:00

set gfs3_readlink_rsp.path with an empty string while error happen, to
make xdr_gfs3_readlink_rsp happy. otherwise the original errno will be
lost, and return an rpc internal errno instead.

Change-Id: I36655b66df8b9f164e5bd21eb17244722c2f5a52
BUG: 1370172
Signed-off-by: Ryan Ding 
Reviewed-on: http://review.gluster.org/15312
Smoke: Gluster Build System 
Reviewed-by: Pranith Kumar Karampuri 
Tested-by: Pranith Kumar Karampuri 
CentOS-regression: Gluster Build System 
NetBSD-regression: NetBSD Build System