glusterfs.git, branch v3.6.9

quota : fix could not start auxiliary mount issue

2016-02-24T16:26:55+00:00

In versions older than 3.7, when trying to enable
quota, the following message appears :"quota: Could
not start quota auxiliary mount". It was because,
/var/run/gluster was not getting created in cli side.
In 3.7, the code has been moved to glusterd and we are
making use of sys_mkdir.

3.5 fix -> http://review.gluster.org/#/c/13215/

> Change-Id: Id4360409f76b57c0f676fe2b859f3647c4340575
> BUG: 1117888
> Signed-off-by: Manikandan Selvaganesh 

Change-Id: Id4360409f76b57c0f676fe2b859f3647c4340575
BUG: 1302541
Signed-off-by: Manikandan Selvaganesh 
Reviewed-on: http://review.gluster.org/13308
Smoke: Gluster Build System 
Reviewed-by: Niels de Vos 
Reviewed-by: Vijaikumar Mallikarjuna 
CentOS-regression: Gluster Build System 
NetBSD-regression: NetBSD Build System

quota : avoid "contribution node is empty" error logs

2016-02-18T14:35:39+00:00

In versions older than 3.7, "contribution node list is empty which is
an error" gets logged numerous number of times. It is completely fixed
in 3.7. Since the entire marker and quota code has almost been
refactored, it is hard to backport the complete fix and also it could
not be fixed with the older approach. As a temporary fix, to avoid
numerous logs, the patch just supresses the log level.

3.5 fix: http://review.gluster.org/#/c/12990/

> Change-Id: Ie666ba99c7bb16b9ce249b581e09857734589f51
> BUG: 1288195
> Signed-off-by: Manikandan Selvaganesh 

Change-Id: Ie666ba99c7bb16b9ce249b581e09857734589f51
BUG: 1302310
Signed-off-by: Manikandan Selvaganesh 
Reviewed-on: http://review.gluster.org/13304
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Niels de Vos 
Reviewed-by: Vijaikumar Mallikarjuna 
NetBSD-regression: NetBSD Build System

tests : Modifying crypt xlators unit tests

2016-02-18T14:31:44+00:00

Backport of http://review.gluster.org/#/c/13240/

The "encryption.master-key" should be set before enabling crypt xlators.
Otherwise glusterfs client process(like gluster-NFS) will crash due to the
failure in intialising crypt xlator.

You can see the following messages in client log file
[2016-01-14 08:13:15.740835] E [crypt.c:4298:master_set_master_vol_key]
0-test1-crypt: FATAL: missing master key
[2016-01-14 08:13:15.740859] E [MSGID: 101019]
[xlator.c:429lator_init] 0-test1-crypt: Initialization of volume
'test1-crypt' failed, review your volfile again
[2016-01-14 08:13:15.740890] E [MSGID: 101066]
[graph.c:324:glusterfs_graph_init] 0-test1-crypt: initializing
translator failed
[2016-01-14 08:13:15.740904] E [MSGID: 101176]
[graph.c:670:glusterfs_graph_activate] 0-graph: init failed
[2016-01-14 08:13:15.741676] W [glusterfsd.c:1231:cleanup_and_exit]
(-->/usr/sbin/glusterfs(mgmt_getspec_cbk+0x307) [0x40d287]
-->/usr/sbin/glusterfs(glusterfs_process_volfp+0x117) [0x4086c7]
-->/usr/sbin/glusterfs(cleanup_and_exit+0x4d) [0x407e1d] ) 0-: received
signum (0), shutting down

Upstream reference
-------------------
>Change-Id: I124deda505d128eacb15ca20fbdcd1593cb8eba3
>BUG: 1298520
>Signed-off-by: Jiffin Tony Thottan 
>Reviewed-on: http://review.gluster.org/13240
>Smoke: Gluster Build System 
>Reviewed-by: Niels de Vos 
>CentOS-regression: Gluster Build System 
>NetBSD-regression: NetBSD Build System 
>(cherry picked from commit ca4d4a26a553bac9c627bc6e6d6c9fa1f9435297)

Change-Id: Ibe0b7e99e7125d9365d6cedf55d8649c86108b41
BUG: 1308806
Reviewed-on: http://review.gluster.org/13453
Smoke: Gluster Build System 
Tested-by: jiffin tony Thottan 
CentOS-regression: Gluster Build System 
Reviewed-by: Raghavendra Bhat 
NetBSD-regression: NetBSD Build System

Add missing release-notes

2016-02-18T03:16:59+00:00

The release notes contain only the list of bug fixes. I don't have
enough context to add more notes per release.

Change-Id: I6de85015705fc4c528832db1110aeefea8c21ba4
BUG: 1304668
Signed-off-by: Kaushal M 
Reviewed-on: http://review.gluster.org/13349
Smoke: Gluster Build System 
Reviewed-by: Niels de Vos 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System

rpm: glusterfs-server requires -api

2016-01-26T22:35:30+00:00

The glusterfs-server package requires libgfapi.so for the glfs-heal
binary and possibly other parts.

Also adding %{?_isa} to requirements as described in the Fedora
Packaging Guidelines for Explicit Requires at
https://fedoraproject.org/wiki/Packaging:Guidelines#Explicit_Requires

This is a backport of:
> BUG: 1296992
> Change-Id: I96c62876b776d04a7f5d1b1dc34c02302b6ffbe6
> Reviewed-on: http://review.gluster.org/13200
> Signed-off-by: Niels de Vos 

BUG: 1296931
Change-Id: I96c62876b776d04a7f5d1b1dc34c02302b6ffbe6
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/13201
Reviewed-by: Kaleb KEITHLEY 
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
NetBSD-regression: NetBSD Build System 
Reviewed-by: Raghavendra Bhat

build: update link for .git/hooks/commit-msg

2016-01-15T12:32:02+00:00

Add -L option to curl cmd to follow a redirect

Signed-off-by: Kaleb S KEITHLEY

core : Use correct path in dlopen for socket.so

2015-12-16T11:29:23+00:00

Backport of http://review.gluster.org/12656

This patch fixes the path for socket.so file while loading the so dynamically.
Also for config.memory-accounting & config.transport voltype is changed to
glusterd to fix the warning message coming from xlator_volopt_dynload

Change-Id: I0f7964814586f2018d4922b23c683f4e1eb3098e
BUG: 1283834
Signed-off-by: Atin Mukherjee 
Reviewed-on: http://review.gluster.org/12656
Tested-by: Gluster Build System 
Reviewed-by: Niels de Vos 
Reviewed-by: Jeff Darcy 
Reviewed-on: http://review.gluster.org/12671
Reviewed-by: Raghavendra Bhat

fuse: pass default SElinux mount options on to the kernel

2015-12-16T11:27:13+00:00

In order to set default SElinux contexts on a Gluster mount, the
standard SElinux mount options need to be passed to the kernel. The
mount(8) manual page lists "context", "fscontext", "defcontext" and
"rootcontext" as valid options.

        Backport of http://review.gluster.org/#/c/12858/

Cherry-picked from commit 5e81233f0a3c153e03c437a164ac2ca21314bdec
> BUG: 1287763
> Change-Id: I015fe27e4c6ff36a030e3480b23141aca2d91fc2
> Signed-off-by: Niels de Vos 
> Reviewed-on: http://review.gluster.org/12858
> Tested-by: NetBSD Build System 
> Tested-by: Gluster Build System 
> Reviewed-by: Humble Devassy Chirammal 
> Reviewed-by: Manikandan Selvaganesh 

BUG: 1287878
Change-Id: I015fe27e4c6ff36a030e3480b23141aca2d91fc2
Signed-off-by: Manikandan Selvaganesh 
Reviewed-on: http://review.gluster.org/12871
Reviewed-by: Niels de Vos 
Tested-by: Gluster Build System 
Reviewed-by: Raghavendra Bhat

protocol/client: prevent use-after-free of frame->root

2015-11-25T06:38:47+00:00

A regression failure generated a coredump on the glusterfs-client side:

  (gdb) f 0
  #0  0x00007fba6cd76432 in client_submit_request (this=0x7fba68006fc0,
                  req=0x7fba6579aa70, frame=0x7fba5c0058cc,
                  prog=0x7fba6cfb53c0 , procnum=41,
                  cbkfn=0x7fba6cd9206d ,
                  iobref=0x0, rsphdr=0x0, rsphdr_count=0,
                  rsp_payload=0x0, rsp_payload_count=0, rsp_iobref=0x0,
                  xdrproc=0x7fba79801075 ) at
  /home/jenkins/root/workspace/rackspace-regression-2GB-triggered/xlators/protocol/client/src/client.c:324
  324                   frame->root->ngrps = ngroups;
  (gdb) l
  319                   gf_msg_debug (this->name, 0, "rpc_clnt_submit failed");
  320           }
  321
  322           if (!conf->send_gids) {
  323                   /* restore previous values */
  324                   frame->root->ngrps = ngroups;
  325                   if (ngroups <= SMALL_GROUP_COUNT)
  326                           frame->root->groups_small[0] = gid;
  327           }
  328
  (gdb) p *frame->root
  Cannot access memory at address 0x64185df000000000

After looking at this in more detail, the flow is like this:

  client_submit_request()
    |
    '- rpc_clnt_submit() // on line 314
         |
         '- cbkfn() // = client3_3_release_cbk
              |
              :- STACK_DESTROY (frame->root);
         .----'
    .----'
    |
    :- frame->root->ngrps = ngroups; // on line 324
    '

So, there is a use-after-free, and it is not needed to restore the
previous groups in frame->root.

Cherry picked from commit dc3aa7524e4974f9d02465e2e5dd6ed9b6d319e1:
> Change-Id: I9e7d712183692ed92cfc2f75cd3c2781a9db20e2
> BUG: 1281285 (was incorrect in original patch)
> Signed-off-by: Niels de Vos 
> Reviewed-on: http://review.gluster.org/12575
> Reviewed-by: Dan Lambright 
> Tested-by: NetBSD Build System 
> Reviewed-by: Jeff Darcy 

Change-Id: I9e7d712183692ed92cfc2f75cd3c2781a9db20e2
BUG: 1283690
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/12665
Tested-by: Gluster Build System 
Reviewed-by: Dan Lambright 
Reviewed-by: Raghavendra Bhat

glusterd.service: Ensure rpcbind is started before glusterd

2015-11-24T04:57:02+00:00

Having the rpcbind.service under the `After` option only ensures that
glusterd.service is started after rpcbind.service if both are
enabled/started at the same time. It doesn't ensure that starting
glusterd.service will start rpcbind.service.

The systemd.unit(5) man page suggests to use both the `Requires` and
`After` options to ensure that rpcbind is started before glusterd,
whenever glusterd is started.

Cherry picked from commit 23440a73bc348bbc3bb43ec397f0639ee45865fc:
> BUG: 1282915
> Change-Id: Iee69965486be08711299aba235f7b00c3e2fe7e9
> Signed-off-by: Kaushal M 
> Reviewed-on: http://review.gluster.org/12605
> Reviewed-by: Atin Mukherjee 
> Reviewed-by: Anand Nekkunti 
> Tested-by: Gluster Build System 
> Tested-by: NetBSD Build System 

Change-Id: Iee69965486be08711299aba235f7b00c3e2fe7e9
BUG: 1283144
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/12641
Tested-by: Gluster Build System 
Reviewed-by: Atin Mukherjee 
Reviewed-by: Raghavendra Bhat