glusterfs.git, branch v3.4.0alpha

fuse(efence): zero sized memory was being allocated.

2013-02-06T03:58:02+00:00

For the last call of getdents(), gf_malloc called with 0 size, which is then
caught by efence.

BUG: 782760
Change-Id: If289029117a62ecfcecc70480e5ac8f0e050487d
Signed-off-by: Anand Avati 
Original-author: Varun Shastry 
Reviewed-on: http://review.gluster.org/3846
Tested-by: Gluster Build System 
Reviewed-by: Amar Tumballi

rpcsvc: Fix memory corruption caused by rpcsvc_dump returning non-zero

2013-02-05T21:35:16+00:00

The convention followed is that any actor should return non-zero
value only if it has not attempted to send the reply back. If an
actor returns non-zero, rpcsvc_handle_rpc_call tries to send an
error reply. Since, rpcsvc_submit_generic frees the rpc_req, its wrong
to invoke it more than once on same rpc_req. When the transport is not
connected, rpcsvc_dump used to pass the non-zero value it got from
 transport to rpcsvc resulting in memory corruption. Hence this patch
makes rpcsvc_dump to return 0.

Change-Id: I1b6f28969ee546c44d193d3d33debccb65585b69
BUG: 903113
Signed-off-by: Raghavendra G 
Reviewed-on: http://review.gluster.org/4183
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati 
Reviewed-by: Raghavendra Bhat 
Reviewed-by: Jeff Darcy

protocol/client: Avoid double free of frame

2013-02-05T06:11:51+00:00

When client_submit_request fails it calls cbk. The cleanups should
happen only in cbk. The code committed as part of
http://review.gluster.org/4357 violates this. Also found that
clnt_release_reopen_fd violates this as well.
This patch fixes these issue.

Change-Id: Ic02ba278724b03c65c00b686c39fd7846122618a
BUG: 821056
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.org/4464
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

glusterd: remove extra call to glusterd_volume_compute_cksum()

2013-02-05T03:23:00+00:00

In the commit phase of volume create, checksum on volinfo is
computed twice - once in the call to glusterd_store_volinfo() and once,
further down, in the same function glusterd_op_create_volume().

Change-Id: I36f9426943cd48937d4946b4b4ef09f19f31d888
BUG: 812356
Signed-off-by: Krutika Dhananjay 
Reviewed-on: http://review.gluster.org/4463
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

glusterd: log changes in volume create and delete codepath

2013-02-05T03:21:59+00:00

Making log changes involving two commands as they both share sections
of code (like the part where the volume metadata is cleaned up in vol
delete in case of success; and in vol create in case of failure).

* Most of the changes are of the 's/THIS/this' kind.

* Changed some of the log messages to give as much information as
  available in case of failure.

* Changed log levels in some of the log messages.

Change-Id: I10242511fe9400a07ab04717464d748d9172dd85
BUG: 812356
Signed-off-by: Krutika Dhananjay 
Reviewed-on: http://review.gluster.org/4462
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

group-virt: Change profile to include remote-dio and exclude posix-aio.

2013-02-05T01:42:05+00:00

remote-dio enables filtering O_DIRECT in the client xlator. This has been
found to be useful for improving performance when there are multiple VMs
talking to an image store.

Aggregated throughput results for a single thread iozone run from multiple VMs
and a single host can be seen below:

-------------------------------------------------
No. of VMs |   remote-dio on  |   remote-dio off |
-------------------------------------------------
       2   |     400 MB/s     |    202 MB/s      |
       4   |     650 MB/s     |    410 MB/s      |
--------------------------------------------------

posix-aio has not been found to improve performance consistently with VM image
workload. Hence not including that in the default virt profile.

Change-Id: I592f68b95a955036f1a985352d2f4950ced1deef
BUG: 907301
Signed-off-by: Vijay Bellur 
Reviewed-on: http://review.gluster.org/4460
Reviewed-by: Anand Avati 
Tested-by: Anand Avati

glusterd: "volume heal info" doesn't report output properly

2013-02-05T01:41:16+00:00

Problem: "volume heal info" doesn't reports files to be healed when gluster*
         processes on one of the storage node is not running

Change-Id: Iff7d41407014624e4da9b70d710039ac14b48291
BUG: 880898
Signed-off-by: Venkatesh Somyajulu 
Reviewed-on: http://review.gluster.org/4371
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

geo-rep / gsyncd: Separate log file directory for Mountbroker sessions

2013-02-05T01:34:56+00:00

... so that a mountbroker session which is initiated b/w master
and slave does not use the same log file if it's started after
a normal geo-rep session b/w master and slave. This results in
EPERM as the log file is owned by root and the geo-rep slave
process (now running as a non privileged user) does not have
access to it.

Also, having separate log file directory for mountbroker sessions
looks clean.

NOTE: geo-rep's client mount log file location remains unchanged.

Change-Id: Ic7a732e250aee5393b9c3f6ebf6dfe2c310b7fe4
BUG: 893960
Signed-off-by: Venky Shankar 
Reviewed-on: http://review.gluster.org/4407
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

glusterd: Indexed node information in dict to retain consistency.

2013-02-04T22:24:55+00:00

Problem:
--------
Depending on the response time from different nodes, the response
dict for rebalance status was populated in  a FIFO manner, and
hence the output for the CLI was never consistent.

Fix:
----
Irrespective of the response time of the nodes, we now index the
entries in the response dict for rebalance status, in reference
to the peerlist. So, the order of the entries and hence the CLI
output is always consistent.

Change-Id: Ica7e89e5d95aa9860a6f3c7eff58ca2052e05bd6
BUG: 888390
Signed-off-by: Avra Sengupta 
Reviewed-on: http://review.gluster.org/4416
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

tests: Made changes to verify if any of the bricks crashed

2013-02-04T16:45:09+00:00

Change-Id: I9da3b8a490159b1090a803b74d0058be0d884c94
BUG: 905864
Signed-off-by: Krishnan Parthasarathi 
Reviewed-on: http://review.gluster.org/4461
Tested-by: Gluster Build System 
Reviewed-by: Raghavendra G 
Reviewed-by: Jeff Darcy 
Reviewed-by: Anand Avati