glusterfs.git, branch v3.11.3

doc: Minor edit to release notes for 3.11.3

2017-08-21T14:41:10+00:00

Change-Id: Ib1f4bac62fdd01b3e5e97582b5464b14c1fb9a8e
BUG: 1473776
Signed-off-by: ShyamsundarR 
Reviewed-on: https://review.gluster.org/18079
CentOS-regression: Gluster Build System 
Smoke: Gluster Build System

doc: Release 3.11.3 release notes updated

2017-08-21T14:10:10+00:00

Change-Id: Ic0d25caf797c73d1522b90579e8cd62efc8ae647
BUG: 1473776
Signed-off-by: ShyamsundarR 
Reviewed-on: https://review.gluster.org/18078
CentOS-regression: Gluster Build System 
Smoke: Gluster Build System

storage/posix: Use the ret value of posix_gfid_heal()

2017-08-12T13:43:07+00:00

... to make the change in commit acf8cfdf truly useful.

Without this, a race between entry creation fops and lookup
at posix layer can cause lookups to fail with ENODATA, as
opposed to ENOENT.

Backport of:
> Change-Id: I44a226872283a25f1f4812f03f68921c5eb335bb
> Reviewed-on: https://review.gluster.org/17821
> BUG: 1472758
> cherry-picked from 669868d23eaeba42809fca7be134137c607d64ed

Change-Id: I44a226872283a25f1f4812f03f68921c5eb335bb
BUG: 1479692
Signed-off-by: Krutika Dhananjay 
Reviewed-on: https://review.gluster.org/18009
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Raghavendra Bhat

gfapi: Duplicate the buffer sent in setxattr calls

2017-08-12T13:42:27+00:00

Issue:
The caller of glfs_setxattr sends a buffer to set as the value.
We create a dict in which the pointer to the value is set.
Underlying layers like md-cache take a ref on this dict to store
the value for a longer time. But the moment setxattr is complete,
the caller of glfs_setxattr can free the value memory.

Solution:
memcpy the setxattr value to the gluster buffer.

> Reviewed-on: https://review.gluster.org/17967
> Reviewed-by: soumya k 
> Smoke: Gluster Build System 
> CentOS-regression: Gluster Build System 
> Reviewed-by: Jeff Darcy 
> (cherry picked from commit e11296f8e52b7e3b13d21b41d4fa34baea878edf)

Change-Id: I58753fe702e8b7d0f6c4f058714c65d0ad5d7a0a
BUG: 1479656
Signed-off-by: Poornima G 
Reviewed-on: https://review.gluster.org/18002
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Shyamsundar Ranganathan

packaging: /var/lib/glusterd/options should be %config(noreplace)

2017-08-12T13:40:33+00:00

/var/lib/glusterd/options is where cluster.enabled-shared-storage is
persisted. If the file is removed as part of an uninstall/reinstall
or update then the state of shared storage could be lost.

Change-Id: Ie18c3d883df71c1857fd6996d9c03ab247580b70
BUG: 1476873
Signed-off-by: Kaleb S. KEITHLEY 
Reviewed-on: https://review.gluster.org/17934
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System

scripts: invalid test(1) in extras/S32gluster_enable_shared_storage.sh

2017-08-12T13:40:26+00:00

test(1) man pages says -eq is for INTEGER compares, and = is for
string compares.

Also note the comment that -a and -o are ambiguous and to use
test && test or test || test instead.

This bug has existed since 2015! (yikes)

Found while testing localtime logging and running glusterd in the
foreground.

Change-Id: Ia544f7295e247b981504d085ebc4c533ab60ba84
BUG: 1476822
Signed-off-by: Kaleb S. KEITHLEY 
Reviewed-on: https://review.gluster.org/17927
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System

ec/cluster: Update failure of fop on a brick properly

2017-08-12T13:39:48+00:00

Problem:
In case of truncate, if writev or open fails on a brick,
in some cases it does not mark the failure onlock->good_mask.
This causes the update of size and version on all the bricks
even if it has failed on one of the brick. That ultimately
causes a data corruption.

Solution:
In callback of such writev and open calls, mark fop->good
for parent too.

Thanks Pranith Kumar K  for finding the
root cause.

>Change-Id: I8a1da2888bff53b91a0d362b8c44fcdf658e7466
>BUG: 1476205
>Signed-off-by: Ashish Pandey 
>Reviewed-on: https://review.gluster.org/17906
>Reviewed-by: Pranith Kumar Karampuri 
>Smoke: Gluster Build System 
>CentOS-regression: Gluster Build System 
>Signed-off-by: Ashish Pandey 

Change-Id: I8a1da2888bff53b91a0d362b8c44fcdf658e7466
BUG: 1476870
Signed-off-by: Ashish Pandey 
Reviewed-on: https://review.gluster.org/17933
Smoke: Gluster Build System 
Reviewed-by: Pranith Kumar Karampuri 
CentOS-regression: Gluster Build System

performance/io-cache: update inode contexts of each entry in readdirplus

2017-07-31T14:11:16+00:00

io-cache stores read-cache in inode which is currently created only in
lookup. But, with readdirplus and md-cache absorbing lookups, io-cache
need not receive a lookup before a fop like readv.

>Change-Id: I6eba995b0a90d4d5055a4aef0489707b852da1b8
>BUG: 1474180
>Signed-off-by: Raghavendra G 
>Signed-off-by: Raghavendra G 
>Reviewed-on: https://review.gluster.org/5029
>Smoke: Gluster Build System 
>CentOS-regression: Gluster Build System 

(cherry picked from commit b90e12134af85635199750967c326761d6c06e86)
Change-Id: I6eba995b0a90d4d5055a4aef0489707b852da1b8
BUG: 1475637
Signed-off-by: Raghavendra G 
Signed-off-by: Raghavendra G 
Reviewed-on: https://review.gluster.org/17890
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Shyamsundar Ranganathan

doc: Added release notes for 3.11.2 release

2017-07-21T15:37:46+00:00

Change-Id: I03f20ace01a29cf8c22538adf4c11bddd343bc0e
BUG: 1466024
Signed-off-by: Shyam 
Reviewed-on: https://review.gluster.org/17852
CentOS-regression: Gluster Build System 
Smoke: Gluster Build System

nfs/nlm: keep track of the call-state and frame for notifications

2017-07-21T15:03:29+00:00

When blocking locks are used, a new frame is allocated that is used to
send the notification to the client once once the lock becomes
available. In all other cases, the frame that contains the request from
the client will be used for the reply.

Because there was no way to track the different clients with their
requests (captured in the call-state), the call-state could be free'd
before the notification was sent to the client. This caused a
use-after-free of the call-state and could trigger segfaults of the
Gluster/NFS server or incorrect replies on (un)lock requests.

By introducing a nlm4_notify_args structure, the call-state and frame
can be tracked better. This prevents the possibility of segfaulting when
the call-state is used after being free'd.

Cherry picked from commit b81997264f079983fa02bd5fa2b3715224942b00:
> BUG: 1467313
> Change-Id: I285d2bc552f509e5145653b7a50afcff827cd612
> Signed-off-by: Niels de Vos 
> Reviewed-on: https://review.gluster.org/17700
> Smoke: Gluster Build System 
> CentOS-regression: Gluster Build System 
> Reviewed-by: Kaleb KEITHLEY 
> Reviewed-by: jiffin tony Thottan 

Change-Id: I285d2bc552f509e5145653b7a50afcff827cd612
BUG: 1471869
Signed-off-by: Niels de Vos 
Reviewed-on: https://review.gluster.org/17801
CentOS-regression: Gluster Build System 
Smoke: Gluster Build System 
Reviewed-by: Shyamsundar Ranganathan