From dbf5516a39818b30efd8ea9a3ab71c3aa182e2a7 Mon Sep 17 00:00:00 2001 From: Jan Pazdziora Date: Fri, 27 Jun 2014 16:16:18 +0200 Subject: Fix reporting of failed calls that have no parameters. --- mod_lookup_identity.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/mod_lookup_identity.c b/mod_lookup_identity.c index 7349d72..cc65a90 100644 --- a/mod_lookup_identity.c +++ b/mod_lookup_identity.c @@ -126,20 +126,20 @@ static DBusMessage * lookup_identity_dbus_message(request_rec * r, DBusConnectio char * p = args_string; for (i = 0; i < nargs; i++) { strcpy(p, ", "); - strcpy(p, args[i]); + strcpy(p + 2, args[i]); p += strlen(args[i]) + 2; } args_string[total_args_length] = '\0'; } if (dbus_error_is_set(error)) { ap_log_error(APLOG_MARK, APLOG_ERR, 0, r->server, - "Error dbus calling %s(%s, %s): %s: %s", method, user, args_string, error->name, error->message); + "Error dbus calling %s(%s%s): %s: %s", method, user, args_string, error->name, error->message); } else if (reply_type == DBUS_MESSAGE_TYPE_ERROR) { ap_log_error(APLOG_MARK, APLOG_ERR, 0, r->server, - "Error %s dbus calling %s(%s, %s)", dbus_message_get_error_name(reply), method, user, args_string); + "Error %s dbus calling %s(%s%s)", dbus_message_get_error_name(reply), method, user, args_string); } else { ap_log_error(APLOG_MARK, APLOG_ERR, 0, r->server, - "Error unexpected reply type %d dbus calling %s(%s, %s)", reply_type, method, user, args_string); + "Error unexpected reply type %d dbus calling %s(%s%s)", reply_type, method, user, args_string); } if (reply) { dbus_message_unref(reply); -- cgit