From 438bd24fcb47c879227777d83aa0bac3f1326522 Mon Sep 17 00:00:00 2001 From: Jan Pazdziora Date: Tue, 22 Nov 2016 14:05:12 +0100 Subject: Fix AuthPAMExpiredRedirect %s escaping on Apache 2.2. --- mod_authnz_pam.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/mod_authnz_pam.c b/mod_authnz_pam.c index 23ccf61..22718ea 100644 --- a/mod_authnz_pam.c +++ b/mod_authnz_pam.c @@ -85,8 +85,7 @@ static const char * ap_escape_urlencoded(apr_pool_t * pool, const char * buffer) while (*buffer) { if (!apr_isalnum(*buffer) && !strchr(".-*_ ", *buffer)) { *p++ = '%'; - sprintf(p, "%02x", *p); - *p += 2; + p += snprintf(p, 3, "%02x", *buffer); } else if (*buffer == ' ') { *p++ = '+'; } else { @@ -94,7 +93,7 @@ static const char * ap_escape_urlencoded(apr_pool_t * pool, const char * buffer) } buffer++; } - *p++ = '\0'; + *p = '\0'; return copy; } #endif -- cgit