From fddb2212bc3394068ba0cd6aebbfcf2e77cb6def Mon Sep 17 00:00:00 2001 From: Petr Vobornik Date: Thu, 27 Feb 2014 18:21:05 +0100 Subject: webui-css: improve radio,checkbox keyboard support and color checkboxes and radio buttons: - do not change color on hover when disabled - are focusable and checkable be keyboard again. This uses a little trick where the real checkbox is hidden under the artificial checkbox. That way it has the same position and therefore it works even in containers with overflow set. https://fedorahosted.org/freeipa/ticket/4217 Reviewed-By: Adam Misnyovszki --- ipatests/test_webui/test_dns.py | 6 +++--- ipatests/test_webui/test_host.py | 8 ++++---- ipatests/test_webui/test_service.py | 4 ++-- ipatests/test_webui/ui_driver.py | 2 +- 4 files changed, 10 insertions(+), 10 deletions(-) (limited to 'ipatests/test_webui') diff --git a/ipatests/test_webui/test_dns.py b/ipatests/test_webui/test_dns.py index c832190d3..dbcb2622e 100644 --- a/ipatests/test_webui/test_dns.py +++ b/ipatests/test_webui/test_dns.py @@ -37,10 +37,10 @@ ZONE_DATA = { ('textbox', 'idnsname', ZONE_PKEY), ('textbox', 'idnssoamname', 'ns'), ('textbox', 'ip_address', '192.168.1.1'), - ('checkbox', 'force', ''), + ('checkbox', 'force', 'checked'), ], 'mod': [ - ('checkbox', 'idnsallowsyncptr', ''), + ('checkbox', 'idnsallowsyncptr', 'checked'), ], } @@ -63,7 +63,7 @@ RECORD_MOD_DATA = { CONFIG_MOD_DATA = { 'mod': [ - ('checkbox', 'idnsallowsyncptr', ''), + ('checkbox', 'idnsallowsyncptr', 'checked'), ], } diff --git a/ipatests/test_webui/test_host.py b/ipatests/test_webui/test_host.py index 09200061b..055224a0d 100644 --- a/ipatests/test_webui/test_host.py +++ b/ipatests/test_webui/test_host.py @@ -61,14 +61,14 @@ class host_tasks(UI_driver): ] if ip: add_data.append(('textbox', 'ip_address', ip)) - add_data.append(('checkbox', 'force', '')) + add_data.append(('checkbox', 'force', None)) del_data = [ - ('checkbox', 'updatedns', '') + ('checkbox', 'updatedns', None) ] else: add_data = [ ('textbox', 'fqdn', '%s.%s' % (host, domain)), - ('checkbox', 'force', ''), + ('checkbox', 'force', None), ] del_data = None @@ -204,7 +204,7 @@ class test_host(host_tasks): http://www.freeipa.org/page/V3/Kerberos_Flags """ name = 'ipakrbokasdelegate' - mod = {'mod': [('checkbox', name, '')]} + mod = {'mod': [('checkbox', name, None)]} checked = ['checked'] self.init_app() diff --git a/ipatests/test_webui/test_service.py b/ipatests/test_webui/test_service.py index d2e7ad772..8ed2e15b5 100644 --- a/ipatests/test_webui/test_service.py +++ b/ipatests/test_webui/test_service.py @@ -41,7 +41,7 @@ class sevice_tasks(UI_driver): ('combobox', 'host', host) ], 'mod': [ - ('checkbox', 'ipakrbokasdelegate', ''), + ('checkbox', 'ipakrbokasdelegate', None), ], } @@ -177,7 +177,7 @@ class test_service(sevice_tasks): """ pkey = self.get_http_pkey() name = 'ipakrbokasdelegate' - mod = {'mod': [('checkbox', name, '')]} + mod = {'mod': [('checkbox', name, None)]} checked = ['checked'] self.init_app() diff --git a/ipatests/test_webui/ui_driver.py b/ipatests/test_webui/ui_driver.py index a416658ed..f0b9b4362 100644 --- a/ipatests/test_webui/ui_driver.py +++ b/ipatests/test_webui/ui_driver.py @@ -1005,7 +1005,7 @@ class UI_driver(object): elif widget_type == 'radio': self.check_option(key, val, parent) elif widget_type == 'checkbox': - self.check_option(key, parent=parent) + self.check_option(key, val, parent=parent) elif widget_type == 'selectbox': self.select('select[name=%s]' % key, val, parent) elif widget_type == 'combobox': -- cgit