From 941e9686a379aea56900d8e3194cef231c4e1406 Mon Sep 17 00:00:00 2001 From: Jan Cholasta Date: Thu, 7 Mar 2013 11:21:05 +0100 Subject: Use encoded values from entry objects directly when adding new entries. https://fedorahosted.org/freeipa/ticket/3521 --- ipapython/ipaldap.py | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) (limited to 'ipapython') diff --git a/ipapython/ipaldap.py b/ipapython/ipaldap.py index d1a02bbd0..b54299a23 100644 --- a/ipapython/ipaldap.py +++ b/ipapython/ipaldap.py @@ -1685,9 +1685,6 @@ class LDAPClient(object): else: assert isinstance(entry_or_dn, DN) entry_attrs = self.make_entry(entry_or_dn, entry_attrs) - for key, value in entry_attrs.items(): - if value is None: - entry_attrs[key] = [] return entry_or_dn, entry_attrs def add_entry(self, entry, entry_attrs=None): @@ -1701,10 +1698,7 @@ class LDAPClient(object): dn, attrs = self._get_dn_and_attrs(entry, entry_attrs) # remove all [] values (python-ldap hates 'em) - attrs = dict((k, v) for k, v in attrs.iteritems() - # FIXME: Once entry values are always lists, this condition can - # be just "if v": - if v is not None and v != []) + attrs = dict((k, v) for k, v in attrs.raw.iteritems() if v) with self.error_handler(): self.conn.add_s(dn, attrs.items()) -- cgit