From 0359e2a0434c3c4e578a8d5fb3341084e82ada1c Mon Sep 17 00:00:00 2001 From: Jr Aquino Date: Mon, 18 Jul 2011 16:29:21 -0700 Subject: Return correct "RunAs External Group" when removing members If you used sudorule-remove-runasgroup to remove a member that member still appeared in the command output when --all was included (it isn't a default attribute). This was due to post-processing to evaluate external users/groups, the entry was actually updated properly. https://fedorahosted.org/freeipa/ticket/1348 --- ipalib/plugins/sudorule.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'ipalib/plugins') diff --git a/ipalib/plugins/sudorule.py b/ipalib/plugins/sudorule.py index 55d2904f5..33c8fdb6e 100644 --- a/ipalib/plugins/sudorule.py +++ b/ipalib/plugins/sudorule.py @@ -503,8 +503,8 @@ class sudorule_remove_runasuser(LDAPRemoveMember): # Run through the user failures and gracefully remove any defined as # as an externaluser. if 'ipasudorunas' in failed and 'user' in failed['ipasudorunas']: - (dn, entry_attrs) = ldap.get_entry(dn, ['ipasudorunasextuser']) - external_users = entry_attrs.get('ipasudorunasextuser', []) + (dn, entry_attrs_) = ldap.get_entry(dn, ['ipasudorunasextuser']) + external_users = entry_attrs_.get('ipasudorunasextuser', []) failed_users = [] completed_external = 0 for user in failed['ipasudorunas']['user']: @@ -573,8 +573,8 @@ class sudorule_remove_runasgroup(LDAPRemoveMember): # Run through the group failures and gracefully remove any defined as # as an external group. if 'ipasudorunasgroup' in failed and 'group' in failed['ipasudorunasgroup']: - (dn, entry_attrs) = ldap.get_entry(dn, ['ipasudorunasextgroup']) - external_groups = entry_attrs.get('ipasudorunasextgroup', []) + (dn, entry_attrs_) = ldap.get_entry(dn, ['ipasudorunasextgroup']) + external_groups = entry_attrs_.get('ipasudorunasextgroup', []) failed_groups = [] completed_external = 0 for group in failed['ipasudorunasgroup']['group']: -- cgit