From 0700f4d7cae9b0b25214b117715dd91a6ccb1132 Mon Sep 17 00:00:00 2001 From: Rob Crittenden Date: Fri, 26 Feb 2010 12:30:01 -0500 Subject: Don't try to revoke a cert that is already revoked. We get a bit of an unusual error message back from dogtag when trying to revoke a revoked cert so check its status first. --- ipalib/plugins/cert.py | 17 ++++++++++++++--- 1 file changed, 14 insertions(+), 3 deletions(-) (limited to 'ipalib/plugins/cert.py') diff --git a/ipalib/plugins/cert.py b/ipalib/plugins/cert.py index 426e6d532..e266c9ac2 100644 --- a/ipalib/plugins/cert.py +++ b/ipalib/plugins/cert.py @@ -286,11 +286,18 @@ class cert_request(VirtualCommand): if 'usercertificate' in service: serial = get_serial(base64.b64encode(service['usercertificate'][0])) # revoke the certificate and remove it from the service - # entry before proceeding + # entry before proceeding. First we retrieve the certificate to + # see if it is already revoked, if not then we revoke it. try: - api.Command['cert_revoke'](unicode(serial), revocation_reason=4) + result = api.Command['cert_get'](unicode(serial))['result'] + if 'revocation_reason' not in result: + try: + api.Command['cert_revoke'](unicode(serial), revocation_reason=4) + except errors.NotImplementedError: + # some CA's might not implement revoke + pass except errors.NotImplementedError: - # some CA's might not implement revoke + # some CA's might not implement get pass api.Command['service_mod'](principal, usercertificate=None) @@ -367,6 +374,10 @@ class cert_get(VirtualCommand): label=_('Subject'), flags=['no_create', 'no_update', 'no_search'], ), + Str('revocation_reason?', + label=_('Revocation reason'), + flags=['no_create', 'no_update', 'no_search'], + ), ) operation="retrieve certificate" -- cgit