From 165d26ce2b5d6fefe26679822cc274843de889dd Mon Sep 17 00:00:00 2001 From: Rob Crittenden Date: Wed, 28 May 2008 22:46:08 -0400 Subject: Make check_inst() a standalone function in bindinstance. When an install instance is created that contains a pointer to a sysrestore point it loads in the current configuration when instantiated. If an instance is instantiated but not used then changes may occur to the system state that it is unaware of. So one needs to take care in the order that things are done to avoid losing information. When bind was setup it was overwriting all data in sysrestore.state and leaving just a [named] section. This caused problems at uninstall. 448173 --- ipa-server/ipaserver/bindinstance.py | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) (limited to 'ipa-server/ipaserver') diff --git a/ipa-server/ipaserver/bindinstance.py b/ipa-server/ipaserver/bindinstance.py index 3ddbefe1b..5badf8603 100644 --- a/ipa-server/ipaserver/bindinstance.py +++ b/ipa-server/ipaserver/bindinstance.py @@ -28,6 +28,14 @@ import service from ipa import sysrestore from ipa import ipautil +def check_inst(): + # So far this file is always present in both RHEL5 and Fedora if all the necessary + # bind packages are installed (RHEL5 requires also the pkg: caching-nameserver) + if not os.path.exists('/etc/named.rfc1912.zones'): + return False + + return True + class BindInstance(service.Service): def __init__(self, fstore=None): service.Service.__init__(self, "named") @@ -52,14 +60,6 @@ class BindInstance(service.Service): self.__setup_sub_dict() - def check_inst(self): - # So far this file is always present in both RHEL5 and Fedora if all the necessary - # bind packages are installed (RHEL5 requires also the pkg: caching-nameserver) - if not os.path.exists('/etc/named.rfc1912.zones'): - return False - - return True - def create_sample_bind_zone(self): bind_txt = ipautil.template_file(ipautil.SHARE_DIR + "bind.zone.db.template", self.sub_dict) [bind_fd, bind_name] = tempfile.mkstemp(".db","sample.zone.") -- cgit