From 996a3f669898e4fc764867c63d9da87aa3b35854 Mon Sep 17 00:00:00 2001 From: Mark McLoughlin Date: Tue, 22 Jan 2008 16:42:45 +0000 Subject: Fix not so random random passwords If you run ipa_generate_password() multiple times, one after the other, then you get the same password each time. This is because it uses the current time to seed the pseudo random number generator. The easiest solution is to just use the default method which seeds itself from /dev/urandom if available, and uses a fractional time value otherwise. Signed-off-by: Mark McLoughlin --- ipa-python/ipautil.py | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) (limited to 'ipa-python/ipautil.py') diff --git a/ipa-python/ipautil.py b/ipa-python/ipautil.py index 32faabeab..ba12f3948 100644 --- a/ipa-python/ipautil.py +++ b/ipa-python/ipautil.py @@ -24,8 +24,7 @@ import string import tempfile import logging import subprocess -from random import Random -from time import gmtime +import random import os, sys, traceback, readline import stat import shutil @@ -364,8 +363,7 @@ def parse_generalized_time(timestr): def ipa_generate_password(): rndpwd = '' - r = Random() - r.seed(gmtime()) + r = random.Random() for x in range(12): # rndpwd += chr(r.randint(32,126)) rndpwd += chr(r.randint(65,90)) #stricter set for testing -- cgit