From 216505d2a066fd0afb8228b7f05089a7f7d5ab19 Mon Sep 17 00:00:00 2001 From: Martin Kosek Date: Tue, 8 Nov 2011 17:59:45 +0100 Subject: Fix coverity issues in client CLI tools This patch fixes 2 coverity issues: * ipa-client/config.c: CID 11090: Resource leak * ipa-client/ipa-getkeytab.c: CID 11018: Unchecked return value https://fedorahosted.org/freeipa/ticket/2035 --- ipa-client/ipa-getkeytab.c | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) (limited to 'ipa-client/ipa-getkeytab.c') diff --git a/ipa-client/ipa-getkeytab.c b/ipa-client/ipa-getkeytab.c index 5a521d041..28ef5b5a5 100644 --- a/ipa-client/ipa-getkeytab.c +++ b/ipa-client/ipa-getkeytab.c @@ -82,14 +82,24 @@ static int ldap_sasl_interact(LDAP *ld, unsigned flags, void *priv_data, void *s krberr = krb5_init_context(&krbctx); if (krberr) { - fprintf(stderr, _("Kerberos context initialization failed\n")); + fprintf(stderr, _("Kerberos context initialization failed: %s (%d)\n"), + error_message(krberr), krberr); in->result = NULL; in->len = 0; ret = LDAP_LOCAL_ERROR; break; } - krb5_unparse_name(krbctx, princ, &outname); + krberr = krb5_unparse_name(krbctx, princ, &outname); + + if (krberr) { + fprintf(stderr, _("Unable to parse principal: %s (%d)\n"), + error_message(krberr), krberr); + in->result = NULL; + in->len = 0; + ret = LDAP_LOCAL_ERROR; + break; + } in->result = outname; in->len = strlen(outname); -- cgit