From 4b4ecef4a32319932f31413feaf60e0dbfa96973 Mon Sep 17 00:00:00 2001
From: "Endi S. Dewata" <edewata@redhat.com>
Date: Wed, 29 Sep 2010 00:52:56 -0500
Subject: Added error handler for ipa_cmd().

The ipa_cmd() has been modified such that when an error occurs a
dialog box will appear showing the error message with 2 buttons:
Retry and Cancel. If Retry is clicked, it will attempt to execute
the same operation again. If Cancel is clicked, the operation will
be canceled and the control is returned to the caller.

New unit tests have been added to test ipa_cmd() on successfull
and unsuccessfull cases.

The associate.js, details.js, entity.js, search.js, and webui.js
have been modified to display the error message inside the page.
This behavior can be changed in the future (e.g. redirect to error
page).

The navigation.js and webui.js have been modified to render only
the visible tabs. This improves the performance and reduce hidden
errors. The navigation unit test has been modified to reflect this
behavior.

Some variables/functions also have been renamed for consistency.
---
 install/static/test/navigation_tests.js | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

(limited to 'install/static/test/navigation_tests.js')

diff --git a/install/static/test/navigation_tests.js b/install/static/test/navigation_tests.js
index 16b3ae925..4144e81a4 100644
--- a/install/static/test/navigation_tests.js
+++ b/install/static/test/navigation_tests.js
@@ -41,17 +41,17 @@ test("Testing nav_create().", function() {
 
     }
     ipa_objs= {};
-    var navigation = $('<div id="navigation"/>');
+    var navigation = $('<div id="navigation"/>').appendTo(document.body);
     var user_mock_called = false;
     var group_mock_called = false;
     nav_create(mock_tabs_lists, navigation, 'tabs')
-    ok(user_mock_called, "mock setup was called");
-    ok(group_mock_called, "mock setup was called");
+    ok(user_mock_called, "mock user setup was called");
+    ok(!group_mock_called, "mock group setup was not called because the tab is inactive");
     same( navigation[0].children.length, 2, "Two Child tabs");
     same( navigation[0].children[1].id, 'identity', "Identity Tab");
     same( navigation[0].children[1].children[1].id, 'user', "User Tab");
     same( navigation[0].children[1].children[2].id, 'group', "User Tab");
-
+    navigation.remove();
 });
 
 test("Testing  nav_select_tabs().", function() {
@@ -64,12 +64,14 @@ test("Testing  nav_select_tabs().", function() {
                 {name:'two', label:'Two', setup: function (){}},
             ]}];
 
-    var navigation = $('<div id="navigation"/>');
+    var navigation = $('<div id="navigation"/>').appendTo(document.body);
 
     nav_create(mock_tabs_lists, navigation, 'tabs')
 
     $.bbq.pushState({"identity":2});
     nav_select_tabs(mock_tabs_lists, navigation);
     same( navigation[0].children[1].children[2].id, 'two', "Tab two");
+    $.bbq.removeState(["identity"]);
 
+    navigation.remove();
 });
-- 
cgit