From d03ffeabe20c8f336d536232d9d6d2ce2087b152 Mon Sep 17 00:00:00 2001 From: Martin Kosek Date: Tue, 11 Jan 2011 16:32:52 +0100 Subject: Unchecked return value of calloc Omiting return value of calloc in ipa_pwd_extop.c could lead to memory access issues when memory is full. This patch adds return value check. https://fedorahosted.org/freeipa/ticket/717 --- daemons/ipa-slapi-plugins/ipa-pwd-extop/ipa_pwd_extop.c | 7 +++++++ 1 file changed, 7 insertions(+) (limited to 'daemons') diff --git a/daemons/ipa-slapi-plugins/ipa-pwd-extop/ipa_pwd_extop.c b/daemons/ipa-slapi-plugins/ipa-pwd-extop/ipa_pwd_extop.c index 117ccf083..5867f0846 100644 --- a/daemons/ipa-slapi-plugins/ipa-pwd-extop/ipa_pwd_extop.c +++ b/daemons/ipa-slapi-plugins/ipa-pwd-extop/ipa_pwd_extop.c @@ -853,6 +853,13 @@ static int ipapwd_setkeytab(Slapi_PBlock *pb, struct ipapwd_krbcfg *krbcfg) char * enrolledBy = slapi_entry_attr_get_charptr(targetEntry, "enrolledBy"); if (NULL == enrolledBy) { evals = (Slapi_Value **)calloc(2, sizeof(Slapi_Value *)); + + if (!evals) { + LOG_OOM(); + slapi_mods_free(&smods); + goto free_and_return; + } + evals[0] = slapi_value_new_string(bindDN); slapi_mods_add_mod_values(smods, LDAP_MOD_ADD, "enrolledBy", evals); } else { -- cgit