From c94d20cfd8cc1bd8cd8152b19d6807b654286197 Mon Sep 17 00:00:00 2001 From: Martin Kosek Date: Fri, 14 Jan 2011 10:24:04 +0100 Subject: Unchecked return values in SLAPI plugins Return values weren't checked in several cases which could have lead to unhandled errors. https://fedorahosted.org/freeipa/ticket/722 --- daemons/ipa-kpasswd/ipa_kpasswd.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) (limited to 'daemons/ipa-kpasswd') diff --git a/daemons/ipa-kpasswd/ipa_kpasswd.c b/daemons/ipa-kpasswd/ipa_kpasswd.c index a506cec1d..dd2b4b857 100644 --- a/daemons/ipa-kpasswd/ipa_kpasswd.c +++ b/daemons/ipa-kpasswd/ipa_kpasswd.c @@ -491,9 +491,13 @@ int ldap_pwd_change(char *client_name, char *realm_name, krb5_data pwd, char **e goto done; } - ber_printf(ctrl, "{tstO}", + ret = ber_printf(ctrl, "{tstO}", LDAP_TAG_EXOP_MODIFY_PASSWD_ID, userdn, LDAP_TAG_EXOP_MODIFY_PASSWD_NEW, &newpw); + if (ret < 0) { + syslog(LOG_ERR, "ber printf failed!"); + goto done; + } ret = ber_flatten(ctrl, &control); if (ret < 0) { -- cgit