From f96257397e8f1cb8a307e6ec0e48bd3570a16671 Mon Sep 17 00:00:00 2001 From: Simo Sorce Date: Tue, 27 Aug 2013 09:24:32 -0400 Subject: kdb-mspac: Fix out of bounds memset This memset was harmless as the following data is then set again, but an optimizing compiler might conceivably reorder instructions causing issues. CoverityID: 11909 Fixes: https://fedorahosted.org/freeipa/ticket/3883 --- daemons/ipa-kdb/ipa_kdb_mspac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/daemons/ipa-kdb/ipa_kdb_mspac.c b/daemons/ipa-kdb/ipa_kdb_mspac.c index 32e6ca365..ac6a6eb65 100644 --- a/daemons/ipa-kdb/ipa_kdb_mspac.c +++ b/daemons/ipa-kdb/ipa_kdb_mspac.c @@ -775,7 +775,7 @@ static krb5_error_code ipadb_fill_info3(struct ipadb_context *ipactx, } /* always zero out, not used for Krb, only NTLM */ - memset(&info3->base.LMSessKey, '\0', sizeof(info3->base.key)); + memset(&info3->base.LMSessKey, '\0', sizeof(info3->base.LMSessKey)); /* TODO: fill based on objectclass, user vs computer, etc... */ info3->base.acct_flags = ACB_NORMAL; /* samr_AcctFlags */ -- cgit