From bb6c0b9c634f26ae5d16079b3a66841ac0ce60cc Mon Sep 17 00:00:00 2001 From: Petr Vobornik Date: Fri, 12 Jun 2015 15:59:48 +0200 Subject: topology: fix swapped topologysegment-reinitialize behavior setting "nsds5BeginReplicaRefresh;left" to "start" reinintializes the right node and not the left node. This patch fixes API to match the behavior. part of: https://fedorahosted.org/freeipa/ticket/4302 Reviewed-By: Martin Babinsky --- ipalib/plugins/topology.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/ipalib/plugins/topology.py b/ipalib/plugins/topology.py index be2ac0bd2..494d3bb0a 100644 --- a/ipalib/plugins/topology.py +++ b/ipalib/plugins/topology.py @@ -294,9 +294,11 @@ class topologysegment_reinitialize(LDAPQuery): msg = _('Stopping of replication refresh for segment: "' '%(pkey)s" requested.') - if left: - entry['nsds5beginreplicarefresh;left'] = [action] + # left and right are swapped because internally it's a push not + # pull operation if right: + entry['nsds5beginreplicarefresh;left'] = [action] + if left: entry['nsds5beginreplicarefresh;right'] = [action] self.obj.backend.update_entry(entry) -- cgit