summaryrefslogtreecommitdiffstats
path: root/tests/util.py
Commit message (Collapse)AuthorAgeFilesLines
* Do not sort dictionaries in assert_deepequal utility functionAna Krivokapic2013-04-191-2/+7
| | | | | | | | Sorting lists of dictionaries in assert_deepequal was causing inconsistencies in unit test execution. To fix this, do not sort lists if their elements are dictionaries. https://fedorahosted.org/freeipa/ticket/3562
* Use DN objects instead of stringsJohn Dennis2012-08-121-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Convert every string specifying a DN into a DN object * Every place a dn was manipulated in some fashion it was replaced by the use of DN operators * Add new DNParam parameter type for parameters which are DN's * DN objects are used 100% of the time throughout the entire data pipeline whenever something is logically a dn. * Many classes now enforce DN usage for their attributes which are dn's. This is implmented via ipautil.dn_attribute_property(). The only permitted types for a class attribute specified to be a DN are either None or a DN object. * Require that every place a dn is used it must be a DN object. This translates into lot of:: assert isinstance(dn, DN) sprinkled through out the code. Maintaining these asserts is valuable to preserve DN type enforcement. The asserts can be disabled in production. The goal of 100% DN usage 100% of the time has been realized, these asserts are meant to preserve that. The asserts also proved valuable in detecting functions which did not obey their function signatures, such as the baseldap pre and post callbacks. * Moved ipalib.dn to ipapython.dn because DN class is shared with all components, not just the server which uses ipalib. * All API's now accept DN's natively, no need to convert to str (or unicode). * Removed ipalib.encoder and encode/decode decorators. Type conversion is now explicitly performed in each IPASimpleLDAPObject method which emulates a ldap.SimpleLDAPObject method. * Entity & Entry classes now utilize DN's * Removed __getattr__ in Entity & Entity clases. There were two problems with it. It presented synthetic Python object attributes based on the current LDAP data it contained. There is no way to validate synthetic attributes using code checkers, you can't search the code to find LDAP attribute accesses (because synthetic attriutes look like Python attributes instead of LDAP data) and error handling is circumscribed. Secondly __getattr__ was hiding Python internal methods which broke class semantics. * Replace use of methods inherited from ldap.SimpleLDAPObject via IPAdmin class with IPAdmin methods. Directly using inherited methods was causing us to bypass IPA logic. Mostly this meant replacing the use of search_s() with getEntry() or getList(). Similarly direct access of the LDAP data in classes using IPAdmin were replaced with calls to getValue() or getValues(). * Objects returned by ldap2.find_entries() are now compatible with either the python-ldap access methodology or the Entity/Entry access methodology. * All ldap operations now funnel through the common IPASimpleLDAPObject giving us a single location where we interface to python-ldap and perform conversions. * The above 4 modifications means we've greatly reduced the proliferation of multiple inconsistent ways to perform LDAP operations. We are well on the way to having a single API in IPA for doing LDAP (a long range goal). * All certificate subject bases are now DN's * DN objects were enhanced thusly: - find, rfind, index, rindex, replace and insert methods were added - AVA, RDN and DN classes were refactored in immutable and mutable variants, the mutable variants are EditableAVA, EditableRDN and EditableDN. By default we use the immutable variants preserving important semantics. To edit a DN cast it to an EditableDN and cast it back to DN when done editing. These issues are fully described in other documentation. - first_key_match was removed - DN equalty comparison permits comparison to a basestring * Fixed ldapupdate to work with DN's. This work included: - Enhance test_updates.py to do more checking after applying update. Add test for update_from_dict(). Convert code to use unittest classes. - Consolidated duplicate code. - Moved code which should have been in the class into the class. - Fix the handling of the 'deleteentry' update action. It's no longer necessary to supply fake attributes to make it work. Detect case where subsequent update applies a change to entry previously marked for deletetion. General clean-up and simplification of the 'deleteentry' logic. - Rewrote a couple of functions to be clearer and more Pythonic. - Added documentation on the data structure being used. - Simplfy the use of update_from_dict() * Removed all usage of get_schema() which was being called prior to accessing the .schema attribute of an object. If a class is using internal lazy loading as an optimization it's not right to require users of the interface to be aware of internal optimization's. schema is now a property and when the schema property is accessed it calls a private internal method to perform the lazy loading. * Added SchemaCache class to cache the schema's from individual servers. This was done because of the observation we talk to different LDAP servers, each of which may have it's own schema. Previously we globally cached the schema from the first server we connected to and returned that schema in all contexts. The cache includes controls to invalidate it thus forcing a schema refresh. * Schema caching is now senstive to the run time context. During install and upgrade the schema can change leading to errors due to out-of-date cached schema. The schema cache is refreshed in these contexts. * We are aware of the LDAP syntax of all LDAP attributes. Every attribute returned from an LDAP operation is passed through a central table look-up based on it's LDAP syntax. The table key is the LDAP syntax it's value is a Python callable that returns a Python object matching the LDAP syntax. There are a handful of LDAP attributes whose syntax is historically incorrect (e.g. DistguishedNames that are defined as DirectoryStrings). The table driven conversion mechanism is augmented with a table of hard coded exceptions. Currently only the following conversions occur via the table: - dn's are converted to DN objects - binary objects are converted to Python str objects (IPA convention). - everything else is converted to unicode using UTF-8 decoding (IPA convention). However, now that the table driven conversion mechanism is in place it would be trivial to do things such as converting attributes which have LDAP integer syntax into a Python integer, etc. * Expected values in the unit tests which are a DN no longer need to use lambda expressions to promote the returned value to a DN for equality comparison. The return value is automatically promoted to a DN. The lambda expressions have been removed making the code much simpler and easier to read. * Add class level logging to a number of classes which did not support logging, less need for use of root_logger. * Remove ipaserver/conn.py, it was unused. * Consolidated duplicate code wherever it was found. * Fixed many places that used string concatenation to form a new string rather than string formatting operators. This is necessary because string formatting converts it's arguments to a string prior to building the result string. You can't concatenate a string and a non-string. * Simplify logic in rename_managed plugin. Use DN operators to edit dn's. * The live version of ipa-ldap-updater did not generate a log file. The offline version did, now both do. https://fedorahosted.org/freeipa/ticket/1670 https://fedorahosted.org/freeipa/ticket/1671 https://fedorahosted.org/freeipa/ticket/1672 https://fedorahosted.org/freeipa/ticket/1673 https://fedorahosted.org/freeipa/ticket/1674 https://fedorahosted.org/freeipa/ticket/1392 https://fedorahosted.org/freeipa/ticket/2872
* Check whether the default user group is POSIX when adding new user with ↵Jan Cholasta2012-04-051-0/+8
| | | | | | --noprivate. ticket 2572
* Test the batch pluginPetr Viktorin2012-04-031-0/+3
| | | | | | | | | This adds tests for the batch plugin, and changes its output declaration to allow results as tuples (this tripped validation). The assert_deepequal function ignores the order of items in lists. Document this in its docstring, and use a custom checker for the batch plugin results.
* Fix little test errorsPetr Viktorin2012-04-031-2/+2
| | | | | | | | | | | Two test methods in test_rpcserver had the same name; the first didn't get to run. Another duplicate pair was in test_hbac_plugin with the same name; the ignored test had small error in it. check_TypeError used a wrong constant name An error reporting function in test.util used uninitialized argument names. This patch fixes these problems.
* Sort lists so order is predictable and tests pass as expected.Rob Crittenden2011-08-311-3/+5
| | | | Related to https://fedorahosted.org/freeipa/ticket/1272
* assert_deepequal supports callback for equality testingJohn Dennis2011-06-221-1/+10
|
* Change FreeIPA license to GPLv3+Jakub Hrozek2010-12-201-5/+5
| | | | | | | | | | The changes include: * Change license blobs in source files to mention GPLv3+ not GPLv2 only * Add GPLv3+ license text * Package COPYING not LICENSE as the license blobs (even the old ones) mention COPYING specifically, it is also more common, I think https://fedorahosted.org/freeipa/ticket/239
* Finish deferred translation mechanismJason Gerard DeRose2010-03-161-4/+2
|
* localize doc stringsJohn Dennis2010-03-081-2/+0
| | | | | | | | | | | | A number of doc strings were not localized, wrap them in _(). Some messages were not localized, wrap them in _() Fix a couple of failing tests: The method name in RPC should not be unicode. The doc attribute must use the .msg attribute for comparison. Also clean up imports of _() The import should come from ipalib or ipalib.text, not ugettext from request.
* Fixed xmlrpc_test.fuzzy_digits for Fedora12Jason Gerard DeRose2010-01-221-1/+1
|
* Added Fuzzy docstrings; make-test now runs doctests in tests/*; fixed ↵Jason Gerard DeRose2009-12-181-16/+89
| | | | 'existant' mispelling
* Fuzzy feelingsJason Gerard DeRose2009-12-171-2/+59
|
* Take 2: Extensible return values and validation; steps toward a single ↵Jason Gerard DeRose2009-12-101-0/+82
| | | | output_for_cli(); enable more webUI stuff
* Added stuff for managing connections and new Executioner backend base classJason Gerard DeRose2009-02-031-3/+3
|
* Sundry work getting ready to switch to new XML-RPC client/server codeJason Gerard DeRose2009-02-031-0/+7
|
* Added rpc.xmlclient backend plugin for forwarding; added corresponding unit ↵Jason Gerard DeRose2009-01-191-0/+45
| | | | tests
* New Param: implemented a base Param._convert_scalar() method; added ↵Jason Gerard DeRose2009-01-131-0/+9
| | | | Param.type_error attribute for ConversionError message
* New Param: updated Bytes and Str length rules to use new rule(_, value) ↵Jason Gerard DeRose2009-01-131-1/+13
| | | | calling signature; updated corresponding unit tests
* New Param: decided on calling signature for rules; added unit tests for ↵Jason Gerard DeRose2009-01-051-2/+5
| | | | Bytes._rule_minlength, _rule_maxlength, and _rule_length
* New Param: Added Param.get_label() method for a way to retrieve translated ↵Jason Gerard DeRose2009-01-051-2/+2
| | | | message at request time
* Quite a bit of work on new public errors and their unit testsJason Gerard DeRose2009-01-041-0/+8
|
* Added request.ugettext() and request.ungettext() functions; added ↵Jason Gerard DeRose2009-01-041-0/+35
| | | | corresponding unit tests
* Moved setting of run-time variables from Env.__init__() to Env._bootstrap()Jason Gerard DeRose2008-12-221-4/+0
|
* Stared some RPC-related error cleanup; started work on ipa_server.rcp.xmlrpc ↵Jason Gerard DeRose2008-11-241-0/+57
| | | | plugin
* Renamed ipalib.get_standard_api() to create_api()Jason Gerard DeRose2008-11-111-1/+1
|
* Finished fist draft of plugin tutorial in ipalib/__init__.py docstringJason Gerard DeRose2008-11-071-2/+1
|
* Added tests.util.get_api() function to create a standard (api, home) tuple ↵Jason Gerard DeRose2008-10-301-2/+19
| | | | for unit testing
* Finished Env._finalize_core() and corresponding unit testsJason Gerard DeRose2008-10-241-0/+8
|
* Added tests.util.TempHome class for created a tempdir and setting ↵Jason Gerard DeRose2008-10-241-2/+14
| | | | os.environ['HOME'] to it; updated various unit tests for Env so they are run using a tempdir for home
* Added ipalib/constants.py; added Env._load_config() method along with ↵Jason Gerard DeRose2008-10-241-0/+43
| | | | comprehensive unit tests for same
* Renamed tests/tstutil.py to tests/util.pyJason Gerard DeRose2008-10-071-0/+147