summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Remove 389-ds upgrade state during uninstallRob Crittenden2011-08-251-0/+6
| | | | | | | | | | | | | When we perform an upgrade 389-ds is set to listen only on its ldapi port. Theoretically it should be restored to the previous state regardless of whether the upgrades were successful or not. To be sure that a subsequent re-install will be successful go ahead and remove the state for these options. Think of it as wearing a belt and suspenders. Otherwise a re-install could return an error message that IPA is already configured. https://fedorahosted.org/freeipa/ticket/1667
* Remove more 389-ds files/directories on uninstallation.Rob Crittenden2011-08-251-0/+17
| | | | | | | We were orphaning a few files/directories when uninstalling 389-instances both for IPA and dogtag. This should remove everything but the logs. ticket https://fedorahosted.org/freeipa/ticket/1700
* Disable reverse lookups in ipa-join and ipa-getkeytabRob Crittenden2011-08-252-0/+14
| | | | | | This prevents broken DNS from causing enrollment problems. https://fedorahosted.org/freeipa/ticket/1693
* Fixed host keytab status after setting OTP.Endi S. Dewata2011-08-263-48/+96
| | | | | | | The host details page has been modified to update the keytab status based on the data returned by the host-mod command for setting OTP. Ticket #1710
* Fixed host OTP status.Endi S. Dewata2011-08-265-155/+343
| | | | | | | The host details page has been modified to show the status of the OTP. Setting a new OTP is now done using a dialog box. Ticket #1710
* ticket 1669 - improve i18n docstring extractionJohn Dennis2011-08-2431-914/+634
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This patch reverts the use of pygettext for i18n string extraction. It was originally introduced because the help documentation for commands are in the class docstring and module docstring. Docstrings are a Python construct whereby any string which immediately follows a class declaration, function/method declaration or appears first in a module is taken to be the documentation for that object. Python automatically assigns that string to the __doc__ variable associated with the object. Explicitly assigning to the __doc__ variable is equivalent and permitted. We mark strings in the source for i18n translation by embedding them in _() or ngettext(). Specialized extraction tools (e.g. xgettext) scan the source code looking for strings with those markers and extracts the string for inclusion in a translation catalog. It was mistakingly assumed one could not mark for translation Python docstrings. Since some docstrings are vital for our command help system some method had to be devised to extract docstrings for the translation catalog. pygettext has the ability to locate and extract docstrings and it was introduced to acquire the documentation for our commands located in module and class docstrings. However pygettext was too large a hammer for this task, it lacked any fined grained ability to extract only the docstrings we were interested in. In practice it extracted EVERY docstring in each file it was presented with. This caused a large number strings to be extracted for translation which had no reason to be translated, the string might have been internal code documentation never meant to be seen by users. Often the superfluous docstrings were long, complex and likely difficult to translate. This placed an unnecessary burden on our volunteer translators. Instead what is needed is some method to extract only those strings intended for translation. We already have such a mechanism and it is already widely used, namely wrapping strings intended for translation in calls to _() or _negettext(), i.e. marking a string for i18n translation. Thus the solution to the docstring translation problem is to mark the docstrings exactly as we have been doing, it only requires that instead of a bare Python docstring we instead assign the marked string to the __doc__ variable. Using the hypothetical class foo as an example. class foo(Command): ''' The foo command takes out the garbage. ''' Would become: class foo(Command): __doc__ = _('The foo command takes out the garbage.') But which docstrings need to be marked for translation? The makeapi tool knows how to iterate over every command in our public API. It was extended to validate every command's documentation and report if any documentation is missing or not marked for translation. That information was then used to identify each docstring in the code which needed to be transformed. In summary what this patch does is: * Remove the use of pygettext (modification to install/po/Makefile.in) * Replace every docstring with an explicit assignment to __doc__ where the rhs of the assignment is an i18n marking function. * Single line docstrings appearing in multi-line string literals (e.g. ''' or """) were replaced with single line string literals because the multi-line literals were introducing unnecessary whitespace and newlines in the string extracted for translation. For example: ''' The foo command takes out the garbage. ''' Would appear in the translation catalog as: "\n The foo command takes out the garbage.\n " The superfluous whitespace and newlines are confusing to translators and requires us to strip leading and trailing whitespace from the translation at run time. * Import statements were moved from below the docstring to above it. This was necessary because the i18n markers are imported functions and must be available before the the doc is parsed. Technically only the import of the i18n markers had to appear before the doc but stylistically it's better to keep all the imports together. * It was observed during the docstring editing process that the command documentation was inconsistent with respect to the use of periods to terminate a sentence. Some doc had a trailing period, others didn't. Consistency was enforced by adding a period to end of every docstring if one was missing.
* ticket 1706 - internationalize cli help frameworkJohn Dennis2011-08-241-7/+7
| | | | | | | | | In cli.py is a framework for printing out help information. The command documentation being displayed is internationalized, however the text generated by the help framework itself is not internationalized. The strings output by the help subsystem need to be internationalized.
* ticket 1705 - internationalize help topicsJohn Dennis2011-08-247-11/+9
| | | | | | | | | | | | * Wrap each topic description in _() * Replace the use of if 'topic' in dir(module) with the more Pythonic and efficient getattr(module, 'topic', None) * Make sure to invoke unicode on the value returned from _() otherwise you'll get a GettextFactory instance, not a string * Clean up trailing whitespace errors
* ticket 1707 - add documentation validation to makeapi toolJohn Dennis2011-08-241-4/+116
| | | | | | | | | | | | | | | | | Iterate over all API commands and perform the following validation: * Every command must have documentation and it must be marked for international translation * Every module hosting a command must have documentation and it must be marked for international translation * Every module topic must be marked for international translation For every error found emit a diagnostic. Emit a summary of total errors found. Return error flag if errors found, zero otherwise.
* Retrieve password/keytab state when modifying a host.Rob Crittenden2011-08-252-0/+7
| | | | ticket https://fedorahosted.org/freeipa/ticket/1714
* Modify serial associator to use batchPetr Vobornik2011-08-252-37/+44
| | | | | | | | | | https://fedorahosted.org/freeipa/ticket/1688 The serial associator is used to execute a command multiple times with different parameters. This is used for adding/removing a user into/from multiple groups. It has some issues: Each command is executed one-by-one, so it could be slow. * If there's a failure the rest of the commands will not be executed. * This can be fixed by putting the commands into a batch and execute them at once.
* Fixed default map type in automount map adder dialog.Endi S. Dewata2011-08-253-65/+62
| | | | | | | The adder dialog for automount map has been modified to select the direct map by default. Ticket #1698
* Add option to only prompt once for passwords, use in entitle_registerRob Crittenden2011-08-244-5/+12
| | | | | | | | | A Password param always prompted to confirm the entered password. This doesn't make sense if you want to prompt for a password to another system like we do with entitlements. This adds a new boolean option to control the Password prompt parameter. https://fedorahosted.org/freeipa/ticket/1695
* Add label for HBAC services to show as membersRob Crittenden2011-08-241-0/+3
| | | | https://fedorahosted.org/freeipa/ticket/1711
* Add additional pam ftp services to HBAC, and a ftp HBAC service groupRob Crittenden2011-08-242-0/+44
| | | | | | This adds proftpd, pure-ftpd, vsftpd and gssftp. https://fedorahosted.org/freeipa/ticket/1703
* Validation of details facet before update ↵test-patches-2-1Petr Vobornik2011-08-254-10/+43
| | | | | | | | https://fedorahosted.org/freeipa/ticket/1676 The ticket is a duplicate of server error, but it revealed few UI errors. Newly performs validation of details facet before update. If validation fails, notification dialog is shown and command isn't executed. Fixed integer minimum and maximum value checking. Read-only and non-writable fields are no longer considered required.
* Fixed command partial failure handling.Endi S. Dewata2011-08-241-39/+45
| | | | | | | When a command returns a partial failure it should be treated as a success but the failures should still be displayed. Ticket #1628
* Show error in adding associationsPetr Vobornik2011-08-242-23/+93
| | | | https://fedorahosted.org/freeipa/ticket/1628
* Change the way has_keytab is determined, also check for password.Rob Crittenden2011-08-2416-34/+185
| | | | | | | | | | | | | | | | | | | | We need an indicator to see if a keytab has been set on host and service entries. We also need a way to know if a one-time password is set on a host. This adds an ACI that grants search on userPassword and krbPrincipalKey so we can do an existence search on them. This way we can tell if the attribute is set and create a fake attribute accordingly. When a userPassword is set on a host a keytab is generated against that password so we always set has_keytab to False if a password exists. This is fine because when keytab gets generated for the host the password is removed (hence one-time). This adds has_keytab/has_password to the user, host and service plugins. ticket https://fedorahosted.org/freeipa/ticket/1538
* Fix thread deadlock by using pthreads library instead of NSPR.Rob Crittenden2011-08-242-14/+12
| | | | | | | The 389-ds team is in the process of exposing slapi_rwlock which we will switch to when it is available. https://fedorahosted.org/freeipa/ticket/1630
* Suppress 389-ds debug output when starting servicesRob Crittenden2011-08-241-12/+49
| | | | | | If the user wants the output they can pass the --debug flag to ipactl. https://fedorahosted.org/freeipa/ticket/1402
* Removed unnecessary HBAC/sudo rule category modification.Endi S. Dewata2011-08-236-134/+40
| | | | | | | | | | Since the Add/Delete links in the association table are disabled when the category is set to 'all', it's no longer necessary to check the category before showing the add/delete dialogs and modify the category before adding entries. Thus, the IPA.rule_association_table_widget is no longer needed. Ticket #1692
* Verify that the external CA certificate files are correct.Jan Cholasta2011-08-232-7/+60
| | | | ticket 1572
* Add subscription-manager dependency for RHEL.Jan Cholasta2011-08-231-0/+6
| | | | ticket 1664
* Improve sudorule documentationJr Aquino2011-08-231-0/+11
| | | | | | | | Added brief explanations for the various Sudo components in the top level doc. Added doc entries for RunAs User and RunAs Group. https://fedorahosted.org/freeipa/ticket/1657
* Updated add and delete association dialog titles.Endi S. Dewata2011-08-238-278/+187
| | | | | | | | | | The association table widget and facet have been modified to accept titles for the add and delete dialogs. The table and facet definitions have been modified to specify the appropriate titles. Some unused code have been removed. Ticket #1629
* Search for users in all the naming contexts present on the directory server.Jan Cholasta2011-08-221-14/+25
| | | | ticket 1655, 1656
* Fix wording in examples of delegation plugin.Rob Crittenden2011-08-191-5/+5
| | | | https://fedorahosted.org/freeipa/ticket/1013
* Do batch logging on successful commands too, not just failures.Rob Crittenden2011-08-191-1/+1
| | | | This was an oversight for previous logging patch, ticket 1598
* Uncheck checkboxes in association after deletionPetr Vobornik2011-08-194-18/+35
| | | | https://fedorahosted.org/freeipa/ticket/1639
* Log each command in a batch separately.Rob Crittenden2011-08-192-2/+31
| | | | | | | This also fixes command logging in general, it wasn't working in most cases as a regression in ticket 1322. https://fedorahosted.org/freeipa/ticket/1598
* Add option to install without the automatic redirect to the Web UI.Jan Cholasta2011-08-186-8/+18
| | | | ticket 1570
* Fix automountlocation-import conflictsMartin Kosek2011-08-181-2/+14
| | | | | | | | | Do not fail import operation with DuplicateEntry when imported maps/keys conflict with maps/keys pre-created by automountlocation-add command. Currently, this applies for map 'auto.direct' and key '/-'. https://fedorahosted.org/freeipa/ticket/1551
* Replaced page dirty dialog title.Endi S. Dewata2011-08-192-2/+2
| | | | | | The title of page dirty dialog has been changed to 'Unsaved Changes'. Ticket #1653
* Removed 'Hide already enrolled' checkbox.Endi S. Dewata2011-08-194-38/+18
| | | | | | | | The 'Hide already enrolled' has been removed from the enrollment dialog because it is checked by default and entries that are already enrolled cannot be enrolled again. Ticket #1638
* Verify that passwords specified through command line options of ↵Jan Cholasta2011-08-181-0/+5
| | | | | | ipa-server-install meet the length requirement. ticket 1621
* Fix automountkey-modMartin Kosek2011-08-184-23/+49
| | | | | | | | | | | | | Fix automountkey-mod so that automountkey attribute is correctly updated. Add this test case to the unit tests. Make automountkey required for automountkey-mod, otherwise it would cause internal server error. Make --newinfo optional so that automountkey may be just renamed without changing its info attribute. https://fedorahosted.org/freeipa/ticket/1528
* Make sure messagebus is running prior to starting certmonger.Jan Cholasta2011-08-183-2/+12
| | | | ticket 1580
* Add information on setting api.env.host in the ipactl.8 man pageRob Crittenden2011-08-191-0/+2
| | | | ticket https://fedorahosted.org/freeipa/ticket/1390
* Fixed inconsistent layout for password reset dialog.Endi S. Dewata2011-08-181-48/+46
| | | | | | | The dialog box for resetting user password has been modified to use the standard layout. Ticket #1641
* ticket 1650 - compute accurate translation statisticsJohn Dennis2011-08-182-15/+21
| | | | | | | | | | | | | | | | ticket 1650 (https://fedorahosted.org/freeipa/ticket/1650) has an extensive discussion of the issues, please refer to that. This patch does the following: * does not count fuzzy translations when computing translation statistics via the "msg-stats" make target in install/po * adds a new make target called "pull-po" which pulls updated po files from Transifex (configure.ac includes some trailing whitespace fixes) * turns off the generation of fuzzy translation suggestions during the message merge phase.
* ticket 1661 - Update all po filesJohn Dennis2011-08-1821-5434/+2955
| | | | | | | | | | | | | | | | | | | | | | | | | | | After updating po's current translation status is: ipa.pot has 1329 messages. There are 21 po translation files. as: 0/1329 0.0% 1329 untranslated, 0 fuzzy bn_IN: 13/1329 1.0% 1316 untranslated, 0 fuzzy zh_CN: 133/1329 10.0% 1196 untranslated, 0 fuzzy zh_TW: 0/1329 0.0% 1329 untranslated, 0 fuzzy nl: 1/1329 0.1% 1328 untranslated, 0 fuzzy fr: 0/1329 0.0% 1329 untranslated, 0 fuzzy de: 27/1329 2.0% 1302 untranslated, 0 fuzzy el: 0/1329 0.0% 1329 untranslated, 0 fuzzy gu: 0/1329 0.0% 1329 untranslated, 0 fuzzy id: 89/1329 6.7% 1240 untranslated, 0 fuzzy ja_JP: 0/1329 0.0% 1329 untranslated, 0 fuzzy ja: 0/1329 0.0% 1329 untranslated, 0 fuzzy kn: 243/1329 18.3% 1086 untranslated, 0 fuzzy fa: 0/1329 0.0% 1329 untranslated, 0 fuzzy pl: 492/1329 37.0% 837 untranslated, 0 fuzzy pt_BR: 0/1329 0.0% 1329 untranslated, 0 fuzzy pt: 0/1329 0.0% 1329 untranslated, 0 fuzzy ru: 162/1329 12.2% 1167 untranslated, 0 fuzzy es: 1329/1329 100.0% 0 untranslated, 0 fuzzy sv: 0/1329 0.0% 1329 untranslated, 0 fuzzy uk: 1329/1329 100.0% 0 untranslated, 0 fuzzy
* ticket 1660 - update LINGUAS file, add missing po filesJohn Dennis2011-08-188-8/+54667
| | | | | | | Our LINGUAS file and the set of po files have diverged from what's on Transifex. We should update the LINGUAS file to match the set of translations on Transifex and add po files currently on Transifex but not in our git repo to our git repo.
* ticket 1659 - invalid i18n string in dns.pyJohn Dennis2011-08-181-3/+2
| | | | | | | | | dns.py at line 976 has an invalid i18n string and cannot be processed during message extraction causing message catalog generation to fail. The format parameters are trapped inside the i18n string. Also it's not necessary to promote the i18n string literal to unicode via the u prefix because the _() function returns unicode.
* Propagate environment when it is required.Alexander Bokovoy2011-08-171-0/+7
| | | | | https://fedorahosted.org/freeipa/ticket/1549 https://fedorahosted.org/freeipa/ticket/1550
* Add missing attribute labels for sudoruleMartin Kosek2011-08-171-0/+8
| | | | https://fedorahosted.org/freeipa/ticket/1571
* ticket 1600 - convert unittests to use DN objectsJohn Dennis2011-08-1621-326/+577
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We have a larger goal of replacing all DN creation via string formatting/concatenation with DN object operations because string operations are not a safe way to form a DN nor to compare a DN. This work needs to be broken into smaller chunks for easier review and testing. Addressing the unit tests first makes sense because we don't want to be modifying both the core code and the tests used to verify the core code simultaneously. If we modify the unittests first with existing core code and no regressions are found then we can move on to modifying parts of the core code with the belief the unittests can validate the changes in the core code. Also by doing the unittests first we also help to validate the DN objects are working correctly (although they do have an extensive unittest). The fundamental changes are: * replace string substitution & concatenation with DN object constructor * when comparing dn's the comparision is done after promotion to a DN object, then two DN objects are compared * when a list of string dn's are to be compared a new list is formed where each string dn is replaced by a DN object * because the unittest framework accepts a complex data structure of expected values where dn's are represeted as strings the unittest needs to express the expected value of a dn as a callable object (e.g. a lambda expression) which promotes the dn string to a DN object in order to do the comparision.
* ticket 1569 - Test DN object non-latin Unicode supportJohn Dennis2011-08-162-16/+116
| | | | | | | | | | | | | | | | | | | | | The DN unittest was lacking a test for i18n. The unittest was updated to store "Hello" in Arabic with both utf-8 and unicode and verify the values could be properly retrieved and converted to dn string syntax. During the testing a few problems were discovered and corrected. * passing in utf-8 caused an ASCII decode error becuase of Python's silly default encoding of ASCII. The fix was to explictly use the utf-8 codec. * there were a couple of places where encode/decode were not called correctly. * the internal attr and value members of the AVA class were renamed to explicitly show they are stored as unicode. Of course the unittest was updated as well.
* ticket 1568 - DN objects should support the insert methodJohn Dennis2011-08-162-3/+36
| | | | Add dn.insert() and update unittest
* Fixed problem selecting value from comboboxEndi S. Dewata2011-08-171-2/+2
| | | | | | | The IPA.combobox_widget has been modified to use the 'change' event to capture the selected value from the drop-down list. Ticket #1654
generated by cgit (git 2.34.1) at 2024-04-24 08:01:16 +0000