diff options
author | Petr Viktorin <pviktori@redhat.com> | 2012-04-17 12:42:35 -0400 |
---|---|---|
committer | Martin Kosek <mkosek@redhat.com> | 2012-06-20 15:18:42 +0200 |
commit | 1235dfa7bf4b249eb6da8eab8d8a2c7b0eef98db (patch) | |
tree | a972262b4ebfdc10de052a05e94cb8961e827041 /tests/test_ipalib/test_frontend.py | |
parent | 1484ccc4049dc42a5a8a71713253894ade401573 (diff) | |
download | freeipa-1235dfa7bf4b249eb6da8eab8d8a2c7b0eef98db.tar.gz freeipa-1235dfa7bf4b249eb6da8eab8d8a2c7b0eef98db.tar.xz freeipa-1235dfa7bf4b249eb6da8eab8d8a2c7b0eef98db.zip |
Fail on unknown Command options
When unknown keyword arguments are passed to a Command, raise an
error instead of ignoring them.
Options used when IPA calls its commands internally are listed
in a new Command attribute called internal_options, and allowed.
Previous patches (0b01751c, c45174d6, c5689e7f) made IPA not use
unknown keyword arguments in its own commands and tests, but since
that some violations were reintroduced in permission_find and tests.
Fix those.
Tests included; both a frontend unittest and a XML-RPC test via the
ping plugin (which was untested previously).
https://fedorahosted.org/freeipa/ticket/2509
Diffstat (limited to 'tests/test_ipalib/test_frontend.py')
-rw-r--r-- | tests/test_ipalib/test_frontend.py | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/tests/test_ipalib/test_frontend.py b/tests/test_ipalib/test_frontend.py index b717a43ad..5f7ce65fb 100644 --- a/tests/test_ipalib/test_frontend.py +++ b/tests/test_ipalib/test_frontend.py @@ -511,6 +511,11 @@ class test_Command(ClassChecker): assert e.count == 2 assert str(e) == "command 'example' takes at most 2 arguments" + # Test that OptionError is raised when an extra option is given: + o = self.get_instance() + e = raises(errors.OptionError, o.args_options_2_params, bad_option=True) + assert e.option == 'bad_option' + # Test that OverlapError is raised: o = self.get_instance(args=('one', 'two'), options=('three', 'four')) e = raises(errors.OverlapError, o.args_options_2_params, |