diff options
| author | Petr Viktorin <pviktori@redhat.com> | 2012-03-02 12:42:27 -0500 |
|---|---|---|
| committer | Martin Kosek <mkosek@redhat.com> | 2012-03-12 16:02:29 +0100 |
| commit | 1dc11a01d7e2a8e561b3a79aa97bf0939cd3fd25 (patch) | |
| tree | a1b4f8403f163761c2c0bcc070fb178dad8967c9 /ipaserver/plugins/ldap2.py | |
| parent | 71d134dfa03eb86066eeb331815647bdff04aaa8 (diff) | |
| download | freeipa-1dc11a01d7e2a8e561b3a79aa97bf0939cd3fd25.tar.gz freeipa-1dc11a01d7e2a8e561b3a79aa97bf0939cd3fd25.tar.xz freeipa-1dc11a01d7e2a8e561b3a79aa97bf0939cd3fd25.zip | |
Allow removing sudo commands with special characters from command groups
Previously the commands were compared as serialized strings.
Differences in serializations meant commands with special characters
weren't found in the checked list.
Use the DN class to compare DNs correctly.
https://fedorahosted.org/freeipa/ticket/2483
Diffstat (limited to 'ipaserver/plugins/ldap2.py')
| -rw-r--r-- | ipaserver/plugins/ldap2.py | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/ipaserver/plugins/ldap2.py b/ipaserver/plugins/ldap2.py index ffe2fba8a..dd5756735 100644 --- a/ipaserver/plugins/ldap2.py +++ b/ipaserver/plugins/ldap2.py @@ -1091,12 +1091,12 @@ class ldap2(CrudBackend, Encoder): (group_dn, group_entry_attrs) = self.get_entry(group_dn, [member_attr]) # remove dn from group entry's `member_attr` attribute - members = group_entry_attrs.get(member_attr, []) + members = [DN(m) for m in group_entry_attrs.get(member_attr, [])] try: - members.remove(dn.lower()) + members.remove(DN(dn)) except ValueError: raise errors.NotGroupMember() - group_entry_attrs[member_attr] = members + group_entry_attrs[member_attr] = [str(m) for m in members] # update group entry self.update_entry(group_dn, group_entry_attrs) |