diff options
| author | Lubomir Rintel <lubo.rintel@gooddata.com> | 2012-11-28 17:27:23 +0100 |
|---|---|---|
| committer | Martin Kosek <mkosek@redhat.com> | 2012-12-04 16:25:25 +0100 |
| commit | 8c553abbada942dd32bdfc70881b2b0a05f66a13 (patch) | |
| tree | 36ef3fd8c5cbb3f02cbf65c1d4ff6ea7f434d86f /ipapython | |
| parent | a9bac3d600bc8eb9699e146b1132f712cccabdfd (diff) | |
| download | freeipa-8c553abbada942dd32bdfc70881b2b0a05f66a13.tar.gz freeipa-8c553abbada942dd32bdfc70881b2b0a05f66a13.tar.xz freeipa-8c553abbada942dd32bdfc70881b2b0a05f66a13.zip | |
Drop unused readline import
The actual readline usage was removed in commit f19218f7
(Remove duplicate and unused utility code,
https://fedorahosted.org/freeipa/ticket/2650) and the import remained.
Readline should not be initialized if the output is not to terminal (and it
does no checks itself, so import in anything that would be useful to redirect
should be conditional), since it may garble the output [1]:
$ TERM=xterm python -c 'import readline' |hexdump -C
00000000 1b 5b 3f 31 30 33 34 68 |.[?1034h|
00000008
[1] https://bugzilla.redhat.com/show_bug.cgi?id=304181#c1
https://fedorahosted.org/freeipa/ticket/2691
https://fedorahosted.org/freeipa/ticket/3276
Diffstat (limited to 'ipapython')
| -rw-r--r-- | ipapython/ipautil.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/ipapython/ipautil.py b/ipapython/ipautil.py index c444d8c9e..10ad2c341 100644 --- a/ipapython/ipautil.py +++ b/ipapython/ipautil.py @@ -28,7 +28,7 @@ import string import tempfile import subprocess import random -import os, sys, traceback, readline +import os, sys, traceback import copy import stat import shutil |