diff options
| author | John Dennis <jdennis@redhat.com> | 2012-04-19 08:56:07 -0400 |
|---|---|---|
| committer | Martin Kosek <mkosek@redhat.com> | 2012-04-19 15:22:49 +0200 |
| commit | 885bb07bb1c5c7052aa04a5d2e43227fd1f6cd50 (patch) | |
| tree | b10c48c70fa6d0c8953d0403a1c0bc526865e841 /ipalib | |
| parent | 7f2ac4c71594f4895d949faffeb15562b1f5fa33 (diff) | |
| download | freeipa-885bb07bb1c5c7052aa04a5d2e43227fd1f6cd50.tar.gz freeipa-885bb07bb1c5c7052aa04a5d2e43227fd1f6cd50.tar.xz freeipa-885bb07bb1c5c7052aa04a5d2e43227fd1f6cd50.zip | |
Fix name error in hbactest
Ticket #2512
In hbactest.py there is a name error wrapped inside a try/except block
that ignores all errors so the code block exits prematurely leaving a
critical variable uninitialized.
The name error is the result of a cut-n-paste error that references a
variable that had never been initialized in the scope of the code
block. Python generates an exception when this variable is referenced
but because it's wrapped in a try/except block that catches all errors
and ignores all errors there is no evidence that something went wrong.
The fix is to use the correct variables.
At some point we may want to revist if ignoring all errors and
proceding as if nothing happened is actually correct. Alexander tells
me this mimics what SSSD does in the hbac rule processing, thus the
ignoring of errors is intentional. But in a plugin whose purpose is to
test and exercise hbac rules I'm not sure ignoring all errors is
really the right behavior.
Diffstat (limited to 'ipalib')
| -rw-r--r-- | ipalib/plugins/hbactest.py | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/ipalib/plugins/hbactest.py b/ipalib/plugins/hbactest.py index b81dca3de..78fac0241 100644 --- a/ipalib/plugins/hbactest.py +++ b/ipalib/plugins/hbactest.py @@ -325,7 +325,7 @@ class hbactest(Command): srchost_result = self.api.Command.host_show(request.srchost.name)['result'] groups = srchost_result['memberof_hostgroup'] if 'memberofindirect_hostgroup' in srchost_result: - groups += search_result['memberofindirect_hostgroup'] + groups += srchost_result['memberofindirect_hostgroup'] request.srchost.groups = sorted(set(groups)) except: pass @@ -338,7 +338,7 @@ class hbactest(Command): tgthost_result = self.api.Command.host_show(request.targethost.name)['result'] groups = tgthost_result['memberof_hostgroup'] if 'memberofindirect_hostgroup' in tgthost_result: - groups += search_result['memberofindirect_hostgroup'] + groups += tgthost_result['memberofindirect_hostgroup'] request.targethost.groups = sorted(set(groups)) except: pass |