diff options
author | Martin Kosek <mkosek@redhat.com> | 2012-03-20 15:35:54 +0100 |
---|---|---|
committer | Martin Kosek <mkosek@redhat.com> | 2012-03-20 15:37:53 +0100 |
commit | 9d0ef96c670f0ddae12f4a4cbf12d9e4e58607da (patch) | |
tree | 79a48b79b9177318ba7adf4e46502b11729fbfbf /ipalib | |
parent | f18cfd7de8e82d465cdd112decd262e6c901b2cb (diff) | |
download | freeipa-9d0ef96c670f0ddae12f4a4cbf12d9e4e58607da.tar.gz freeipa-9d0ef96c670f0ddae12f4a4cbf12d9e4e58607da.tar.xz freeipa-9d0ef96c670f0ddae12f4a4cbf12d9e4e58607da.zip |
Allow port numbers for idnsForwarders
Let user enter custom ports for zone conditional forwarders or
global forwarders in dnsconfig. Ports can be specified in
a standard BIND format: IP_ADDRESS [port PORT]
https://fedorahosted.org/freeipa/ticket/2462
Diffstat (limited to 'ipalib')
-rw-r--r-- | ipalib/plugins/dns.py | 28 |
1 files changed, 24 insertions, 4 deletions
diff --git a/ipalib/plugins/dns.py b/ipalib/plugins/dns.py index a10960a2c..251db476e 100644 --- a/ipalib/plugins/dns.py +++ b/ipalib/plugins/dns.py @@ -348,6 +348,24 @@ def _dns_record_name_validator(ugettext, value): except ValueError, e: return unicode(e) +def _validate_bind_forwarder(ugettext, forwarder): + ip_address, sep, port = forwarder.partition(u' port ') + + ip_address_validation = _validate_ipaddr(ugettext, ip_address) + + if ip_address_validation is not None: + return ip_address_validation + + if sep: + try: + port = int(port) + if port < 0 or port > 65535: + raise ValueError() + except ValueError: + return _('%(port)s is not a valid port' % dict(port=port)) + + return None + def _domain_name_validator(ugettext, value): try: validate_domain_name(value) @@ -1614,10 +1632,11 @@ class dnszone(LDAPObject): autofill=True, ), Str('idnsforwarders*', - _validate_ipaddr, + _validate_bind_forwarder, cli_name='forwarder', label=_('Zone forwarders'), - doc=_('A list of zone forwarders'), + doc=_('A list of global forwarders. A custom port can be specified ' \ + 'for each forwarder using a standard format "IP_ADDRESS port PORT"'), csv=True, ), StrEnum('idnsforwardpolicy?', @@ -2628,10 +2647,11 @@ class dnsconfig(LDAPObject): takes_params = ( Str('idnsforwarders*', - _validate_ipaddr, + _validate_bind_forwarder, cli_name='forwarder', label=_('Global forwarders'), - doc=_('A list of global forwarders'), + doc=_('A list of global forwarders. A custom port can be specified ' \ + 'for each forwarder using a standard format "IP_ADDRESS port PORT"'), csv=True, ), ) |